Change in ovirt-dwh[master]: packaging: setup: correctly configure Default.properties
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: correctly configure Default.properties
......................................................................
packaging: setup: correctly configure Default.properties
Change-Id: If03aca910ecb1ebe7746d2cf378dc1b16f62c49d
Bug-Url: https://bugzilla.redhat.com/1026947
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 6 insertions(+), 20 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22486
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If03aca910ecb1ebe7746d2cf378dc1b16f62c49d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
11 years
Change in ovirt-engine[ovirt-engine-3.3]: rest: fix xsd validation for Payload
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: rest: fix xsd validation for Payload
......................................................................
rest: fix xsd validation for Payload
volume id is optional parameter for payload,
so setting minOccurs to 0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031960
Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/22511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-live[master]: Update glusterfs version to 3.4.1
by obasan@redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: Update glusterfs version to 3.4.1
......................................................................
Update glusterfs version to 3.4.1
Version 3.4.0 fails to download, and current vdsm requires version
3.4.1.
Change-Id: I0d03e2fcf19f754622f447a0045742af1374216d
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M centos/kickstart/ovirt-live-base.ks.in
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22434
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d03e2fcf19f754622f447a0045742af1374216d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years
Change in ovirt-live[master]: boot: Fix kernel panic when booting from USB3 port
by obasan@redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: boot: Fix kernel panic when booting from USB3 port
......................................................................
boot: Fix kernel panic when booting from USB3 port
Centos builds the USB3 driver (xhci-hcd) as a module. The module was not
available during boot, which caused a kernel panic. This patch adds
kickstart device directive to ensure that xhci-hcd module is available
during boot.
Change-Id: If798b99abea32178f4105ec4cf94b833fc9c3bd4
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M centos/kickstart/ovirt-live-base.ks.in
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If798b99abea32178f4105ec4cf94b833fc9c3bd4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
11 years
Change in ovirt-engine[master]: engine: Add checkstyle rule EqualsHashCode
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine: Add checkstyle rule EqualsHashCode
......................................................................
engine: Add checkstyle rule EqualsHashCode
Checks that classes that override equals() also override hashCode().
http://checkstyle.sourceforge.net/config_coding.html
Change-Id: Id7f270aa850529e1894fe3fd6198930b1844402b
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f270aa850529e1894fe3fd6198930b1844402b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: use getVm() or getTemplate instead of DAO access
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: use getVm() or getTemplate instead of DAO access
......................................................................
core: use getVm() or getTemplate instead of DAO access
use the internal caching of entities for the enclosing command
and its descendants.
Change-Id: Ia97195939c010b31ba26dcad4cc7347c3c25185f
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22449
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia97195939c010b31ba26dcad4cc7347c3c25185f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine, uicompat - supress several findbugs warnings.
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: engine, uicompat - supress several findbugs warnings.
......................................................................
engine, uicompat - supress several findbugs warnings.
Those warnings are false alarm, hence should be excluded from analysis.
Change-Id: I08ef8c99afaa0a1cb66b3d8e5ca3e19e0ba8f78d
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/compat/exclude-filters.xml
M frontend/webadmin/modules/uicompat/exclude-filters.xml
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08ef8c99afaa0a1cb66b3d8e5ca3e19e0ba8f78d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Declare a multiple runner for PersistentSetupNetworks
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Declare a multiple runner for PersistentSetupNetworks
......................................................................
engine: Declare a multiple runner for PersistentSetupNetworks
Executing a multiple PersistentSetupNetworks should be
invoked in a separate thread per command, therefore
a dedicated multiple action runner is set for the
PersistentSetupNetworks.
Change-Id: I92b4c7a31adbe2d7384a8857d2deba2ad0809d63
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22052
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92b4c7a31adbe2d7384a8857d2deba2ad0809d63
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Introduce PersistentSetupNetworksCommand
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Introduce PersistentSetupNetworksCommand
......................................................................
engine: Introduce PersistentSetupNetworksCommand
The new command combines a sequence of 2 commands:
1. SetupNetworksCommand
and upon successful execution:
2. CommitNetworkChangesCommand
The command will be used internally only, when
a network changes to multiple hosts are required,
and the changes should be persisted.
Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: Cleanup VdsActionParameters
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Cleanup VdsActionParameters
......................................................................
core: Cleanup VdsActionParameters
Adjust visibility of host id and use proper naming
convention.
Change-Id: I2a2bc822842d05c6fc7a16902e46f4eccf143e9c
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsActionParameters.java
1 file changed, 14 insertions(+), 16 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22505
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a2bc822842d05c6fc7a16902e46f4eccf143e9c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years