Change in ovirt-engine[ovirt-engine-3.3]: packaging: Build pyc/pyo files
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: Build pyc/pyo files
......................................................................
packaging: Build pyc/pyo files
Add to built packages .pyc and .pyo files.
This was done so far by rpmbuild if the package redhat-rpm-config was
installed. Do this now directly by make.
Bug-Url: https://bugzilla.redhat.com/1043397
Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors
......................................................................
frontend: ignore in findbugs EventArgs unconfirmed cast errors
Ignore in findbugs errors related to casting EventArgs.
Fix existing exclude filters that stopped working due to
refactoring introduced in some recent patches
that caused the order and the number
of anonymous classes that contained findbugs warnings to change.
The casting is safe in this case, and a future refactoring
will make findbug warning resolved in any case.(RFE #1034844)
Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22409
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: backend: Avoid IsoPrefix command when no iso attached
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: backend: Avoid IsoPrefix command when no iso attached
......................................................................
backend: Avoid IsoPrefix command when no iso attached
Added check to ImagesHandler.cdPathWindowsToLinux to immediately return
when passed empty string and avoid running the IsoPrefixVSDCommand to
the same end result.
Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed buggy profiles in edit network dialog
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Fixed buggy profiles in edit network dialog
......................................................................
webadmin: Fixed buggy profiles in edit network dialog
A recent careless bug fix introduced a couple of bugs to the profiles
section of the edit network dialog, e.g. an attempt to create profiles
is made every time a network is updated and it is impossible to
approve the dialog when the list of profiles is empty. Hopefully this
fixed everything.
Change-Id: I20ed93c4b0a02118ce9732ce7db3c446b8a07803
Bug-Url: https://bugzilla.redhat.com/1043386
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
4 files changed, 28 insertions(+), 29 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20ed93c4b0a02118ce9732ce7db3c446b8a07803
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: packaging: bin: die as expected if java home is not found
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: bin: die as expected if java home is not found
......................................................................
packaging: bin: die as expected if java home is not found
export always return success, so set in two phases.
Change-Id: I2546c30f7e104a7538e0f7b267830f730d35c8d3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/bin/engine-prolog.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2546c30f7e104a7538e0f7b267830f730d35c8d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: libvirtd: start needed services
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: libvirtd: start needed services
......................................................................
libvirtd: start needed services
Start services needed by libvirtd on systems where
service dependencies are not supported.
Change-Id: Ia380cc4978966d79c6a01bf66b595cdac33f408f
Bug-Url: https://bugzilla.redhat.com/1035484
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/libvirt/configureqemu.py
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
2 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia380cc4978966d79c6a01bf66b595cdac33f408f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-hosted-engine-setup[master]: libvirtd: start needed services
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: libvirtd: start needed services
......................................................................
libvirtd: start needed services
Start services needed by libvirtd on systems where
service dependencies are not supported.
Change-Id: Ia380cc4978966d79c6a01bf66b595cdac33f408f
Bug-Url: https://bugzilla.redhat.com/1035484
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/libvirt/configureqemu.py
M src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
2 files changed, 17 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia380cc4978966d79c6a01bf66b595cdac33f408f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov(a)gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: uicompat: delete unused class Dispatcher
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: uicompat: delete unused class Dispatcher
......................................................................
uicompat: delete unused class Dispatcher
Change-Id: I6239808a83e50e14d0320dd554d727c0cef567f9
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Dispatcher.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6239808a83e50e14d0320dd554d727c0cef567f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: frontend: Add secure-channels to .vv file
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: frontend: Add secure-channels to .vv file
......................................................................
frontend: Add secure-channels to .vv file
This patch adds secure-channels line to SPICE .vv descriptor.
Change-Id: Ie3868ed99c915e0444c94f502075bbe1e8b05339
Bug-Url: https://bugzilla.redhat.com/1043398
Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Frank Kobzik: Verified
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22368
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3868ed99c915e0444c94f502075bbe1e8b05339
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: core: more accurate scores for ED weight module
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: more accurate scores for ED weight module
......................................................................
core: more accurate scores for ED weight module
Even Distribution (ED) weight module inner calculation score
is a real number, and we expose it as an integer by rounding it
up.
Currently we round it up (Math.ceil), but to be more accurate we should round
it to nearest integer (Math.round).
To avoid 0 adding 1 to the score.
Change-Id: Ib668cf266629eb4e0f2c1cbd5ac893dc7deac19c
Bug-Url: https://bugzilla.redhat.com/1040460
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib668cf266629eb4e0f2c1cbd5ac893dc7deac19c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years