December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix NPE on failure to run stateless vm
by rgolan＠redhat.com 15 Dec '13

15 Dec '13

Roy Golan has submitted this change and it was merged. Change subject: core: fix NPE on failure to run stateless vm ...................................................................... core: fix NPE on failure to run stateless vm Running VM in stateless mode is composed of two parts: the stateless snapshot creation and then running the VM. In the second part we invoke RunVmCommand and ask it to end the operation's job when it is done. The problem was that RunVmCommand didn't get the operation's job, so when it tried to end the job, NPE was thrown and the job's tasks remained unfinished. This problem is solved by passing the operation's job to the inner RunVmCommand. Change-Id: I922b0cfaf9a50de35ec9c2ca6195d5326600ce5a Bug-Url: https://bugzilla.redhat.com/1039507 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Roy Golan: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/22390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I922b0cfaf9a50de35ec9c2ca6195d5326600ce5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3]: packging: Pass full log path to database schema creation script
by ydary＠redhat.com 15 Dec '13

15 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packging: Pass full log path to database schema creation script ...................................................................... packging: Pass full log path to database schema creation script Don't pass a relative path to database schema creation script, as it will create the log file under current directory. Change-Id: Iceb095d05473f41da4fa56eadc6e60da14056ac2 Bug-Url: https://bugzilla.redhat.com/1040026 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceb095d05473f41da4fa56eadc6e60da14056ac2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: KeyValueWidget to inherit AddRemoveRowWidget
by lvernia＠redhat.com 15 Dec '13

15 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: KeyValueWidget to inherit AddRemoveRowWidget ...................................................................... webadmin: KeyValueWidget to inherit AddRemoveRowWidget Refactored KeyValueWidget to inherit from AddRemoveRowWidget, in order to promote a uniform look and feel throughout the project as well as code reuse. Change-Id: I5c633210139c501e6709e3c68c1d70af5bdfe111 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/scheduling/NewClusterPolicyModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/IModifyLines.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueLineModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/profile/VnicProfilePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyPopupView.java 24 files changed, 195 insertions(+), 397 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c633210139c501e6709e3c68c1d70af5bdfe111 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactoring in VnicProfilesEditor
by lvernia＠redhat.com 15 Dec '13

15 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Refactoring in VnicProfilesEditor ...................................................................... webadmin: Refactoring in VnicProfilesEditor Replaced the non-standard edit() method with the standard one, that had been previously marked as deprecated. This required introducing a new class NetworkProfilesModel, but it's better practice (now developers don't have to be trusted to use the "correct" edit() method). Also took the chance to parameterize all the related ListModel instances, as the class is now generic. Change-Id: Id8b101f869d90d5e10636ac70e653376dc29f72d Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NetworkProfilesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 9 files changed, 71 insertions(+), 110 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8b101f869d90d5e10636ac70e653376dc29f72d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Refactoring in ProfilesInstanceTypeEditor
by lvernia＠redhat.com 15 Dec '13

15 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Refactoring in ProfilesInstanceTypeEditor ...................................................................... webadmin: Refactoring in ProfilesInstanceTypeEditor Replaced the non-standard edit() method with the standard one, that had been previously marked as deprecated. This required introducing a new class VnicInstancesModel, but it's better practice (now developers don't have to be trusted to use the "correct" edit() method). Also took the chance to parameterize all the related ListModel instances, as the class is now generic. Change-Id: I5951932037850a56f861bfced9199640153db785 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VnicInstancesModel.java 5 files changed, 24 insertions(+), 52 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5951932037850a56f861bfced9199640153db785 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Fixing PM options caching
by iheim＠redhat.com 15 Dec '13

15 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Fixing PM options caching ...................................................................... core: Fixing PM options caching fencingOptionMapping cache map was declared as static as a result if it was initialized once with the 'general' version the values of this version was used for all instances no matter which version is given to the constructor. This eliminates new agents added in later versions to function and display supported port/slot/secure fields correctly Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1040875 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03e4a98919105bbb0d7ef382234b8810db044215 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Small improvements to AddRemoveRowWidget
by lvernia＠redhat.com 15 Dec '13

15 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Small improvements to AddRemoveRowWidget ...................................................................... webadmin: Small improvements to AddRemoveRowWidget Made the following changes in AddRemoveRowWidget: * Added an event listener to the edited model's items changed event, which seems to be logic common to any usage of the widget. * Removed the setItems() call from the flush() method, which turned out to be a bad idea for various reasons, and instead just update the current items of the model. * Changed onAdd() and onRemove() to commit changes to the model by default, which seems to be useful. * Changed onAdd() and onRemove() to only be invoked when triggered by a button press (e.g. not during initialization of the widget), the semantics of which would be much more intuitive to anyone who might inherit from this widget. Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditProfileBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewProfileBehavior.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java 13 files changed, 184 insertions(+), 189 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: set address explicitly for VirtIO-SCSI devices
by iheim＠redhat.com 15 Dec '13

15 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: set address explicitly for VirtIO-SCSI devices ...................................................................... core: set address explicitly for VirtIO-SCSI devices Upon VM start, libvirt uses automatic address allocation for defining addresses for each device (when not defined addresses explicitly). As part of the automatic allocation, libvirt limits maximum units (disks) for each controller [6 (narrow bus) / 15 (wide bus)]. In order to bypass this limitation, engine should set each device address explicitly while keeping unit value (disk's index in VirtIO-SCSI controller) unique and consecutive in the VM devices. More details and full discussion: https://www.redhat.com/archives/libvir-list/2013-November/msg01113.html Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765 Bug-Url: https://bugzilla.redhat.com/1035453 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 5 files changed, 95 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Decrement pending memory/cpus after finished migration
by iheim＠redhat.com 15 Dec '13

15 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Decrement pending memory/cpus after finished migration ...................................................................... core: Decrement pending memory/cpus after finished migration The engine leaved pending memory in DB after successfull and some unsuccessfull migrations and this caused hosts to reject more VMs after some time. Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Reviewed-on: http://gerrit.ovirt.org/#/c/22233/ Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039900 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 3 files changed, 16 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: set address explicitly for VirtIO-SCSI devices
by derez＠redhat.com 15 Dec '13

15 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: core: set address explicitly for VirtIO-SCSI devices ...................................................................... core: set address explicitly for VirtIO-SCSI devices Upon VM start, libvirt uses automatic address allocation for defining addresses for each device (when not defined addresses explicitly). As part of the automatic allocation, libvirt limits maximum units (disks) for each controller [6 (narrow bus) / 15 (wide bus)]. In order to bypass this limitation, engine should set each device address explicitly while keeping unit value (disk's index in VirtIO-SCSI controller) unique and consecutive in the VM devices. More details and full discussion: https://www.redhat.com/archives/libvir-list/2013-November/msg01113.html Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765 Bug-Url: https://bugzilla.redhat.com/1035453 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 5 files changed, 95 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee79ff3f72b8018d0c26b37503f480643a845765 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0