December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: order of operations when deactivating the last master ...
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: order of operations when deactivating the last master domain ...................................................................... core: order of operations when deactivating the last master domain When deactivating the master domain and there's no other domain to migrate the master to, the hsms can be disconnected from the pool only after the spm was stopped to avoid having them being disconnected from the pool in case that we failed to stop the spm which will cause them to move to non op as they won't have repoStats on the domains. Change-Id: I9d9dcf86a7a1f49175435807816a208d4506a7b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=921666 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 21 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d9dcf86a7a1f49175435807816a208d4506a7b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm DevicePropertiesUtils.getSupportedDeviceTypes
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm DevicePropertiesUtils.getSupportedDeviceTypes ...................................................................... core: rm DevicePropertiesUtils.getSupportedDeviceTypes Removed unused methods. Change-Id: I243addf42aab68ae5e3275e2c0a9eb4ced3da518 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I243addf42aab68ae5e3275e2c0a9eb4ced3da518 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused ObjectIdentityChecker methods
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused ObjectIdentityChecker methods ...................................................................... core: rm unused ObjectIdentityChecker methods Change-Id: I3babf37b38921d06ec11c3a7a838edf246ed3f59 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 1 file changed, 0 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3babf37b38921d06ec11c3a7a838edf246ed3f59 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused CLIParser.getNextParam()
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused CLIParser.getNextParam() ...................................................................... core: rm unused CLIParser.getNextParam() Change-Id: I839f6afdb333fe23db2478687557b5c116e90292 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CLIParser.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I839f6afdb333fe23db2478687557b5c116e90292 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused VmDeviceCommonUtils.CDROM_IMAGE_ID
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused VmDeviceCommonUtils.CDROM_IMAGE_ID ...................................................................... core: rm unused VmDeviceCommonUtils.CDROM_IMAGE_ID Change-Id: I3077f3edf6e7bf1268f4543fa66ce3631d89f57b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3077f3edf6e7bf1268f4543fa66ce3631d89f57b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused Tags methods
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused Tags methods ...................................................................... core: Remove unused Tags methods Change-Id: I8665db83c777876522612e595d7823b13f4b9aac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Tags.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8665db83c777876522612e595d7823b13f4b9aac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Make Event immutable
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make Event immutable ...................................................................... core: Make Event immutable Removed unused setters from the Event class. Once an Event is created, it makes no sense to modify it, and having the class immutable is a good defensive practice for this kind of data objects. Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/Event.java 1 file changed, 0 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92eaad099f975d279fb1ab6a9c70112e7ea194d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VmTemplateHandler.log modifiers
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmTemplateHandler.log modifiers ...................................................................... core: VmTemplateHandler.log modifiers Made the log final, as per the proper Java conventions. Change-Id: Ifb1868d3444ec5ff43681a1c45e95b71ab00171a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb1868d3444ec5ff43681a1c45e95b71ab00171a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm useless ObjectIdentityChecker constructor
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm useless ObjectIdentityChecker constructor ...................................................................... core: rm useless ObjectIdentityChecker constructor Since the previous patch removed the use of the status class, the constructor accepting it has become useless, and could safely be removed. Change-Id: Iedea2389028858ff474db032adc4ed8a5e7677db Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 2 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedea2389028858ff474db032adc4ed8a5e7677db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm ObjectIdentityChecker.statusTypes member
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm ObjectIdentityChecker.statusTypes member ...................................................................... core: rm ObjectIdentityChecker.statusTypes member This map is only updated, but is never queried. Therefore, it's just a waste of memory, and should be removed. Change-Id: I5460365ba54366697fbe72fc1b0066b8abea2d9a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5460365ba54366697fbe72fc1b0066b8abea2d9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0