December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rename VmTemplateHandler methods
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename VmTemplateHandler methods ...................................................................... core: rename VmTemplateHandler methods Renamed methods to adhere to proper Java naming conventions. Change-Id: I8bbce4a8491ddbec3aec90655e7d7f2f3ab013d3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmTemplatesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTemplatesRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByImageGuidQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmTemplateHandlerTest.java 19 files changed, 28 insertions(+), 28 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bbce4a8491ddbec3aec90655e7d7f2f3ab013d3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Fix --vm-status when maintenance mode has never been enabled
by sbonazzo＠redhat.com 12 Dec '13

12 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Fix --vm-status when maintenance mode has never been enabled ...................................................................... Fix --vm-status when maintenance mode has never been enabled Change-Id: I2b1a4f91e826a95d22a4e8b93a044aec2baf9003 Bug-Url: https://bugzilla.redhat.com/1041203 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M src/ovirt_hosted_engine_setup/vm_status.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/22340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b1a4f91e826a95d22a4e8b93a044aec2baf9003 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix FB on AddExistingFileStorageDomain
by amureini＠redhat.com 12 Dec '13

12 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix FB on AddExistingFileStorageDomain ...................................................................... core: Fix FB on AddExistingFileStorageDomain This patch reverts 5ccea20c205457f70cbd480f80455f600b386836 and offers a proper fix for the (bogus) NP_NULL_PARAM_DEREF error in AddExistingFileStorageDomainCommand. The domainFromIrs variable can NEVER be null, hence it's meaningless to protect against it. Change-Id: Id8c5a11ef872cac6aeebfa18bf28757fb4a8b26c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 11 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8c5a11ef872cac6aeebfa18bf28757fb4a8b26c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Decrement pending memory/cpus after finished migration
by gchaplik＠redhat.com 12 Dec '13

12 Dec '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Decrement pending memory/cpus after finished migration ...................................................................... core: Decrement pending memory/cpus after finished migration The engine leaved pending memory in DB after successfull and some unsuccessfull migrations and this caused hosts to reject more VMs after some time. Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039900 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 3 files changed, 16 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: removed beta from version due to rc release
by ydary＠redhat.com 12 Dec '13

12 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: removed beta from version due to rc release ...................................................................... packaging: removed beta from version due to rc release Change-Id: I11c3500546e3b787b18e7666685d40c87be547bc Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11c3500546e3b787b18e7666685d40c87be547bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: removed beta from version due to rc release
by ydary＠redhat.com 12 Dec '13

12 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: removed beta from version due to rc release ...................................................................... packaging: removed beta from version due to rc release Change-Id: I7ae8f3c8e7754a15e67db3b095aa03f1ecce29cb Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ae8f3c8e7754a15e67db3b095aa03f1ecce29cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921)
by iheim＠redhat.com 12 Dec '13

12 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) ...................................................................... restapi: Fix Duplicate Name In Cloud-Init Schema (#1039921) Duplicate name 'network' in schema violated a name-uniqneness assumption of python-sdk code generation. Bug-Url: http://bugzilla.redhat.com/1039921 Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CloudInitValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 30 insertions(+), 28 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If251b2ee2dec5660cce04d4e1332f91a33c7485b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: restapi: fix incorrectly implemented cloud-init metadata #10...
by iheim＠redhat.com 12 Dec '13

12 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: fix incorrectly implemented cloud-init metadata #1040513 ...................................................................... restapi: fix incorrectly implemented cloud-init metadata #1040513 Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Signed-off-by: Michael pasternak <mpastern(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1040513 --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 11 insertions(+), 13 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44111ab1c8d2c8b449bc1ac6924ba30dd21fcbca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3]: sos: postgresql: always use db host
by sbonazzo＠redhat.com 12 Dec '13

12 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: postgresql: always use db host ...................................................................... sos: postgresql: always use db host Previously it was possible to access the database through unix socket. Now the access for user engine is limited to tcp connection. Changed the call to sosreport for passing db host to postgresql plugin. Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Bug-Url: https://bugzilla.redhat.com/1039747 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 10 insertions(+), 38 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix possible NPE
by mlipchuk＠redhat.com 12 Dec '13

12 Dec '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: fix possible NPE ...................................................................... core: fix possible NPE Fix a possible NPE in AddExistingFileStorageDomain. Found by findbugs. Change-Id: I25591056cd6e03551d2d410de8e95cfb72c2c8d2 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25591056cd6e03551d2d410de8e95cfb72c2c8d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0