December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: rename member in VmTemplateHandler to uppercase
by oourfali＠redhat.com 11 Dec '13

11 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: rename member in VmTemplateHandler to uppercase ...................................................................... core: rename member in VmTemplateHandler to uppercase Fix a findbugs warning Change-Id: I7a4350959ddbef3c973f2f80366c92feb623de79 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 13 files changed, 24 insertions(+), 25 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4350959ddbef3c973f2f80366c92feb623de79 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.2]: engine: Fix slow API query for list of templates in a Datace...
by iheim＠redhat.com 11 Dec '13

11 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Fix slow API query for list of templates in a Datacenter ...................................................................... engine: Fix slow API query for list of templates in a Datacenter This patch improves the performance of SearcQuery for templates by Datacenter. It improves performance by about a factor of 5. Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Bug-Url: https://bugzilla.redhat.com/1029106 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/22246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.2 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: sos: postgresql: always use db host
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: sos: postgresql: always use db host ...................................................................... sos: postgresql: always use db host Previously it was possible to access the database through unix socket. Now the access for user engine is limited to tcp connection. Changed the call to sosreport for passing db host to postgresql plugin. Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Bug-Url: https://bugzilla.redhat.com/1039747 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 10 insertions(+), 38 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb4ac5e03e3b6f1f6d7b499c969bdeb5ed9026cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Derrick Ornelas <dornelas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Allow user to reboot VM from within the installer
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Allow user to reboot VM from within the installer ...................................................................... Allow user to reboot VM from within the installer During setup, the engine VM is created twice: once to install the base operating system and once to install the engine. During either of these phases it may sometimes be necessary to reboot the VM additional times (ie. to correct PXE boot configuration or restart the installer). Provide an interactive means of rebooting the VM without forcing the user to resort to external invocations of hosted-engine --vm-start, etc. Signed-off-by: Adam Litke <alitke(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1034788 Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93 --- M src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/engine/health.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 3 files changed, 71 insertions(+), 79 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Adam Litke: Verified -- To view, visit http://gerrit.ovirt.org/22203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I176eb58b6b5400df7f98a4fa3e4ae55c2959fb93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: Move VM operations into a mixin for reusability
by sbonazzo＠redhat.com 11 Dec '13

11 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: Move VM operations into a mixin for reusability ...................................................................... Move VM operations into a mixin for reusability The plugin in runvm.py has lots of useful logic for manipulating the hosted engine VM. This logic can be very useful to other plugins (eg. health.py) that may want to offer the user assistance with managing the VM. This patch moves the VM logic into a separate class that can be mixed in with any other plugin which may want the functionality. Signed-off-by: Adam Litke <alitke(a)redhat.com> Related-To: https://bugzilla.redhat.com/1034788 Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef --- M src/ovirt_hosted_engine_setup/Makefile.am A src/ovirt_hosted_engine_setup/mixins.py M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py 3 files changed, 218 insertions(+), 185 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Adam Litke: Verified -- To view, visit http://gerrit.ovirt.org/22202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I811f6712cb5c9324c6a3acca0bfc5bc9195b25ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase ...................................................................... gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase filling the task parameter after the null check for task and task ID. Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Log when gluster task started from CLI
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Log when gluster task started from CLI ...................................................................... engine: Log when gluster task started from CLI Add event log messages when a gluster task - rebalance or remove brick - is started from CLI Change-Id: I381ecc028ff5dd36202916953f5c3c623b43e526 Bug-Url: https://bugzilla.redhat.com/1015444 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/03_04_0200_gluster_async_tasks_fromcli_event_map.sql 5 files changed, 56 insertions(+), 20 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/22078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I381ecc028ff5dd36202916953f5c3c623b43e526 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: code: change data members to start with a lowercase letter
by oourfali＠redhat.com 11 Dec '13

11 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: code: change data members to start with a lowercase letter ...................................................................... code: change data members to start with a lowercase letter Change-Id: Ib28d10aead22f2753ab5b98b9abc4e71d860f087 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib28d10aead22f2753ab5b98b9abc4e71d860f087 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix typo in Add-Bricks popup
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix typo in Add-Bricks popup ...................................................................... webadmin: fix typo in Add-Bricks popup "create" -> "created". Change-Id: I36c3022a6d6189a751f0c83d1c0c1159d8a25923 Bug-Url: https://bugzilla.redhat.com/886478 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c3022a6d6189a751f0c83d1c0c1159d8a25923 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: disable rebalance action when its being started
by kmayilsa＠redhat.com 11 Dec '13

11 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: disable rebalance action when its being started ...................................................................... webadmin: disable rebalance action when its being started Once the user clicks on 'Rebalance' action in volumes tab, glusterfs takes few seconds to start the rebalance operation. 'Rebalance' action will be disabled immediately without waiting for the result from glusterfs. Change-Id: I961955f15310e5d0566019556e7f7e601e8ec957 Bug-Url: https://bugzilla.redhat.com/1021814 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I961955f15310e5d0566019556e7f7e601e8ec957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0