Change in ovirt-engine[master]: engine: Improve log message on failure to connect to storage...
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Improve log message on failure to connect to storage server
......................................................................
engine: Improve log message on failure to connect to storage server
>From now on log message will contain name and id of the relevant
storage domain a host failed to connect to.
Change-Id: Ife941b59766e699a046122abc74aaede366a2015
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife941b59766e699a046122abc74aaede366a2015
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: packaging: spec: force update of openjdk which leaks memory
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: force update of openjdk which leaks memory
......................................................................
packaging: spec: force update of openjdk which leaks memory
this will only force upgrade if existing openjdk install is faulty
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028966
Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22261
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbc098ec79cc95783f775f856c4f4563c3f61a3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6
......................................................................
build: ovirt-hosted-engine-setup-1.0.0-0.11.beta6
Change-Id: I6e529edb7b5219f278e05515ab982b288a89a916
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-setup.spec.in
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22254
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e529edb7b5219f278e05515ab982b288a89a916
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1
by gpadgett@redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1
......................................................................
build: ovirt-hosted-engine-ha-0.1.0-0.9.beta1
Change-Id: I445ca3ece96a9e7588e7114b599058ddcc9223bf
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified
Greg Padgett: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I445ca3ece96a9e7588e7114b599058ddcc9223bf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-hosted-engine-ha[master]: agent: Migrate engine VM only for local maintenance
by gpadgett@redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: agent: Migrate engine VM only for local maintenance
......................................................................
agent: Migrate engine VM only for local maintenance
Migrate the engine VM only when local maintenance is enabled and not
for the host score differentials. This makes migration occur only when
it is likely to succeed.
Change-Id: I8fbf2e9c7eec0ca7787e71c6c328f95b243840c9
Bug-Url: https://bugzilla.redhat.com/1039614
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
1 file changed, 10 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Greg Padgett: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fbf2e9c7eec0ca7787e71c6c328f95b243840c9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: [Fix] Check PCI limits when adding NICs
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: [Fix] Check PCI limits when adding NICs
......................................................................
core: [Fix] Check PCI limits when adding NICs
The AddVmInterfaceCommand didn't account for all the existing NICs
while passing the "interfaces" list to the checkPciAndIdeLimits
procedure, so a limitless number of NICs could be created.
This change fix this behaviour (like in the UpdateVmInterfaceCommand).
Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22215
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8594848b576dd5543d0fa77b5471b5dadc6ac4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: engine: Fix slow API query for list of templates in a Datace...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Fix slow API query for list of templates in a Datacenter
......................................................................
engine: Fix slow API query for list of templates in a Datacenter
This patch improves the performance of SearcQuery for templates by Datacenter.
It improves performance by about a factor of 5.
Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845
Bug-Url: https://bugzilla.redhat.com/1029106
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13460ae1aa3d7cb2816ed53b5ca7da64f15b8845
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors
......................................................................
frontend: ignore in findbugs EventArgs unconfirmed cast errors
Ignore in findbugs errors related to casting EventArgs.
The casting is safe in this case, and a future refactoring
will make findbug warning resolved in any case.(RFE #1034844)
This is patch #9 following
http://gerrit.ovirt.org/#/c/22089/
Change-Id: Id2fdea041103c13530acd16c812f090942c05ce4
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/uicommonweb/exclude-filters.xml
2 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2fdea041103c13530acd16c812f090942c05ce4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: broad catch in LdapTemplateWrapperFactory
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: broad catch in LdapTemplateWrapperFactory
......................................................................
core: broad catch in LdapTemplateWrapperFactory
Replaced a catch (Exception e) clause with a series of piped catches
that cover all the exceptions that can be thrown in this block.
Besides being a good defensive practice and cleaning up the code, this
patch solves the REC_CATCH_EXCEPTION FindBugs warning for this block.
Change-Id: Iea983982865d740d2ca0a852454931fb0de0ed8c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LDAPTemplateWrapperFactory.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea983982865d740d2ca0a852454931fb0de0ed8c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: Reduce array visibility of ContextMappers
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Reduce array visibility of ContextMappers
......................................................................
core: Reduce array visibility of ContextMappers
Reduced the visibility of array "constants" to solve MS_PKGPROTECT
FindBugs warnings in these classes.
Change-Id: Iabdebea8667b9e7e6137cdf8d024f837d4a6b0d2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPARootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSUserContextMapper.java
15 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabdebea8667b9e7e6137cdf8d024f837d4a6b0d2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month