Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: Allow editing the VM mac address
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Allow editing the VM mac address
......................................................................
Allow editing the VM mac address
In order to give the user control of IP address assignment in DHCP
environments it is important to allow the MAC address to be specified
explicitly. Make MAC address a customizable parameter while still
suggesting a default value for users who may not care.
Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1034706
---
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am
M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
A src/plugins/ovirt-hosted-engine-setup/vm/mac.py
6 files changed, 131 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core, webadmin: add isVm and isTemplate methods to VmEntityType
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType
......................................................................
core,webadmin: add isVm and isTemplate methods to VmEntityType
Since now there are more types for VmEntityType (like instance type),
code that check for these types need to be updated.
Since the new entities are just types of templates,
and looking fwd we might add more like these,
looks like caller only want to know if this is a vm or a template.
So I added methods for easier reference,
and changed all references to specific types to the right method.
Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmEntityType.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
5 files changed, 44 insertions(+), 26 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-hosted-engine-setup[master]: Allow editing the VM mac address
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Allow editing the VM mac address
......................................................................
Allow editing the VM mac address
In order to give the user control of IP address assignment in DHCP
environments it is important to allow the MAC address to be specified
explicitly. Make MAC address a customizable parameter while still
suggesting a default value for users who may not care.
Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=1034706
---
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/util.py
M src/plugins/ovirt-hosted-engine-setup/vm/Makefile.am
M src/plugins/ovirt-hosted-engine-setup/vm/__init__.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
A src/plugins/ovirt-hosted-engine-setup/vm/mac.py
6 files changed, 131 insertions(+), 4 deletions(-)
Approvals:
Adam Litke: Verified
Sandro Bonazzola: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie75af322fc403809e0b044eb13561e6d16e1c4d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3.2]: packaging: setup: aio: fix ssh issues
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: aio: fix ssh issues
......................................................................
packaging: setup: aio: fix ssh issues
1. If ~root/.ssh is missing and selinux enabled, it will be created
without proper selinux attributes, causing ssh to fail.
2. If ~root/.ssh is missing it is created using mode 0755 and not 0700.
3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail
early.
Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209
Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
3 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22120
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.2
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>
11 years, 1 month
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: hosted-engine: Update usage info and handle sub-command help
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: hosted-engine: Update usage info and handle sub-command help
......................................................................
hosted-engine: Update usage info and handle sub-command help
The hosted-engine command uses sub-commands and the current arg parsing
leads to some odd and confusing side effects. Update the usage message
to make the invocation a bit clearer. Handle sub-command specific help
(<command> --help) explicitly in each sub-command function.
Signed-off-by: Adam Litke <alitke(a)redhat.com>
Change-Id: I7323022994b0225b0b319d0b402c0fd755b8da78
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038626
---
M man/hosted-engine.8
M src/bin/hosted-engine.in
M src/plugins/ovirt-hosted-engine-setup/vm/runvm.py
3 files changed, 312 insertions(+), 178 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7323022994b0225b0b319d0b402c0fd755b8da78
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: aio: fix ssh issues
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: aio: fix ssh issues
......................................................................
packaging: setup: aio: fix ssh issues
1. If ~root/.ssh is missing and selinux enabled, it will be created
without proper selinux attributes, causing ssh to fail.
2. If ~root/.ssh is missing it is created using mode 0755 and not 0700.
3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail
early.
Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209
Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
3 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22119
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>
11 years, 1 month
Change in ovirt-engine[master]: packaging: setup: aio: fix ssh issues
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: aio: fix ssh issues
......................................................................
packaging: setup: aio: fix ssh issues
1. If ~root/.ssh is missing and selinux enabled, it will be created
without proper selinux attributes, causing ssh to fail.
2. If ~root/.ssh is missing it is created using mode 0755 and not 0700.
3. Validate /etc/ssh/sshd_config, if PermitRootLogin is no then fail
early.
Buf-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036209
Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/sshd.py
M packaging/setup/plugins/ovirt-engine-setup/all-in-one/vdsm.py
3 files changed, 57 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21874
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe55ccf4535792fed69912553d86a53dec3764b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: r herrold <herrold(a)owlriver.com>
11 years, 1 month
Change in ovirt-engine[master]: frontend: Refactored ClusterModel to use generics
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: frontend: Refactored ClusterModel to use generics
......................................................................
frontend: Refactored ClusterModel to use generics
Change-Id: Ib639a20cc718f7e8479627772002507cef04ad53
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.ui.xml
9 files changed, 313 insertions(+), 321 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib639a20cc718f7e8479627772002507cef04ad53
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: packaging: build: fix parallel make issue
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: build: fix parallel make issue
......................................................................
packaging: build: fix parallel make issue
Change-Id: I91962ffc5396433cf670174cd757617b4b405c63
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22111
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91962ffc5396433cf670174cd757617b4b405c63
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: engine: Set brick port and pid when returned
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Set brick port and pid when returned
......................................................................
engine: Set brick port and pid when returned
When gluster process is restarted, the gluster
CLI returns the brick port as NA. This causes
the VDS xml return handler to fail as the brick
port is expected as an integer value.
Added code to set the int values only if
returned correctly.
If brick port is N/A then brick's status should
be set offline.
Change-Id: I544b0aa4705b4bcde7638f15b5b235ba10deb3b1
Bug-Url: https://bugzilla.redhat.com/1036039
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/21908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I544b0aa4705b4bcde7638f15b5b235ba10deb3b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month