December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Modify UpdateNetworkCommand to non-transactive
by masayag＠redhat.com 08 Dec '13

08 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify UpdateNetworkCommand to non-transactive ...................................................................... engine: Modify UpdateNetworkCommand to non-transactive As a preparation for a multiple network configuration on hosts action (Edit Provision Networks feature), there is a need to modify the UpdateNetworkCommand to be non-transactive, and to scope the transaction scope to the relevant portions only. Change-Id: I6fe59c2652334b80afcc51a47916f3b7f23b8950 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 19 insertions(+), 7 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fe59c2652334b80afcc51a47916f3b7f23b8950 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Use VdsDao for fetching hosts in NetworkClusterHelper
by masayag＠redhat.com 08 Dec '13

08 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Use VdsDao for fetching hosts in NetworkClusterHelper ...................................................................... engine: Use VdsDao for fetching hosts in NetworkClusterHelper Instead of using the search engine for fetching host internally, a direct use of the VdsDao is done. In addition, skip DB call for the hosts if the network is not required. Change-Id: Icf6574700974b800d96627da9439d7793b7d31b2 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java 1 file changed, 3 insertions(+), 13 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf6574700974b800d96627da9439d7793b7d31b2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Cleanup of MultipleActionsRunner
by masayag＠redhat.com 08 Dec '13

08 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Cleanup of MultipleActionsRunner ...................................................................... engine: Cleanup of MultipleActionsRunner Change-Id: Ia679a00f961b0d2e88d0815df374d7374bf4e7ab Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia679a00f961b0d2e88d0815df374d7374bf4e7ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename member Definition to lowercase in ProvideTickEvent
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename member Definition to lowercase in ProvideTickEvent ...................................................................... ui: rename member Definition to lowercase in ProvideTickEvent Change-Id: I73e1cbc9565894effc4a29c5673a3a49a9f80706 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/TimerImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ProvideTickEvent.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73e1cbc9565894effc4a29c5673a3a49a9f80706 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: rename method to lowercase in ModelListTreeViewModel
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: rename method to lowercase in ModelListTreeViewModel ...................................................................... webadmin: rename method to lowercase in ModelListTreeViewModel rename UpdateSelection method to updateSelection. Change-Id: Ie12e67d85373bd34e323dc7f22e50d077e3ff44d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/ModelListTreeViewModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie12e67d85373bd34e323dc7f22e50d077e3ff44d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uicompat: rename Enlistment.Done to done
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: uicompat: rename Enlistment.Done to done ...................................................................... uicompat: rename Enlistment.Done to done Change-Id: Ic58b872abbcbdf19ca45e54f4fb496785db40e89 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enlistment.java 5 files changed, 15 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic58b872abbcbdf19ca45e54f4fb496785db40e89 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uicompat: rename TaskContext.InvokeUIThread to start with lo...
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: uicompat: rename TaskContext.InvokeUIThread to start with lowercase ...................................................................... uicompat: rename TaskContext.InvokeUIThread to start with lowercase Change-Id: I7b4e2fe28b81f6f5b344742a28c2d486d8b4ae68 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/TaskContext.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b4e2fe28b81f6f5b344742a28c2d486d8b4ae68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uicompat: remove unused method Task.InvokeUIThread
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: uicompat: remove unused method Task.InvokeUIThread ...................................................................... uicompat: remove unused method Task.InvokeUIThread Change-Id: Ie2e8a95cd7c15df538636f3419560985b20b4be1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2e8a95cd7c15df538636f3419560985b20b4be1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uicompat: rename Task.Create to Task.create
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: uicompat: rename Task.Create to Task.create ...................................................................... uicompat: rename Task.Create to Task.create Change-Id: If181c2d6364765760593cd258cb4e7c29b164796 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If181c2d6364765760593cd258cb4e7c29b164796 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename methods to lowercase in AsyncDataProvider
by derez＠redhat.com 08 Dec '13

08 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: engine: rename methods to lowercase in AsyncDataProvider ...................................................................... engine: rename methods to lowercase in AsyncDataProvider Change-Id: Ic8ff3e56d4e828af26d397f3284eb08590ff3839 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8ff3e56d4e828af26d397f3284eb08590ff3839 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0