December 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: remove redundant code

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: remove redundant code ...................................................................... core: remove redundant code getMethod will never return null. It will either return the method, or will throw an exception. So, in this case, both the if, and the operation inside it, are redundant it will always be false so inner code will never be reached. Change-Id: I878243d9a3e205990d2a029c7443cd6d62feb0d3 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I878243d9a3e205990d2a029c7443cd6d62feb0d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: utils: write log message when file.delete fails in utils

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: utils: write log message when file.delete fails in utils ...................................................................... utils: write log message when file.delete fails in utils Change-Id: I64ecdb968f2825b5a1da3d152b1213e545fa52d1 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64ecdb968f2825b5a1da3d152b1213e545fa52d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: fix naming conventions to method and field names in bll

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: fix naming conventions to method and field names in bll ...................................................................... core: fix naming conventions to method and field names in bll Change-Id: Ife2382b63e33775bd257d4f535664925f0b91c6a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SortedMultipleActionsRunnerBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java 9 files changed, 23 insertions(+), 23 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22067 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife2382b63e33775bd257d4f535664925f0b91c6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: spec: pull ovirt-host-deploy-1.1.2

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: spec: pull ovirt-host-deploy-1.1.2 ...................................................................... packaging: spec: pull ovirt-host-deploy-1.1.2 Bug-Url: https://bugzilla.redhat.com/1032890 Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: check vds status on resume paused VM

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: check vds status on resume paused VM ...................................................................... core: check vds status on resume paused VM Checking whether the VDS that the VM is going to be resumed on is up was missing when resuming a paused VM (regression). Change-Id: Iac123f1758e5ed3dcedab335546df322fd76a0af Bug-Url: https://bugzilla.redhat.com/1035667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 2 files changed, 25 insertions(+), 21 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/18245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac123f1758e5ed3dcedab335546df322fd76a0af Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: uicompat: rename 2 members to lowercase in PreparingEnlistment

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: uicompat: rename 2 members to lowercase in PreparingEnlistment ...................................................................... uicompat: rename 2 members to lowercase in PreparingEnlistment Change-Id: I85f6c9d0d68a858ecfed8ac61081bac41d93c576 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f6c9d0d68a858ecfed8ac61081bac41d93c576 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Show correct step type for async tasks

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: Show correct step type for async tasks ...................................................................... restapi: Show correct step type for async tasks Earlier the step type details for gluster async tasks was being shown as UNKNOWN for steps like REBALANCING_VOLUME and REMOVE_BRICKS. Corrected the same in StepMapper to correctly map to valid step type. Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c Bug-Url: https://bugzilla.redhat.com/1037709 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: print proper message suggesting to run as ...

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: print proper message suggesting to run as root ...................................................................... packaging: setup: print proper message suggesting to run as root Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037451 Change-Id: I3850b5c474e7bae47f2b240c19dee690d6c9e3ef Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/setup/bin/ovirt-engine-remove M packaging/setup/bin/ovirt-engine-rename M packaging/setup/bin/ovirt-engine-setup M packaging/setup/bin/ovirt-engine-setup.env.in 5 files changed, 19 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3850b5c474e7bae47f2b240c19dee690d6c9e3ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: build: Allow repeated reinstalls

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Allow repeated reinstalls ...................................................................... build: Allow repeated reinstalls Add -f to $(LN_S) so that we may overwrite the symlink created from a previous install. This allows one to reinstall the code without first manually removing the existing symlink. Change-Id: Ia7597e6b206975ead0f0a021c5288061f2798123 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M src/bin/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7597e6b206975ead0f0a021c5288061f2798123 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: packaging: spec: pull ovirt-host-deploy-1.1.2

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: pull ovirt-host-deploy-1.1.2 ...................................................................... packaging: spec: pull ovirt-host-deploy-1.1.2 Bug-Url: https://bugzilla.redhat.com/1032890 Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2013