Change in ovirt-engine[master]: gluster: correct error message on failure to start remove brick
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: correct error message on failure to start remove brick
......................................................................
gluster: correct error message on failure to start remove brick
The variable type in error message for faliure to start remove brick
is changed from Gluster Volume to Gluster Brick(s). And action entry
for remove brick start which was missing earlier in one of the file
is updated
bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1020282
Signed-off-by: ndarshan <dnarayan(a)redhat.com>
Change-Id: I10a55829a11fc19e1a43f38f45911e7aaf91d5b8
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
3 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10a55829a11fc19e1a43f38f45911e7aaf91d5b8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: webadmin: select highest version in new cluster popup
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: select highest version in new cluster popup
......................................................................
webadmin: select highest version in new cluster popup
While creating a new cluster, select the possible highest
version depending on the selected data center.
Change-Id: I224b3458e3d4365fa12ea63831952f01e3a5b2f5
Bug-Url: https://bugzilla.redhat.com/975055
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 6 insertions(+), 10 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21940
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I224b3458e3d4365fa12ea63831952f01e3a5b2f5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: add read only admin role
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: add read only admin role
......................................................................
core: add read only admin role
Change-Id: Ia00167f08752749b1b01447c5c910e263c6301ce
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
A packaging/dbscripts/upgrade/03_04_0160_create_read_only_admin_role.sql
1 file changed, 27 insertions(+), 0 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21953
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia00167f08752749b1b01447c5c910e263c6301ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: engine: rename several methods in CommandsFactory
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: engine: rename several methods in CommandsFactory
......................................................................
engine: rename several methods in CommandsFactory
Rename methods to lowercase per Java naming standards.
Solves findbugs warnings.
Change-Id: I74412dd0c545f3806db6156964b857756e87b40d
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
4 files changed, 11 insertions(+), 11 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74412dd0c545f3806db6156964b857756e87b40d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: rename GetValue to getValue in Config class
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: rename GetValue to getValue in Config class
......................................................................
core: rename GetValue to getValue in Config class
Rename the method and fix all of its usages
Change-Id: I981dc02fd9a09f6b3483c35b07a48d9a0f49b8cc
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValueQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmCustomPropertiesQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/DevicePropertiesUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/VmPropertiesUtils.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VirtMonitoringStrategy.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVGVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
29 files changed, 40 insertions(+), 40 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I981dc02fd9a09f6b3483c35b07a48d9a0f49b8cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: Remove unused constants from DAO tests
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove unused constants from DAO tests
......................................................................
core: Remove unused constants from DAO tests
Change-Id: I9d8193c77031b78ef359d13cebcbf13b8497bd0e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbFacadeDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDynamicDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStatisticsDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmTemplateDAOTest.java
5 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d8193c77031b78ef359d13cebcbf13b8497bd0e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: Remove BaseDAOTestCase.setUpDatabaseConfig
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove BaseDAOTestCase.setUpDatabaseConfig
......................................................................
core: Remove BaseDAOTestCase.setUpDatabaseConfig
This method is not used anywhere in the codebase, and can easily be
removed.
Change-Id: I52ac1e2822ab8b8b576e6a7e038b06bc32c6e399
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52ac1e2822ab8b8b576e6a7e038b06bc32c6e399
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: Removed unused StoredProcToTypeMapping
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Removed unused StoredProcToTypeMapping
......................................................................
core: Removed unused StoredProcToTypeMapping
Change-Id: Idda25180de34ca1685417fad583f6b89992486b9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/StoredProcToTypeMapping.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22006
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idda25180de34ca1685417fad583f6b89992486b9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: core: Remove unused DbFacade.getColumnSize
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Remove unused DbFacade.getColumnSize
......................................................................
core: Remove unused DbFacade.getColumnSize
Change-Id: I0a87835119fdc18adcbf456072cfb76f6afe0d8e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
1 file changed, 0 insertions(+), 21 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22005
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a87835119fdc18adcbf456072cfb76f6afe0d8e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month
Change in ovirt-engine[master]: restapi: Fix broken path to the image under glance storage d...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: restapi: Fix broken path to the image under glance storage domain
......................................................................
restapi: Fix broken path to the image under glance storage domain
Changes broken link to the glance image from /api/images/${imageId}
to /api/storagedomains/${storageDomainId}/images/${imageId}
Change-Id: I480e798e3c74af8357d48a1fd93a4ce4ae608383
Bug-Url: https://bugzilla.redhat.com/1035997
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResource.java
2 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I480e798e3c74af8357d48a1fd93a4ce4ae608383
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 1 month