December 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: fix NPE for removing non existing template

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE for removing non existing template ...................................................................... core: fix NPE for removing non existing template The locking message assume the template being removed exist in the DB, therefore NPE can be thrown there. Added a null check and in case the template is null, we won't try to lock the template (that is ok since the can-do-action phase is going to fail anyway). Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in SpiceConsoleModel

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in SpiceConsoleModel ...................................................................... ui: rename members to start with lowercase in SpiceConsoleModel Solves 4 findbugs warnings Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 2 files changed, 12 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f14801edfea446476aef8ef6ec2a897c7d89efa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in BookmarkListModel

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in BookmarkListModel ...................................................................... ui: rename members to start with lowercase in BookmarkListModel Solves findbugs warnings Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in several classes

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in several classes ...................................................................... ui: rename members to start with lowercase in several classes Solves findbugs warnings. Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/ChangeCDModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 5 files changed, 14 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3208a2f2c64685b2f7efa3e4766905f953ee509d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Retrieve host interfaces by label

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Retrieve host interfaces by label ...................................................................... engine: Retrieve host interfaces by label The added stored-procedure allow to fetch the interfaces which are labelled with a given label in a specific cluster. Change-Id: Icbb3fa47f3c85d4d884a1f4cb4d1a7c04528eee9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/network_sp.sql 5 files changed, 74 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/22656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbb3fa47f3c85d4d884a1f4cb4d1a7c04528eee9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine-sdk[master]: sdk: release 3.4.0.1-1

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.4.0.1-1 ...................................................................... sdk: release 3.4.0.1-1 Change-Id: I51d16e4f01ee117382ac8a2a48ce2d7f51b23831 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in M setup.py 3 files changed, 39 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51d16e4f01ee117382ac8a2a48ce2d7f51b23831 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years

1
0
0 / 0

Change in ovirt-engine-sdk[master]: sdk: regenerate against the latest api

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api Change-Id: I35bf6da7a0f8f3147a550ef8dbb82deecd2c2875 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 4 files changed, 2,353 insertions(+), 222 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35bf6da7a0f8f3147a550ef8dbb82deecd2c2875 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Change AttachNetworkToVdsGroupCommand to non-transac...

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change AttachNetworkToVdsGroupCommand to non-transactive ...................................................................... engine: Change AttachNetworkToVdsGroupCommand to non-transactive The command will be used also for configuring the network on the hostis. For that purpose the class should be managed as a non-transactive. Change-Id: I673024917d5308bfdfd2030eb9a2479f7e37ee03 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java 1 file changed, 31 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I673024917d5308bfdfd2030eb9a2479f7e37ee03 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: engine: Change AddNetworkCommand to non-transactive

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Change AddNetworkCommand to non-transactive ...................................................................... engine: Change AddNetworkCommand to non-transactive The AddNetworkCommand will be used also for configuring the network on the hosts by its label. For that purpose the class should be managed as a non-transactive, as changes should be kept into the database prior to setup networks and also the network update shouldn't be part of a wider transaction. Change-Id: I696601506a76db8fe9d0bef790b9cd7c2b434449 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I696601506a76db8fe9d0bef790b9cd7c2b434449 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

Change in ovirt-engine[master]: core: Validate host interface labels

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Validate host interface labels ...................................................................... core: Validate host interface labels The host nics labels is a set that each of its elements should comply to the network labels format. Change-Id: I37f035816617322c06a7851262177c5f43268081 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkLabelFormatConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNetworkLabelFormat.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/NetworkLabelFormatValidatorTest.java 4 files changed, 122 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37f035816617322c06a7851262177c5f43268081 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2013