February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: prevent several imported VMs with same name
by derez＠redhat.com 27 Feb '13

27 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: prevent several imported VMs with same name ...................................................................... webadmin: prevent several imported VMs with same name This patch prevents the user from assigning the same name for several imported VMs. if the user tries to assign a name that was already been assigned for a different VM that is going to be imported, the name field will be marked as invalid with a proper error message. When the user tried to import multiple VMs that already exist, he could choose a different name for each of them. when doing so, there was no validation that ensures the user don't assign the same name for several VMs, so the backend got that bunch of VMs to import with the given names and created them without checking that each name is unique (because it's done as multiple actions, thus not checking canDoAction on each of them), and the result is that there were multiple VMs created with the same name. So this patch prevents this situation from happening by ensuring that the UI don't pass several VMs with the same name to import to the backend, by adding a proper validation for the name field of the to-be-imported VM which checks that it's unique. Change-Id: I69eae7350ae840a06b440003c436f7adc0b032cd Bug-Url: https://bugzilla.redhat.com/907132 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/NotInCollectionValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 4 files changed, 184 insertions(+), 66 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69eae7350ae840a06b440003c436f7adc0b032cd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Bad error message when trying to create a new Role(#908...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Bad error message when trying to create a new Role(#908284) ...................................................................... cli: Bad error message when trying to create a new Role(#908284) Bad error message when trying to create a new Role without passing the collection correctly : "unknown error: 'int' object has no attribute 'split'" Change-Id: Iba01f4f02c0521332b84e7d5148b0c00c0a70b63 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908284 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba01f4f02c0521332b84e7d5148b0c00c0a70b63 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : RSDL lists host display address as mandatory(#9150...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : RSDL lists host display address as mandatory(#915066) ...................................................................... restapi : RSDL lists host display address as mandatory(#915066) Host display address is listed as a mandatory parameter in api?rsdl This patch changes the host.display.address to optional parameter Change-Id: Iaa6d7799d9e8f2bf45e8bb076c40afafff9f5e07 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915066 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa6d7799d9e8f2bf45e8bb076c40afafff9f5e07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: codegen: regenerate using new templates
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: regenerate using new templates ...................................................................... codegen: regenerate using new templates Change-Id: I4a668084d7d1600678898f005b129606e23e49f9 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 4,715 insertions(+), 1,714 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a668084d7d1600678898f005b129606e23e49f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Add constructor parameter validate_cert_chain=True #915...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Add constructor parameter validate_cert_chain=True #915225 ...................................................................... sdk: Add constructor parameter validate_cert_chain=True #915225 https://bugzilla.redhat.com/show_bug.cgi?id=915225 Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/web/connection.py 4 files changed, 37 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.2]: sdk: Add constructor parameter validate_cert_chain=True #915...
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Add constructor parameter validate_cert_chain=True #915225 ...................................................................... sdk: Add constructor parameter validate_cert_chain=True #915225 https://bugzilla.redhat.com/show_bug.cgi?id=915225 Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/templates/entrypointtemplate M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/connectionspool.py M src/ovirtsdk/web/connection.py 4 files changed, 37 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61707c4b0380665bc42b34387efdc622cfc4201e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: add flag --dont-validate-cert-chain #915231
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add flag --dont-validate-cert-chain #915231 ...................................................................... cli: add flag --dont-validate-cert-chain #915231 https://bugzilla.redhat.com/show_bug.cgi?id=915231 Change-Id: Id4819ca2de9aa47c48031eb3d09016961f8880c3 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/options.py M src/ovirtcli/settings.py 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4819ca2de9aa47c48031eb3d09016961f8880c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: add flag --dont-validate-cert-chain #915231
by mpastern＠redhat.com 27 Feb '13

27 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: add flag --dont-validate-cert-chain #915231 ...................................................................... cli: add flag --dont-validate-cert-chain #915231 https://bugzilla.redhat.com/show_bug.cgi?id=915231 Change-Id: Id4819ca2de9aa47c48031eb3d09016961f8880c3 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/options.py M src/ovirtcli/settings.py 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4819ca2de9aa47c48031eb3d09016961f8880c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Creating keystore for jboss use
by oschreib＠redhat.com 27 Feb '13

27 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Creating keystore for jboss use ...................................................................... packaging: Creating keystore for jboss use Currently jboss uses apache.p12 keystore file. In cases where apache is not used for proxying, jboss tries to use this file directly and fails on permissions. This patch tries to resolve the issue by adding an additional keystore jboss.p12 during setup/upgrade for the use by the jboss. Change-Id: I22d71d9de011e8af4bde26d9e2a048a6387ce70f Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/conf/ca/installCA.sh M packaging/fedora/engine-service.xml.in M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 6 files changed, 22 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22d71d9de011e8af4bde26d9e2a048a6387ce70f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LUN_storage_server_connection_map row mapper
by amureini＠redhat.com 27 Feb '13

27 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: LUN_storage_server_connection_map row mapper ...................................................................... core: LUN_storage_server_connection_map row mapper Added a singleton row mapper for StorageServerConnectionLunMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Ibd986b67d43c054a98144cde365d6e3f82d82641 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDAODbFacadeImpl.java 1 file changed, 21 insertions(+), 27 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd986b67d43c054a98144cde365d6e3f82d82641 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0