February 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: packaging: post otopi-1.0.0
by Alon Bar-Lev 14 Feb '13

14 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post otopi-1.0.0 ...................................................................... packaging: post otopi-1.0.0 Change-Id: Ib7bb6f0b8b68556556060fec8bda006658da00f1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7bb6f0b8b68556556060fec8bda006658da00f1 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: ovirt-log-collector-3.2.0
by kroberts＠redhat.com 14 Feb '13

14 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: ovirt-log-collector-3.2.0 ...................................................................... build: ovirt-log-collector-3.2.0 Change-Id: I5d136eed851c711c493fe14061050cf5f4336c35 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d136eed851c711c493fe14061050cf5f4336c35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: build: ovirt-image-uploader-3.2.0
by kroberts＠redhat.com 14 Feb '13

14 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: ovirt-image-uploader-3.2.0 ...................................................................... build: ovirt-image-uploader-3.2.0 Change-Id: I4f320713549f1965e2d2e51f6e63f2ba820c8f8f Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-image-uploader.spec.in 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f320713549f1965e2d2e51f6e63f2ba820c8f8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: ovirt-iso-uploader-3.2.0
by kroberts＠redhat.com 14 Feb '13

14 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: build: ovirt-iso-uploader-3.2.0 ...................................................................... build: ovirt-iso-uploader-3.2.0 Change-Id: Ic29c76b4fa13c6588f07e01447da21e4a2736f73 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-iso-uploader.spec.in 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Kiril Nesenko: Verified Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12054 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic29c76b4fa13c6588f07e01447da21e4a2736f73 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove redundant variable
by tnisan＠redhat.com 14 Feb '13

14 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove redundant variable ...................................................................... webadmin: remove redundant variable Remove isNew variable from StorageListModel because it's not needed. The evaluated statement storage==null is always false, because couple of rows before that storage name and descriptions are evaluated, and if storage was null, then NPE would be thrown there. Thus, storage is not null and the expression is always false, and isNew variable is not needed. Change-Id: Ib755a8fb39bae04349ee2617d556a589ab7cfd5c Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib755a8fb39bae04349ee2617d556a589ab7cfd5c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Display address and port when the VM is paused
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Display address and port when the VM is paused ...................................................................... restapi: Display address and port when the VM is paused Return address and port in the display even when the VM status is paused Change-Id: I551ef122cd201cf7fec4f2bfacaa1b7e7a41fd26 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 10 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I551ef122cd201cf7fec4f2bfacaa1b7e7a41fd26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.0.0
by Alon Bar-Lev 14 Feb '13

14 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.0.0 ...................................................................... packaging: ovirt-host-deploy-1.0.0 Change-Id: Ica1cae3eaf3fa2993e056c48350b4c148c8100fc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M ovirt-host-deploy.spec.in 3 files changed, 6 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica1cae3eaf3fa2993e056c48350b4c148c8100fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: missing DAO test for VDSGroup.storagePoolName
by dfediuck＠redhat.com 14 Feb '13

14 Feb '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: missing DAO test for VDSGroup.storagePoolName ...................................................................... core: missing DAO test for VDSGroup.storagePoolName Missing DAO test for VDSGroup.storagePoolName Change-Id: I5927d51262c34cd78929f76ff015f183da8c4cbb Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5927d51262c34cd78929f76ff015f183da8c4cbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: add vnic displays <UNKNOWN> in the event instead of ...
by alkaplan＠redhat.com 14 Feb '13

14 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add vnic displays <UNKNOWN> in the event instead of interface name ...................................................................... engine: add vnic displays <UNKNOWN> in the event instead of interface name InterfaceName is defined as CustomLogField annotation. Properties defined as CustomLogField should have public getter, in this case the getter was protected. Change-Id: I5824e32340403991b274c606fbe4334297ac851e Bug-Url: https://bugzilla.redhat.com/907154 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5824e32340403991b274c606fbe4334297ac851e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: add logging for VM NIC link up/down
by alkaplan＠redhat.com 14 Feb '13

14 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: add logging for VM NIC link up/down ...................................................................... engine: add logging for VM NIC link up/down When link is switched UP/DOWN on VM NIC it should be logged on AuditLog. This patch expands the NETWORK_UPDATE_VM_INTERFACE message to include information about changes in the link state. Change-Id: I3e7d34d8e7c213e4300f9405e90c4fba298f665d Bug-Url: https://bugzilla.redhat.com/902692 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 19 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e7d34d8e7c213e4300f9405e90c4fba298f665d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0