February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fixing a duplicate upgrade script
by emesika＠redhat.com 13 Feb '13

13 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing a duplicate upgrade script ...................................................................... core: fixing a duplicate upgrade script Change-Id: I5376185ec8a143539602acbf334ac15ba812669d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_02_0440_materialized_views_extensions.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified Shahar Havivi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5376185ec8a143539602acbf334ac15ba812669d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Custom Materialized Views should be...
by emesika＠redhat.com 13 Feb '13

13 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Custom Materialized Views should be... ...................................................................... core: Custom Materialized Views should be... Custom Materialized Views should be treated differently from regular product Materialized Views This patch addresses the following issues: 1) Do not fail the upgrade on custom MV file, rather, revert the custom changes and generate only warnings (need support from integration team) 2) Add custom column to MV table that will easily distinguish between product MV and custom MV. 3) Add active column to temporary disable a MV 4) Refresh options: Defining min refresh flood time in seconds (in the same manner log flood is handled) Change-Id: I6a6857a1691c1dafa1a7edcd58b292e70c78b318 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907232 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/materialized_views_sp.sql A backend/manager/dbscripts/upgrade/03_02_0400_materialized_views_extensions.sql 3 files changed, 138 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6857a1691c1dafa1a7edcd58b292e70c78b318 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Resize dialogs to fit the screen in 10...
by tnisan＠redhat.com 13 Feb '13

13 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin, userportal: Resize dialogs to fit the screen in 1024x768 resolution ...................................................................... webadmin, userportal: Resize dialogs to fit the screen in 1024x768 resolution Resized the VM run once dialog and VM/Template import dialogs to fit the screen in 1024x768 resolution related to https://bugzilla.redhat.com/879324 Change-Id: I126c65ebe1adcd490a09d0fb8961118c0afbde30 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmRunOncePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmRunOncePopupView.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I126c65ebe1adcd490a09d0fb8961118c0afbde30 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: fixed rpm build warning
by ydary＠redhat.com 13 Feb '13

13 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed rpm build warning ...................................................................... packaging: fixed rpm build warning due to package naming change option the rpm build gave warning: 'File listed twice: /usr/bin/ovirt-engine-reports-setup' this fix causes the file to not appear twice. Change-Id: I11de2c5bb5442bc17a34479b5e6b5a53a7b68d38 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11de2c5bb5442bc17a34479b5e6b5a53a7b68d38 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in samples-portals[master]: added views as seperate files
by shavivi＠redhat.com 13 Feb '13

13 Feb '13

Shahar Havivi has submitted this change and it was merged. Change subject: added views as seperate files ...................................................................... added views as seperate files Change-Id: Ie3a37e9304cfd8a2ec9a14b01a942f4cd73730dd Signed-off-by: Ohad Levy <ohadlevy(a)gmail.com> Signed-off-by: Shahar Havivi <shaharh(a)gmail.com> --- A ruby/views/login.html.erb A ruby/views/vms.html.erb M ruby/webhandler.rb 3 files changed, 69 insertions(+), 63 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3a37e9304cfd8a2ec9a14b01a942f4cd73730dd Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: added Gemfile
by shavivi＠redhat.com 13 Feb '13

13 Feb '13

Shahar Havivi has submitted this change and it was merged. Change subject: added Gemfile ...................................................................... added Gemfile Change-Id: I43407ff479d1f6ce605f8e1c4ebff17a688e4f97 Signed-off-by: Ohad Levy <ohadlevy(a)gmail.com> Signed-off-by: Shahar Havivi <shaharh(a)gmail.com> --- A ruby/Gemfile A ruby/Gemfile.lock M ruby/README M ruby/webhandler.rb 4 files changed, 45 insertions(+), 6 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43407ff479d1f6ce605f8e1c4ebff17a688e4f97 Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Ohad Levy <ohadlevy(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: attempt revert when failing to add template
by amureini＠redhat.com 13 Feb '13

13 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: attempt revert when failing to add template ...................................................................... core: attempt revert when failing to add template When failing to add a template, delete the added template disks from the db and attempt to delete the possibly added images from the storage to avoid storage leak. Change-Id: Ia0f40397f5fb9f7e1a3535796c07f5bed7bd5ac1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883921 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java 2 files changed, 18 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0f40397f5fb9f7e1a3535796c07f5bed7bd5ac1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup AddVmPoolWithVmsCommand#getJobMessagePropertie...
by masayag＠redhat.com 13 Feb '13

13 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties ...................................................................... core: cleanup AddVmPoolWithVmsCommand#getJobMessageProperties - fix indentation - replace simple if statements with ternary if - replace "" with StringUtils.Empty Change-Id: I1513f901b7c5ef2b3d215ff119e0f69240c9411a Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java 1 file changed, 7 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1513f901b7c5ef2b3d215ff119e0f69240c9411a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: moved repeated null value check.
by tnisan＠redhat.com 13 Feb '13

13 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: moved repeated null value check. ...................................................................... core: moved repeated null value check. The null value check of the relevant disk image repeated itself and left a chance for an NPE - now it's done within the called method. Change-Id: I3e4958c9dc108dc6d44e25a5074439e6ec018c12 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e4958c9dc108dc6d44e25a5074439e6ec018c12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: show event -id accept strings instead of numeric values...
by mpastern＠redhat.com 13 Feb '13

13 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: show event -id accept strings instead of numeric values(#886786) ...................................................................... cli: show event -id accept strings instead of numeric values(#886786) Show event -id does not accept numeric values. This patch does and explicit cast into string for ids. Change-Id: Ie31f1f6cb9e5bbc9146088bd820cf80ebf41d757 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=886786 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie31f1f6cb9e5bbc9146088bd820cf80ebf41d757 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0