February 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: packaging: otopi-1.0.0
by Alon Bar-Lev 14 Feb '13

14 Feb '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: otopi-1.0.0 ...................................................................... packaging: otopi-1.0.0 Change-Id: I5e107384076af700a03eccea88548bb7beff8846 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 6 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e107384076af700a03eccea88548bb7beff8846 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed MTU/VLAN in Networks/General subtab
by alkaplan＠redhat.com 14 Feb '13

14 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed MTU/VLAN in Networks/General subtab ...................................................................... webadmin: Fixed MTU/VLAN in Networks/General subtab Commas no longer appear as separators in large numbers. Change-Id: Ia267b9b4dabde560fc24ef4334df0868f1a2a13c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=891902 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkGeneralView.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/12058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia267b9b4dabde560fc24ef4334df0868f1a2a13c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : replace Backend.getInstance with getBackend()
by mlipchuk＠redhat.com 14 Feb '13

14 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core : replace Backend.getInstance with getBackend() ...................................................................... core : replace Backend.getInstance with getBackend() Change-Id: I1c5a86133799745baccf50dfe46466aab3856316 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/12043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c5a86133799745baccf50dfe46466aab3856316 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Add per-VM VncKeyboardLayout
by ofrenkel＠redhat.com 14 Feb '13

14 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: Add per-VM VncKeyboardLayout ...................................................................... restapi: Add per-VM VncKeyboardLayout Added keyboard_layout to display Change-Id: Ibdf2b9f74d483a1be9caaa6d6a47ba8de7c37420 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 6 files changed, 31 insertions(+), 0 deletions(-) Approvals: Martin Beták: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdf2b9f74d483a1be9caaa6d6a47ba8de7c37420 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add per-VM VncKeyboardLayout
by ofrenkel＠redhat.com 14 Feb '13

14 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Add per-VM VncKeyboardLayout ...................................................................... engine: Add per-VM VncKeyboardLayout Added support for per-VM VncKeyboardLayout setting. Backend support for setting local values of keyboard layout per individual VM Change-Id: Ib73338ce279aa4f14f1332dbdebb1dd0f1cec974 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_02_0450_add_vm_vnc_keyboard_layout.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ContainedInConfigValueListConstraint.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/IntegerContainedInConfigValueListConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NullOrStringContainedInConfigValueListConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/StringContainedInConfigValueListConstraint.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/NullOrStringContainedInConfigValueList.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/StringContainedInConfigValueList.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 27 files changed, 234 insertions(+), 45 deletions(-) Approvals: Martin Beták: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73338ce279aa4f14f1332dbdebb1dd0f1cec974 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: engine-config enable get key by alternateKey name
by ofrenkel＠redhat.com 14 Feb '13

14 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: tools: engine-config enable get key by alternateKey name ...................................................................... tools: engine-config enable get key by alternateKey name Enable to use $ engine-config -g AlternateKeyName Change-Id: If42e7f15df3153a4163abcf14c57a045a9b9ae58 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Martin Beták: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42e7f15df3153a4163abcf14c57a045a9b9ae58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer
by oschreib＠redhat.com 14 Feb '13

14 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Application Mode option in installer ...................................................................... packaging: Application Mode option in installer Application Mode option added to engine-setup, Engine can be configured as gluster only, virtualization only or both. This new prompt can be disabled by setting USE_DEFAULT_APPLICATION_MODE_WITHOUT_PROMPT to True in basedef.py Also introduced a Constant(CONST_DEFAULT_APPLICATION_MODE) in basedef.py to set the default application mode. Now USE_DEFAULT option can be dynamic, so function name can be specified instead of value. Initially USE_DEFAULT contains True or False, now function name can be given instead of Boolean which helps to decide usage depending on the other questions answered. Modified NFS options override in plugins/all_in_one_100.py since those options can be managed by setting USE_DEFAULT dynamically. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901443 Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a Signed-off-by: Aravinda VK <avishwan(a)redhat.com> (cherry picked from commit 3dde9fbe2792e54d5c6c93d0e88cf8ab84f95367) --- M backend/manager/dbscripts/inst_sp.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/plugins/all_in_one_100.py 6 files changed, 117 insertions(+), 13 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: BackendExportDomainDisksResourceTest build
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: BackendExportDomainDisksResourceTest build ...................................................................... restapi: BackendExportDomainDisksResourceTest build Fix the build break introduced in change-id I83fd4b046f72f73bb516615137522ac40028a7f0I83fd4b046f72f73bb516615137522ac40028a7f0 (using setimageStatus instead of setImageStatus). Change-Id: I7e1a303a00826d3d1f07b648ef97bd5d8c07a21b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e1a303a00826d3d1f07b648ef97bd5d8c07a21b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : error when adding disk with missing parameters(#89...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : error when adding disk with missing parameters(#890524) ...................................................................... restapi : error when adding disk with missing parameters(#890524) When trying to add disk with missing parameters we get error with superfluous 0: Disk [format, interface] required for invoke0 This patch fixes the error message by returning the right operation name in the message Change-Id: I754786cf3f916bc3e34bda71073ff3ebcaca94d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I754786cf3f916bc3e34bda71073ff3ebcaca94d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : error when adding disk with missing parameters(#89...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : error when adding disk with missing parameters(#890524) ...................................................................... restapi : error when adding disk with missing parameters(#890524) When trying to add disk with missing parameters we get error with superfluous 0: Disk [format, interface] required for invoke0 This patch fixes the error message by returning the right operation name in the message Change-Id: I2969ea3234296f5d3583ca70b86b8bfa93dc53ed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2969ea3234296f5d3583ca70b86b8bfa93dc53ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0