Change in ovirt-engine[master]: core: Refactor method names related to zombie treatment
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Refactor method names related to zombie treatment
......................................................................
core: Refactor method names related to zombie treatment
Refactor some method names related to zombie task treatment
Change-Id: Iccaba93ac801767e1c0d831faf125eebe77d26a5
Bug-Url: https://bugzilla.redhat.com/907465
Signed-off-by: Yair Zaslasky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityMultiAsyncTasks.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SPMAsyncTask.java
4 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11891
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iccaba93ac801767e1c0d831faf125eebe77d26a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Remove Encr?ptionManagerMessages
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove Encr?ptionManagerMessages
......................................................................
core: Remove Encr?ptionManagerMessages
There are two classes with this name, one with "y" and one with "i".
None of them is used.
Change-Id: I5b106ec7dc5a242495a2ef87b9881c308e8e6939
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
D backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncriptionManagerMessages.java
D backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionManagerMessages.java
2 files changed, 0 insertions(+), 61 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b106ec7dc5a242495a2ef87b9881c308e8e6939
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: webadmin: making RegexValidation testable
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: making RegexValidation testable
......................................................................
webadmin: making RegexValidation testable
This patch change the call to Regex#IsMatch(String,String,RegexOptions)
within RegexValidation with a call to Regex#IsMatch(String,String).
The problem is that Regex#IsMatch(String,String,RegexOptions) isn't
implmenented (throws NotImplementedException) in Regex class that is
located in compat project, thus classes that inherits RegexValidation
can't be tested with unit tests.
>From the UI perspective this patch doesn't change much because in the
Regex class of the UI (located in gwt-extension) the method
Regex#IsMatch(String,String) calls
Regex#IsMatch(String,String,RegexOptions) with RegexOptions.None.
Change-Id: Ib35b0b1a4b7a29902a65986e1ceadf231a9a8c50
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/RegexValidation.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11843
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib35b0b1a4b7a29902a65986e1ceadf231a9a8c50
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: tools: Consolidate all tools to single project
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: tools: Consolidate all tools to single project
......................................................................
tools: Consolidate all tools to single project
Currently the source files used by the tools are located in several
projects and this makes locating and working with them difficult. This
patch moves all the files related to the tools to a single maven project
with a single artifact.
Change-Id: Id93001dd30afd9a8d5a10a122c21a17fd3c67aa2
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M .gitignore
M Makefile
M backend/manager/modules/utils/pom.xml
D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/LdapAuthModeEnum.java
D backend/manager/tools/engine-config/pom.xml
D backend/manager/tools/engine-notifier/engine-notifier-resources/pom.xml
D backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/assembly/assembly.xml
D backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml
D backend/manager/tools/engine-notifier/engine-notifier-service/src/test/resources/log4j.xml
D backend/manager/tools/engine-notifier/pom.xml
D backend/manager/tools/engine-tools-common/pom.xml
D backend/manager/tools/engine-tools-common/src/test/resources/log4j.xml
M backend/manager/tools/pom.xml
R backend/manager/tools/src/main/conf/engine-config-log4j.xml
R backend/manager/tools/src/main/conf/engine-config.conf
R backend/manager/tools/src/main/conf/engine-config.properties
A backend/manager/tools/src/main/conf/engine-manage-domains-log4j.xml
R backend/manager/tools/src/main/conf/engine-manage-domains.conf
R backend/manager/tools/src/main/conf/engine-notifier-log4j.xml
R backend/manager/tools/src/main/conf/engine-notifier.conf
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/AppConfig.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/ConfigFile.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigMap.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigUtils.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/KeysConfig.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/OptionKey.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDAO.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/db/ConfigDaoImpl.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/ValidationResult.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidator.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/EngineConfigValidatorFactory.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/GetValidator.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/SetValidator.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ValidatorType.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/DomainsConfigurationEntry.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/FailedReadingConfigValueException.java
A backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/LdapAuthModeEnum.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsConfiguration.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAO.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAOImpl.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResult.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsResultEnum.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/PasswordDomainsConfigurationEntry.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationServiceException.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/Notifier.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/EventMethodFiller.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactory.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodFactoryEmailImpl.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/methods/NotificationMethodMapBuilder.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationConfigurator.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/EventSender.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/EventSenderResult.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventMessageContent.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageBody.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageHelper.java
R backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java
R backend/manager/tools/src/main/shell/engine-config.sh
R backend/manager/tools/src/main/shell/engine-manage-domains.sh
R backend/manager/tools/src/main/shell/engine-notifier-service.sh
R backend/manager/tools/src/main/shell/engine-notifier.sh
R backend/manager/tools/src/main/shell/engine-prolog.sh.in
R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigCLIParserTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigLogicTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/config/EngineConfigValidatorTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/EngineMonitorServiceTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/NotificationServiceTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/NotificationConfiguratorTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/utils/mail/MailSenderTest.java
R backend/manager/tools/src/test/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSourceTest.java
R backend/manager/tools/src/test/resources/conf/connection-test-notifier.conf
R backend/manager/tools/src/test/resources/conf/error-notifier.conf
R backend/manager/tools/src/test/resources/conf/notifier.conf
R backend/manager/tools/src/test/resources/engine-config.conf
R backend/manager/tools/src/test/resources/engine-config.properties
R backend/manager/tools/src/test/resources/engine-config_es_ES.properties
R backend/manager/tools/src/test/resources/engine-config_he_IL.properties
R backend/manager/tools/src/test/resources/engine-config_iw_IL.properties
R backend/manager/tools/src/test/resources/log4j.xml
M packaging/fedora/setup/basedefs.py
M packaging/fedora/spec/ovirt-engine.spec.in
M pom.xml
102 files changed, 173 insertions(+), 466 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id93001dd30afd9a8d5a10a122c21a17fd3c67aa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: Preventing running host monitor during activation of...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Preventing running host monitor during activation of host operation
......................................................................
engine: Preventing running host monitor during activation of host operation
The following patch will prevent running of host monitoring during Activate host operation.
It is means that activate host operation will wait untill monitoring will be finished and will acquire a lock.
When a lock is acquired by activate operation a monitoring will be skipped.
Change-Id: If7f5eed741ca392ed7144934c539d2aa70744431
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
3 files changed, 123 insertions(+), 93 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7f5eed741ca392ed7144934c539d2aa70744431
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[engine_3.2]: restapi : malformated guid's cause http 500 (#902073)
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : malformated guid's cause http 500 (#902073)
......................................................................
restapi : malformated guid's cause http 500 (#902073)
When malformed Guids are passed in post data for action
the backend throws an internal error.
This patch moves MalformedIdException to restapi-types and
throws the exception if any invalid guids are passed.
Change-Id: Iebce833327654e1635632fb4a00ca8a3cf14fab5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=902242
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/MalformedIdExceptionMapper.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DataCenterMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MappingLocator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QuotaMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/RoleMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TagMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/GuidUtils.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/MalformedIdException.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
23 files changed, 95 insertions(+), 71 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebce833327654e1635632fb4a00ca8a3cf14fab5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: restapi : Add Role with wrong permit id leads to 500 error(#...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Add Role with wrong permit id leads to 500 error(#908392)
......................................................................
restapi : Add Role with wrong permit id leads to 500 error(#908392)
Add Role with wrong permit id leads to internal server error.
This patch returns a proper error message when the permit id
is invalid.
Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908392
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendRolesResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
2 files changed, 30 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9adfda37e67d24f96933aa4eb8f79a8fdb416d62
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: Removing a global transaction from Login commands
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Removing a global transaction from Login commands
......................................................................
engine: Removing a global transaction from Login commands
The following fix is simple, but this fix will reduce a number of open transaction during
login.
Should improve a Monday scenario.
Change-Id: Ibb7d8729979a8e767adad4f0e75a63b94e5081ab
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginAdminUserCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginUserCommand.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11879
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb7d8729979a8e767adad4f0e75a63b94e5081ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: Performance improvement in clean up compensation dat...
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Performance improvement in clean up compensation data
......................................................................
engine: Performance improvement in clean up compensation data
If the command is running with out compensation context no need to clean it.
In memory check is much more faster than call to db
Change-Id: Ieb256db6415c8fd5f45fcee5bae984739e61fec3
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb256db6415c8fd5f45fcee5bae984739e61fec3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: placeholder handler revert task on failure
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: placeholder handler revert task on failure
......................................................................
core: placeholder handler revert task on failure
CreateImagePlaceholderTaskHandler:
endWithFailure() should revert task (unlocks the image)
since beforeTask() locks the image.
Change-Id: I266792d30ce4a2743a19db2b9776a3aea2eedfed
Bug-Url: https://bugzilla.redhat.com/907167
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11830
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I266792d30ce4a2743a19db2b9776a3aea2eedfed
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 7 months