February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: reports: fixed misbranded resources
by ydary＠redhat.com 03 Feb '13

03 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed misbranded resources ...................................................................... reports: fixed misbranded resources Change-Id: I60fa180002e28db89d6e2df71922270b082b676c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M manifest/ovirt-reports-manifest.csv M server-customizations/WEB-INF/decorators/decorator.jsp M server-customizations/WEB-INF/decorators/minimalDecorator.jsp M server-customizations/WEB-INF/jsp/modules/login/login.jsp 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60fa180002e28db89d6e2df71922270b082b676c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable remove quota when quota is not enforced
by derez＠redhat.com 03 Feb '13

03 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Enable remove quota when quota is not enforced ...................................................................... core: Enable remove quota when quota is not enforced In current implementation there is no way to remove all quota from the DC once a quota was assigned to some entities. The CanDoAction logic of removing quota was changed so that when a DC is in 'Disabled' Quota enforcement mode a quota could be removed (regardless of it been assigned to some entities). Change-Id: I95ff993b0db21a17e62e3258338bd524c5c8b957 Bug-Url: https://bugzilla.redhat.com/895237 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ff993b0db21a17e62e3258338bd524c5c8b957 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: handle error when iso domain in maintenance
by mlipchuk＠redhat.com 03 Feb '13

03 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: handle error when iso domain in maintenance ...................................................................... core: handle error when iso domain in maintenance The bug started from code inserted in change I9d24c94c. Currently, when iso domain cannot be accessed for any reason, it's considered a problematic domain and is mentioned in the event log. This patch adds a check that if the domain is not active, it is not attempted to be refreshed, hence not adding in event log the error (because it's expected it cannot be accessed) Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Bug-Url: https://bugzilla.redhat.com/902246 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 26 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing use of Quartz scheduler by ThreadPool duri...
by mkublin＠redhat.com 03 Feb '13

03 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replacing use of Quartz scheduler by ThreadPool during SPM election ...................................................................... engine: Replacing use of Quartz scheduler by ThreadPool during SPM election The following patch will use a thread pool util instead of quartz scheduler for running immediate job. Change-Id: Ice54e028545ea6772528c9ab30abc7ff5c5276c7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 26 insertions(+), 20 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice54e028545ea6772528c9ab30abc7ff5c5276c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix sql grammar for calculateallstorageusage
by yzaslavs＠redhat.com 03 Feb '13

03 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix sql grammar for calculateallstorageusage ...................................................................... core: Fix sql grammar for calculateallstorageusage SQL grammar of calculateallstorageusage() function was changed to be compatible with older postgres versions (under 9.1). Change-Id: I1dd5d9532357f7dd267850ea76afae0f6c9d6257 Bug-Url: https://bugzilla.redhat.com/905891 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: ofri masad: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dd5d9532357f7dd267850ea76afae0f6c9d6257 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: minor cleanup
by ofrenkel＠redhat.com 03 Feb '13

03 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: minor cleanup ...................................................................... core: minor cleanup Minor cleanup in VmPoolMonitor & VmPoolCommandBase classes Change-Id: I7aaa8f37b5b4b4d872f374be8b5b8f7adacc5222 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java 2 files changed, 13 insertions(+), 42 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/11635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aaa8f37b5b4b4d872f374be8b5b8f7adacc5222 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: make backup.sh respenct ENGINE_PGPASS
by emesika＠redhat.com 03 Feb '13

03 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: db: make backup.sh respenct ENGINE_PGPASS ...................................................................... db: make backup.sh respenct ENGINE_PGPASS Change-Id: I90839a754d8a95fe11b099b54d9505d336f15721 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/backup.sh 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90839a754d8a95fe11b099b54d9505d336f15721 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: do not override ENGINE_PGPASS if exists
by emesika＠redhat.com 03 Feb '13

03 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: db: do not override ENGINE_PGPASS if exists ...................................................................... db: do not override ENGINE_PGPASS if exists Change-Id: Ic74469b2019881e937cd52ebec6728cc45d2e6e4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic74469b2019881e937cd52ebec6728cc45d2e6e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: do not override log file
by emesika＠redhat.com 03 Feb '13

03 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: db: do not override log file ...................................................................... db: do not override log file Change-Id: Ifcb59169ef4391fd935f68a36cc5147f5124163b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcb59169ef4391fd935f68a36cc5147f5124163b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: support absolute log files
by emesika＠redhat.com 03 Feb '13

03 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: db: support absolute log files ...................................................................... db: support absolute log files Change-Id: Ife150c0d965fbadd47bd4291d5e9d62eeaa25f63 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/engine-db-install.sh 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife150c0d965fbadd47bd4291d5e9d62eeaa25f63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0