March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: db: allow overriding PGPASSFILE using ENGINE_PASSFILE
by emesika＠redhat.com 13 Mar '13

13 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: db: allow overriding PGPASSFILE using ENGINE_PASSFILE ...................................................................... db: allow overriding PGPASSFILE using ENGINE_PASSFILE Having hard coded locations is not good for installation phase. Change-Id: I89e12fb7cdcd97cb46738aa24a73d0b4fd8b5f01 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89e12fb7cdcd97cb46738aa24a73d0b4fd8b5f01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: add create_schema to allow unprivileged schema creation
by emesika＠redhat.com 13 Mar '13

13 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: db: add create_schema to allow unprivileged schema creation ...................................................................... db: add create_schema to allow unprivileged schema creation This will enable user to create his own database and user, and still use the installer, without having privileged user credentials. Change-Id: I32c24e9e7a516c2c96814f7b723b98aab644ac57 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/create_db.sh A backend/manager/dbscripts/create_schema.sh 2 files changed, 76 insertions(+), 24 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32c24e9e7a516c2c96814f7b723b98aab644ac57 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixing small bug in canDoaction() of RemoveVdsComman...
by mkublin＠redhat.com 13 Mar '13

13 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing small bug in canDoaction() of RemoveVdsCommand ...................................................................... engine: Fixing small bug in canDoaction() of RemoveVdsCommand Missing condition in if, change is obvious Change-Id: I7f342d15a7c9f2d6e6ed8de05ab87b839600c56b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f342d15a7c9f2d6e6ed8de05ab87b839600c56b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Optimyzing RemoveVds
by mkublin＠redhat.com 13 Mar '13

13 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Optimyzing RemoveVds ...................................................................... engine: Optimyzing RemoveVds The following patch will improve canRemoveVds method of RemoveVdsCommand. The change will reduce a number of queries and will make code more clear. Also removed duplicate check inside execute() - it will not prevent a race, but it always reduce performance Change-Id: Id2a11727041955aeda1940fca1f27c616f46135f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java 1 file changed, 39 insertions(+), 60 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2a11727041955aeda1940fca1f27c616f46135f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : manage-domains messages should be more clear
by yzaslavs＠redhat.com 13 Mar '13

13 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : manage-domains messages should be more clear ...................................................................... tools : manage-domains messages should be more clear When user adds a domain with no "-addPermissions" the message should show the option of -action=edit with -addPermissions option. When the user edits a domain to change the password of a user who has been granted permissions with -addPermissions, the message to grant permissions should not be displayed. Change-Id: I04bd16bebfcd9e5390444c525fc45363acff835c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908246 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAO.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsDAOImpl.java 4 files changed, 80 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04bd16bebfcd9e5390444c525fc45363acff835c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Wrong error on decreasing data center compatibilit...
by yzaslavs＠redhat.com 13 Mar '13

13 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: webadmin: Wrong error on decreasing data center compatibility version ...................................................................... webadmin: Wrong error on decreasing data center compatibility version A wrong error message is given when trying to decrease data center compatibility version. When editing a data center to change its compatibility version the UI shows error message "Cannot edit Repository. Compatibility version is invalid, previous value restored." This patch changes the error message to "Cannot decrease data center compatibility version." Change-Id: Ic55a2c180e0e5b86477afaacc4e1daf65fb2c570 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904729 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic55a2c180e0e5b86477afaacc4e1daf65fb2c570 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: updated manifest file
by ydary＠redhat.com 13 Mar '13

13 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: updated manifest file ...................................................................... packaging: updated manifest file Change-Id: I941c3ea3c84fc84d293eada3b409f18471c526fd Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M manifest/ovirt-reports-manifest.csv 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I941c3ea3c84fc84d293eada3b409f18471c526fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: updated localization files (#918075)
by ydary＠redhat.com 13 Mar '13

13 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: updated localization files (#918075) ...................................................................... reports: updated localization files (#918075) Bug-Url: https://bugzilla.redhat.com/918075 Change-Id: I7c27b3bf2c045c76363a31e573eb8aa03ad1f9b1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- D reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle.properties.data R reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_de.properties.data A reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_en_US.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_es.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_fr.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_ja.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_pt_BR.properties.data M reports/repository_files/resources/reports_resources/localization/ovirt_reports_bundle_zh_CN.properties.data 9 files changed, 801 insertions(+), 243 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c27b3bf2c045c76363a31e573eb8aa03ad1f9b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: updated localization strings (#918075)
by ydary＠redhat.com 13 Mar '13

13 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: updated localization strings (#918075) ...................................................................... history: updated localization strings (#918075) Bug-Url: https://bugzilla.redhat.com/918075 Change-Id: I9fb206a1bdbad1c983ad98b7dfaa32574b92580d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/03_02_0060_updated_enums.sql M data-warehouse/historydbscripts_postgres/upgrade/post_upgrade/0010_change_enum_lang_code.sql 2 files changed, 612 insertions(+), 6 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fb206a1bdbad1c983ad98b7dfaa32574b92580d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: added utility fuction to update enum values (#91807...
by ydary＠redhat.com 13 Mar '13

13 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: added utility fuction to update enum values (#918075) ...................................................................... history: added utility fuction to update enum values (#918075) Bug-Url: https://bugzilla.redhat.com/918075 Change-Id: I5921a20165466cba5f5ab7870dafb3d53cda8b8d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/03_02_0050_add_function_to_update_enum_table.sql 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5921a20165466cba5f5ab7870dafb3d53cda8b8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0