March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: IscsiTargetToLunView - style fine-tune
by derez＠redhat.com 10 Mar '13

10 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: IscsiTargetToLunView - style fine-tune ...................................................................... webadmin: IscsiTargetToLunView - style fine-tune Fine tune width/height styles in IscsiTargetToLunView (fix issues in some browsers/languages). Change-Id: Ibda600f5fbaca80b22c5a0525ab444314a9e5f2e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiDiscoverTargetsView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda600f5fbaca80b22c5a0525ab444314a9e5f2e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: enable interface edit for shareable disk
by derez＠redhat.com 10 Mar '13

10 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: enable interface edit for shareable disk ...................................................................... webadmin: enable interface edit for shareable disk Enable 'Disk Interface' select-box in Edit disk dialog. Change-Id: Ieebe5412d1fc68f2372056d756b0ac2345785a4d Bug-Url: https://bugzilla.redhat.com/919683 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieebe5412d1fc68f2372056d756b0ac2345785a4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DirectLUN FC - fix radio-buttons behavior
by derez＠redhat.com 10 Mar '13

10 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DirectLUN FC - fix radio-buttons behavior ...................................................................... webadmin: DirectLUN FC - fix radio-buttons behavior Fixed radio-button single-selection behavior for FC DirectLUN (added single-selection listeners to FC LunModels for clearing unselected radio-buttons). Change-Id: I739adc6da16ca075acd4a3ae6d48e4ad2d8cac79 Bug-Url: https://bugzilla.redhat.com/918568 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739adc6da16ca075acd4a3ae6d48e4ad2d8cac79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change imports from * to FQCN
by tnisan＠redhat.com 10 Mar '13

10 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: change imports from * to FQCN ...................................................................... core: change imports from * to FQCN Changed import statements in several classes from using * to FQCN. Change-Id: I84dede09b0331b9211df289d152568d8df7c107b Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddSANStorageDomainParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DetachStorageDomainFromPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ActivateStorageDomainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ActivateVdsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AttachStorageDomainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeleteImageGroupVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DestroyImageVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DetachStorageDomainVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetStorageDomainDescriptionVDSCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetStoragePoolDescriptionVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ActivateVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DestroyStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/SetStoragePoolDescriptionVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStoragePoolVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java 22 files changed, 30 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84dede09b0331b9211df289d152568d8df7c107b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused imports in several classes
by tnisan＠redhat.com 10 Mar '13

10 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: remove unused imports in several classes ...................................................................... core: remove unused imports in several classes Removed unused import statements in several classes. Change-Id: I8d7fa3143d692fd337165f8d8ed26d9941fde97e Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/NetworkNonOperationalQueryParamenters.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EventProvidingCollection.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendQueryAsyncResult.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/external/StringUtils.java 7 files changed, 26 insertions(+), 34 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d7fa3143d692fd337165f8d8ed26d9941fde97e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Anonymous Coward #1000362 Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: extract null check from VmRunHandler#canRunVm
by ofrenkel＠redhat.com 10 Mar '13

10 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: extract null check from VmRunHandler#canRunVm ...................................................................... core: extract null check from VmRunHandler#canRunVm This patch extract the check whether the given VM is null from the VmRunHandler#canRunVm method. the reason for that is that in both places that call this method it makes sense to check it before making the call. So now as part of the "contract" of this method, the given VM must not be null (and the method's documentation was updated accordingly). Change-Id: I42fd8274577ba94accf16a4f944de07ca9ea5419 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 4 files changed, 42 insertions(+), 32 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42fd8274577ba94accf16a4f944de07ca9ea5419 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allow Update of Network on Host
by msalem＠redhat.com 10 Mar '13

10 Mar '13

Muli Salem has submitted this change and it was merged. Change subject: core: Allow Update of Network on Host ...................................................................... core: Allow Update of Network on Host This patch removes the canDoAction that checks whether a network that is being updated is used by one of the data center hosts. This creates uniform behaviour, since removing a network that is used by a host from a data center is allowed. Change-Id: If328c80571d404be453a83c6a14396716b678c74 Bug-Url: https://bugzilla.redhat.com/909820 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12527 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If328c80571d404be453a83c6a14396716b678c74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: engine-setup - Don't change selinux context in ru...
by oschreib＠redhat.com 10 Mar '13

10 Mar '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-setup - Don't change selinux context in runtime ...................................................................... packaging: engine-setup - Don't change selinux context in runtime Engine setup use miniyum to perform RPM/YUM based operations, and asks miniyum to change the selinux context of the whole proccess during it's intializtion. This patch removes the selinux context change, as it blocks dbus messeges issued by firewalld api, and currently not really needed. Change-Id: I46e04f185c04cc30c8e0b52367d6209716dc0d98 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904153 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> (cherry picked from commit 2b6ee2a975f9a109fc965bd022912fa4e514071e) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46e04f185c04cc30c8e0b52367d6209716dc0d98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : missing cpu mode option in both add and update vm(...
by mpastern＠redhat.com 10 Mar '13

10 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : missing cpu mode option in both add and update vm(#916700) ...................................................................... restapi : missing cpu mode option in both add and update vm(#916700) When adding / updating Vm using the CLI, the cpu-mode option is missing in the available options Change-Id: I1d08f77ceecc45253a0b9997c4c43e0bd995ac9a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916700 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d08f77ceecc45253a0b9997c4c43e0bd995ac9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : GET: /api/vms/xxx/reporteddevices returns yaml not...
by mpastern＠redhat.com 10 Mar '13

10 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : GET: /api/vms/xxx/reporteddevices returns yaml not xml(#915036) ...................................................................... restapi : GET: /api/vms/xxx/reporteddevices returns yaml not xml(#915036) Api returns yaml for /api/vms/xxx/reporteddevices and /api/hosts/xxx/hooks This patch fixes the return type for reporteddevices and hooks. Change-Id: I90ff2099da3afd0713bf4a1e48c348c313c4e1ff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915036 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDeviceResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDevicesResource.java 4 files changed, 0 insertions(+), 10 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ff2099da3afd0713bf4a1e48c348c313c4e1ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0