March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-encrypt-passwd.sh as standalone script
by juan.hernandez＠redhat.com 14 Mar '13

14 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-encrypt-passwd.sh as standalone script ...................................................................... packaging: engine-encrypt-passwd.sh as standalone script If ENGINE_CONFIG_IGNORE is set do not read configuration, this is useful within installation phase, in which we do not have config yet. Change-Id: I7b748fc787d44b2e877412f3107719d607b7a4ae Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-encrypt-passwd.sh 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b748fc787d44b2e877412f3107719d607b7a4ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: cleanup: fixed pyflakes errors
by juan.hernandez＠redhat.com 14 Mar '13

14 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: cleanup: fixed pyflakes errors ...................................................................... cleanup: fixed pyflakes errors Fixed violations detected by jenkins: http://jenkins.ovirt.org/view/ovirt_engine/job/ovirt_engine_pep8_gerrit/2/v… Change-Id: Iccbe471a023eadc28fc2041c383a6a96eaca5653 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine_firewalld.py M packaging/fedora/setup/ovirt_port80.py M packaging/fedora/setup/post_upgrade.py 3 files changed, 0 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iccbe471a023eadc28fc2041c383a6a96eaca5653 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: service: only verify engine user owned directorie...
by juan.hernandez＠redhat.com 14 Mar '13

14 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: service: only verify engine user owned directories owner ...................................................................... packaging: service: only verify engine user owned directories owner In development mode directories will not be owned by root. Change-Id: I9132c5e620fcc95b5b92bb9af4a1c33a9c959215 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9132c5e620fcc95b5b92bb9af4a1c33a9c959215 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: service: do not use users from configuration if n...
by juan.hernandez＠redhat.com 14 Mar '13

14 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: service: do not use users from configuration if non-root ...................................................................... packaging: service: do not use users from configuration if non-root Change-Id: Ic28aaae513b1dcde2d18cbae12f8ac35a341b466 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 16 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic28aaae513b1dcde2d18cbae12f8ac35a341b466 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in otopi[master]: java: do not fail set environment with null
by Alon Bar-Lev 14 Mar '13

14 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: java: do not fail set environment with null ...................................................................... java: do not fail set environment with null Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/java/MachineDialogParser.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icda678d448bcf4d241782e08b2e6c067da3b4790 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: do not write to dbscripts after installation
by emesika＠redhat.com 13 Mar '13

13 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: db: do not write to dbscripts after installation ...................................................................... db: do not write to dbscripts after installation Writing to /usr is not allowed not via package manager. Change-Id: Ic7e9f477c94047176ab5c4406cea1275af68376d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7e9f477c94047176ab5c4406cea1275af68376d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change default doc path.
by ecohen＠redhat.com 13 Mar '13

13 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Change default doc path. ...................................................................... webadmin: Change default doc path. The standart directory for docs is - /usr/share/doc. We need to deploy docs content there as well. Change-Id: I6343b83cfae3207235b85e41fd66163b0cf3a1e8 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882284 --- M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kiril Nesenko: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6343b83cfae3207235b85e41fd66163b0cf3a1e8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: use group name for re
by Alon Bar-Lev 13 Mar '13

13 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: use group name for re ...................................................................... vdsm: bridge: use group name for re Change-Id: I3a0de2adc49dfef1a44079a91fca2f49f9e2c185 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/bridge.py 1 file changed, 19 insertions(+), 42 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a0de2adc49dfef1a44079a91fca2f49f9e2c185 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: network: use group name for re
by Alon Bar-Lev 13 Mar '13

13 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: network: use group name for re ...................................................................... network: use group name for re Change-Id: I54547e598c9d9d82ed615d30a9d0ff704b9df4ed Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/network/hostname.py M src/plugins/otopi/network/ssh.py 2 files changed, 13 insertions(+), 22 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54547e598c9d9d82ed615d30a9d0ff704b9df4ed Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: TestAuditLoggableBase serial warning
by amureini＠redhat.com 13 Mar '13

13 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: TestAuditLoggableBase serial warning ...................................................................... core: TestAuditLoggableBase serial warning Suppressed the serial warning on TestAuditLoggableBase. It is just a test class, and will never be serialized or deserialized. Change-Id: Ic88229b7c147bbcd59d6c88a924d81603dcf18b3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic88229b7c147bbcd59d6c88a924d81603dcf18b3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0