March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: AuditLogableBaseTest synthetic access
by amureini＠redhat.com 13 Mar '13

13 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AuditLogableBaseTest synthetic access ...................................................................... core: AuditLogableBaseTest synthetic access Changed private members to protected to solve synthetic-access warnings. This patch contributes to the code cleanliness (less warnings) and may also grant a (very) minor performance boost. Change-Id: I9c238908055e3ee864567233dc145987bced8ba6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c238908055e3ee864567233dc145987bced8ba6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: About dialog - remove redundant code
by derez＠redhat.com 13 Mar '13

13 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: About dialog - remove redundant code ...................................................................... webadmin: About dialog - remove redundant code Removing dead code from AboutModel/AboutPopup. Change-Id: I82e99e5b48866be7c40d5085195eea3298de36aa Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/AboutModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java 5 files changed, 2 insertions(+), 324 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82e99e5b48866be7c40d5085195eea3298de36aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Make Template dialog - style modifications
by derez＠redhat.com 13 Mar '13

13 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Make Template dialog - style modifications ...................................................................... webadmin: Make Template dialog - style modifications Make Template dialog: * Fixed TemplatePublicEditor overlapping disk list. * Moved messagePanel into a ScrollPanel (for handling long messages). Change-Id: I92415bc120b10a92712d554d2697a3831552c7b3 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 3 files changed, 11 insertions(+), 19 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92415bc120b10a92712d554d2697a3831552c7b3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Attach disk - verify valid selection
by derez＠redhat.com 13 Mar '13

13 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Attach disk - verify valid selection ...................................................................... webadmin: Attach disk - verify valid selection Fix validation that at least one disk is selected on attach disk. Change-Id: Idde1f85c3b1a8d31fc6a5ddd6591f493dc113b3d Bug-Url: https://bugzilla.redhat.com/879218 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idde1f85c3b1a8d31fc6a5ddd6591f493dc113b3d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Making all internal actions to have same correlation...
by mkublin＠redhat.com 13 Mar '13

13 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Making all internal actions to have same correlationId ...................................................................... engine: Making all internal actions to have same correlationId The following patch will force all internal actions to have same correlationId. When an action triggered from gui or rest client, it should pass a correlationId otherwise it will be automaticly generated. But, if action has some another internal actions they will have different correlationId. This patch will fix a problem. Discovered during work on provided bug Change-Id: I47ad8e04452b7f0e3f5f8477f84bc6b22e35ec98 Bug-Url: https://bugzilla.redhat.com/844335 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47ad8e04452b7f0e3f5f8477f84bc6b22e35ec98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVmCommand map iteration
by amureini＠redhat.com 13 Mar '13

13 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVmCommand map iteration ...................................................................... core: ImportVmCommand map iteration Iterated over the map's values() instead of over its keySet() for better performance. Change-Id: Iad2eb6462b3aa0ecb514e84841291628d12935b9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad2eb6462b3aa0ecb514e84841291628d12935b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: VM Linux Boot options aren't parsing properly
by tjelinek＠redhat.com 13 Mar '13

13 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: VM Linux Boot options aren't parsing properly ...................................................................... frontend: VM Linux Boot options aren't parsing properly - added checking Linux Boot options in the Run Once dialog. - slightly refactored validity checking to improve code readibility - also fixed the error when the invalidity messages in "kernel params" and "initrd path" fields weren't displayed (caused by setting invalidity flag before setting invalidity message) Change-Id: I23bd3ee3677c9bdbfacf1cf341dc1d97fd57c65e Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=872178 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 4 files changed, 58 insertions(+), 118 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23bd3ee3677c9bdbfacf1cf341dc1d97fd57c65e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools : Update format of SpiceSecureChannels to "channel" fr...
by yzaslavs＠redhat.com 13 Mar '13

13 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools : Update format of SpiceSecureChannels to "channel" from "schannel" ...................................................................... tools : Update format of SpiceSecureChannels to "channel" from "schannel" Update format of SpiceSecureChannels to "channel" from "schannel". "schannel" (like smain, sinputs etc) is a leftover from qspice 0.3.x from RHEL 5 days, since at least spice 0.6 (maybe even 0.4 from RHEL 6.0), the format is changed to "channel" (main, inputs etc). Change-Id: I87d4d3ee58e7730cc8243b313a220f49621e195a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=803666 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/src/main/conf/engine-config.properties 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87d4d3ee58e7730cc8243b313a220f49621e195a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: canDoAction msg of locked disk being removed
by mkublin＠redhat.com 13 Mar '13

13 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: core: canDoAction msg of locked disk being removed ...................................................................... core: canDoAction msg of locked disk being removed Change the can-do-action message which is attached to locks that are taken when removing disk in order to make it more informative than the default generic message that is being returned when those locks can't be acquired. This change of the can-do-action message allows us not to pass the locks from RemoveDiskCommand to RemoveImageCommand - as those locks can remain until the end of the execution of RemoveDiskCommand, there's no hurry to free them anymore. Change-Id: Ib20a2be29d01c04497473d168e7abbe7d1bf2db8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 25 insertions(+), 9 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib20a2be29d01c04497473d168e7abbe7d1bf2db8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: db: execute privileged upgrade operation only if required
by emesika＠redhat.com 13 Mar '13

13 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: db: execute privileged upgrade operation only if required ...................................................................... db: execute privileged upgrade operation only if required Having a privileged user during installation should be avoided. But in this case it is required due to legacy, so avoid if we can. Change-Id: I66da7066b26e9aa18df75e4a36e520c495a5880f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12949 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66da7066b26e9aa18df75e4a36e520c495a5880f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0