March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: etl: fixed statistics engine validity checks (#913384)
by ydary＠redhat.com 13 Mar '13

13 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed statistics engine validity checks (#913384) ...................................................................... etl: fixed statistics engine validity checks (#913384) Bug-Url: https://bugzilla.redhat.com/913384 Change-Id: I4263d44a7d44dc2ff7451aa77a2f9ec573d8a914 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/context_files/ovirt_engine_dwh/historyetl_3_2/contexts/Default.properties M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_2/HistoryETL.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_2/ParallelRun.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_2/SampleTimeKeepingJob.java M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.item M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.2.properties M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.item M data-warehouse/history_etl/tos_project/process/HistoryETL_3.2.properties M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.item M data-warehouse/history_etl/tos_project/process/ParallelRun_3.2.properties M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.item M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.2.properties M packaging/ovirt-engine-dwh-setup.py 13 files changed, 1,541 insertions(+), 1,509 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4263d44a7d44dc2ff7451aa77a2f9ec573d8a914 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: avoid NPE in VdsUpdateRunTimeInfo
by dfediuck＠redhat.com 13 Mar '13

13 Mar '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: avoid NPE in VdsUpdateRunTimeInfo ...................................................................... core: avoid NPE in VdsUpdateRunTimeInfo adding missing NPE check for wrapped primitive value stat.getusage_mem_percent() (Integer) Change-Id: I3e32a45ed326de475a38541f5834956148e03054 Bug-Url: https://bugzilla.redhat.com/920986 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e32a45ed326de475a38541f5834956148e03054 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fixed ChangeCD dialog on inactive ISO domain
by tjelinek＠redhat.com 13 Mar '13

13 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Fixed ChangeCD dialog on inactive ISO domain ...................................................................... engine: Fixed ChangeCD dialog on inactive ISO domain ChangeCD dialog no longer displays blank line which upon selection caused NullPointerException. Now the only available option when the ISO domain is unavailable is 'Eject'. Change-Id: I257e5f5fcfec0ab5c24dfaefa5c7f9330079141b Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=907506 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 5 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I257e5f5fcfec0ab5c24dfaefa5c7f9330079141b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: set correct entity id when importing template
by mlipchuk＠redhat.com 13 Mar '13

13 Mar '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: set correct entity id when importing template ...................................................................... core: set correct entity id when importing template When importing a template, the entity id should be set to the imported template id rather then the specific disk id, otherwise the end method will run as first disk finishes, but the import hasn't been done yet. Change-Id: I7b08c91bf3caf4faec0da9e10adf360dad16e2ac Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/12268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b08c91bf3caf4faec0da9e10adf360dad16e2ac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Guaranteed memory not propagated
by tjelinek＠redhat.com 13 Mar '13

13 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal, webadmin: Guaranteed memory not propagated ...................................................................... userportal, webadmin: Guaranteed memory not propagated Physical Memory Guaranteed parameter (min. allocated memory field) not propagated to new VM Pool/new VM from VM Template problem fixed. Current code doesn't store min. allocated memory of the template to the database and computes it using cluster settings (max_vds_memory_over_commit). Now the template min. allocated memory parameter value takes preference over default expression. Change-Id: I5b82e01d78de1eca585d6e11d326b0f842db52ae Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java 13 files changed, 84 insertions(+), 36 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b82e01d78de1eca585d6e11d326b0f842db52ae Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: hide VM sub-tab when selecting a gluster cluster
by kmayilsa＠redhat.com 13 Mar '13

13 Mar '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: hide VM sub-tab when selecting a gluster cluster ...................................................................... webadmin: hide VM sub-tab when selecting a gluster cluster 'Virtual Machines' sub-tab of Cluster will be shown only if the user selects a cluster which supports virt. Change-Id: I4057c7221510dc72bb7dd582ca6b2c9a42b01404 Bug-Url: https://bugzilla.redhat.com/920106 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4057c7221510dc72bb7dd582ca6b2c9a42b01404 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:[RFE] Improve power management proxy select..
by emesika＠redhat.com 13 Mar '13

13 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core:[RFE] Improve power management proxy select.. ...................................................................... core:[RFE] Improve power management proxy select.. [RFE] Improve power management proxy selection this patch resolves the following scenario: - cluster-1 - host-X - host-Y - cluster-2 - host-Z - Restart host-Y - succeed - Restart host-X - Fail: "General command validation failure." The patch does not consider a host as a proxy candidate if it is in the Reboot state Change-Id: I7a8178b0922365a456a6f3b09943f06f9ac6fc2d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a8178b0922365a456a6f3b09943f06f9ac6fc2d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean ShutdownVmCommand log messages
by rgolan＠redhat.com 13 Mar '13

13 Mar '13

Roy Golan has submitted this change and it was merged. Change subject: core: Clean ShutdownVmCommand log messages ...................................................................... core: Clean ShutdownVmCommand log messages These log messages are quite old, they still make references to VmHandler.cs. Change-Id: I9738c1aa1555da9c75f93b4062c25b94e528ed12 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9738c1aa1555da9c75f93b4062c25b94e528ed12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove "Red Hat" from description of VmInterfaceType...
by alkaplan＠redhat.com 13 Mar '13

13 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: remove "Red Hat" from description of VmInterfaceType enum values ...................................................................... engine: remove "Red Hat" from description of VmInterfaceType enum values Red Hat" notion should be removed from the GUI's VmInterfaceType translated values (Enums.properties) and from the enum's description which is used for audit logs. Change-Id: I7ce496c3afb9ecb95795d2edbb029316fa8a5c37 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmInterfaceType.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce496c3afb9ecb95795d2edbb029316fa8a5c37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Correlation id was not send to host - fixing it
by mkublin＠redhat.com 13 Mar '13

13 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Correlation id was not send to host - fixing it ...................................................................... engine: Correlation id was not send to host - fixing it The following patch should fix a bug with correlation id, which was not send to vdsm. In order to send it a correlation id should be kept inside internal callable. Change-Id: I45867ee8aea7a69ab9025a2ab2301d7cb9d74663 Bug-Url: https://bugzilla.redhat.com/844335 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java 1 file changed, 37 insertions(+), 12 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45867ee8aea7a69ab9025a2ab2301d7cb9d74663 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0