March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-log-collector[master]: tools: fixed --version output
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: tools: fixed --version output ...................................................................... tools: fixed --version output --version previously showed 1.0.0. Now it shows the package name and version as set in configure.ac. --local-tmp default value is now randomly generated using mkdtemp. The directory is cleaned up if -h, --version or --help where supplied avoiding to leave unwanted empty directories around. Moved some other constants to config.py using configure to set them. Change-Id: I88f53765028284221a0506efbc595b146a2bca8a Bug-Url: https://bugzilla.redhat.com/886052 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build/subst.inc M configure.ac M src/Makefile.am M src/__main__.py A src/config.py.in.in 5 files changed, 94 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Verified Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88f53765028284221a0506efbc595b146a2bca8a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: Added example to man page for -N option.
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: Added example to man page for -N option. ...................................................................... Added example to man page for -N option. Change-Id: I02d0a4defb248decf8464256befd94fcd3151e48 Bug-Url: https://bugzilla.redhat.com/887566 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/engine-image-uploader.8 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02d0a4defb248decf8464256befd94fcd3151e48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: cleanup: pep8 and pyflakes compliant
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: cleanup: pep8 and pyflakes compliant ...................................................................... cleanup: pep8 and pyflakes compliant Change-Id: I00d02ac9cddb9d3314a458fdc118cb3b63fb1774 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/helper/__init__.py M src/helper/hypervisors.py M src/sos/plugins/engine.py M src/sos/plugins/postgresql.py M src/tests.py 6 files changed, 675 insertions(+), 344 deletions(-) Approvals: Sandro Bonazzola: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00d02ac9cddb9d3314a458fdc118cb3b63fb1774 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: cleanup: pep8 compliant
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: cleanup: pep8 compliant ...................................................................... cleanup: pep8 compliant Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1c47d19ba75c7b681c132d6a5738448d9a5d5b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: disable stateless mode for diskless vm
by tjelinek＠redhat.com 12 Mar '13

12 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: disable stateless mode for diskless vm ...................................................................... frontend: disable stateless mode for diskless vm This patch disable the 'Run Stateless' check-box in the run-once dialog, in both webadmin and user portal, for diskless VM. Change-Id: I54a3c720edf863dcbc520ef41194d3816f9a0048 Bug-Url: https://bugzilla.redhat.com/907968 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 2 files changed, 21 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a3c720edf863dcbc520ef41194d3816f9a0048 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change Variable Name
by msalem＠redhat.com 12 Mar '13

12 Mar '13

Muli Salem has submitted this change and it was merged. Change subject: engine: Change Variable Name ...................................................................... engine: Change Variable Name This patch changes a variable name from networksInVdsByName to networksInClusterByName, according to what the list represents. Change-Id: I224265aeb35aeba22832a91e79b6ca8e66d01b1e Bug-Url: https://bugzilla.redhat.com/873338 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I224265aeb35aeba22832a91e79b6ca8e66d01b1e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding HotPlug to FeatureSupported
by msalem＠redhat.com 12 Mar '13

12 Mar '13

Muli Salem has submitted this change and it was merged. Change subject: core: Adding HotPlug to FeatureSupported ...................................................................... core: Adding HotPlug to FeatureSupported This patch adds the Hot Plug feature to the FeatureSupported class. Change-Id: I1efa16a90e2177d196ba9b8cd08d407865cfbfbb Bug-Url: https://bugzilla.redhat.com/873338 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1efa16a90e2177d196ba9b8cd08d407865cfbfbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: disk_image_dynamic statistics (#892596)
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: disk_image_dynamic statistics (#892596) ...................................................................... core: disk_image_dynamic statistics (#892596) vdsm sends disk statistics per disk, while disk_image_dynamic table contains disk_image ids (volumes). Hence the update on disk ids that VdsUpdateRunTimeInfo generates, actually does nothing. A quick fix for this problem is that VdsUpdateRunTimeInfo now updates by the AI id, so statistics are saved. Change-Id: I9f49238e3a725184ad2feb2d5ff06996e462d377 Bug-Url: https://bugzilla.redhat.com/892596 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f49238e3a725184ad2feb2d5ff06996e462d377 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cluster compatibility check for volume advanced de...
by kmayilsa＠redhat.com 12 Mar '13

12 Mar '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Cluster compatibility check for volume advanced details ...................................................................... webadmin: Cluster compatibility check for volume advanced details 1.Cluster Services sub-tab will be hidden if a cluster with compatibility version less than 3.2 is selected. 2.When clicking the Brick advanced details button, if the cluster comp version is less than 3.2, an error message will be shown. Change-Id: I6c4bf5e581facca0397bf02159b0e892630c2739 Bug-Url: https://bugzilla.redhat.com/920575 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 37 insertions(+), 2 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c4bf5e581facca0397bf02159b0e892630c2739 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Correct db script file numbering
by sanjal＠redhat.com 12 Mar '13

12 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Correct db script file numbering ...................................................................... engine: Correct db script file numbering Fixed conflict in db upgrade script - 03_02_0490_add_gluster_hooks_table.sql Change-Id: I3e40234f0a43bf943ef9cc2437dd45a4c226f0f5 Signed-off-by: Sahina Bose <sahina(a)gmail.com> --- R backend/manager/dbscripts/upgrade/03_02_0500_add_gluster_hooks_table.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12969 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e40234f0a43bf943ef9cc2437dd45a4c226f0f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0