March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Rename methods to start with small letter
by amureini＠redhat.com 31 Mar '13

31 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Rename methods to start with small letter ...................................................................... webadmin: Rename methods to start with small letter Rename private methods in StorageListModel to start with lowercase based on java standards Change-Id: I958edea764d7e6e4e785703f297a190b56c3aa23 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 42 insertions(+), 40 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/13317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I958edea764d7e6e4e785703f297a190b56c3aa23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add ability edit NFS path in webadmin
by amureini＠redhat.com 31 Mar '13

31 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add ability edit NFS path in webadmin ...................................................................... core: add ability edit NFS path in webadmin Add the option to edit NFS path and the overriden additional options of storage domain (retransmissions, timeout, version) in webadmin UI --> Storage tab. Editing these properties is available only when the storage domain is in maintenance status and is a data/master domain, and for storage of nfs type. These are the only properties which are editable in this status. Editing is still available for storage domains in status Active/Mixed, but only for name and description - like it was before this patch. Related-To:https://bugzilla.redhat.com/show_bug.cgi?id=835543 Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockMessagesMatchUtil.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 19 files changed, 750 insertions(+), 59 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Alissa Bonas: Verified -- To view, visit http://gerrit.ovirt.org/12372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: core: support overriding environment
by Alon Bar-Lev 31 Mar '13

31 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support overriding environment ...................................................................... core: support overriding environment rename conf suffix to env. Change-Id: I2c4f89abe087c8142cb664faa3846d7964a5daee Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/bin/ovirt-host-deploy.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c4f89abe087c8142cb664faa3846d7964a5daee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: post ovirt-log-collector-3.2.1
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: post ovirt-log-collector-3.2.1 ...................................................................... packaging: post ovirt-log-collector-3.2.1 Change-Id: I56480bdcb5af7a721125361f24210b95bb01646a Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56480bdcb5af7a721125361f24210b95bb01646a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: ovirt-log-collector-3.2.1
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: packaging: ovirt-log-collector-3.2.1 ...................................................................... packaging: ovirt-log-collector-3.2.1 Change-Id: Idc61b8f1ffb55eacb3a7794b70dc033eb16d8db3 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc61b8f1ffb55eacb3a7794b70dc033eb16d8db3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: Fixed set_hosts for handling correctly -H option
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Fixed set_hosts for handling correctly -H option ...................................................................... Fixed set_hosts for handling correctly -H option As stated in the method documentation each option set together is treated as an intersection. Previously -H caused an error when a host list was supplied due to a parameter passed with the wrong type to get_hypervisor_data. Change-Id: Ib9a99fc1e9bd49fbdcfcbdcb18dfddf6cd7e80e6 Bug-Url: https://bugzilla.redhat.com/918020 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 27 insertions(+), 31 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13475 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9a99fc1e9bd49fbdcfcbdcb18dfddf6cd7e80e6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: build: use embedded gettext
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: build: use embedded gettext ...................................................................... build: use embedded gettext there are too many variants of version within different distributions for us to support it externally Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-log-collector.spec.in 4 files changed, 5 insertions(+), 3 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in otopi[master]: core: support overriding environment
by Alon Bar-Lev 31 Mar '13

31 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support overriding environment ...................................................................... core: support overriding environment rename conf suffix to env. Change-Id: I15983d058e7f474943fdf64fd75bd83e9073879d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/bin/otopi 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15983d058e7f474943fdf64fd75bd83e9073879d Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: tools: fixed --version output
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: tools: fixed --version output ...................................................................... tools: fixed --version output --version previously showed 1.0.0. Now it shows the package name and version as set in configure.ac. --local-tmp default value is now randomly generated using mkdtemp. The directory is cleaned up if -h, --version or --help where supplied avoiding to leave unwanted empty directories around. Moved some other constants to config.py using configure to set them. Change-Id: I88f53765028284221a0506efbc595b146a2bca8a Bug-Url: https://bugzilla.redhat.com/886052 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A build/subst.inc M configure.ac M src/Makefile.am M src/__main__.py A src/config.py.in.in 5 files changed, 94 insertions(+), 20 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88f53765028284221a0506efbc595b146a2bca8a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: cleanup: pep8 and pyflakes compliant
by knesenko＠redhat.com 31 Mar '13

31 Mar '13

Kiril Nesenko has submitted this change and it was merged. Change subject: cleanup: pep8 and pyflakes compliant ...................................................................... cleanup: pep8 and pyflakes compliant Change-Id: I00d02ac9cddb9d3314a458fdc118cb3b63fb1774 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/helper/__init__.py M src/helper/hypervisors.py M src/sos/plugins/engine.py M src/sos/plugins/postgresql.py M src/tests.py 6 files changed, 675 insertions(+), 344 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00d02ac9cddb9d3314a458fdc118cb3b63fb1774 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0