March 2013 - Engine-commits - oVirt List Archives

Change in otopi[master]: packaging: yumpackger: do not attempt to use yum if running ...
by Alon Bar-Lev 21 Mar '13

21 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: yumpackger: do not attempt to use yum if running as non root ...................................................................... packaging: yumpackger: do not attempt to use yum if running as non root Change-Id: Id0ebb08313795c2135f5b75f9024f1f2a60cbd91 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/packagers/yumpackager.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0ebb08313795c2135f5b75f9024f1f2a60cbd91 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VMs from manual pool cannot be started
by ofrenkel＠redhat.com 21 Mar '13

21 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: VMs from manual pool cannot be started ...................................................................... engine: VMs from manual pool cannot be started A manual pool VM after shutdown cannot be started again problem fixed. Another check for RunVmCommand added, testing if the VM is part of a manual pool. In case stateless snapshots exist, they are not removed before the VM start. Change-Id: I41403c46811188989d3a6c42fec708c0780b0e20 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41403c46811188989d3a6c42fec708c0780b0e20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "tools : Update format of SpiceSecureChannels to "cha...
by yzaslavs＠redhat.com 21 Mar '13

21 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "tools : Update format of SpiceSecureChannels to "channel" from "schannel"" ...................................................................... Revert "tools : Update format of SpiceSecureChannels to "channel" from "schannel"" This reverts commit dd257404659875d44dfca7ce9b41ee93ecf73f84 This breaks 3.3 build. Should be revisited. --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/src/main/conf/engine-config.properties 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I445c3ff5d137ffa52bb2b1edafb4a2067e112982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Failure message popup window text unified
by vszocs＠redhat.com 21 Mar '13

21 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Failure message popup window text unified ...................................................................... webadmin: Failure message popup window text unified Failure messages for FrontendFailureEventListener and FrontendEventsHandlerImpl start with 'Error while executing action:'. E.g. if Run or RunOnce action fails, because no host is available, error dialog message starts with the same prefix. Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9 Bug-Url: https://bugzilla.redhat.com/908404 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: EnumUtils - used cached map if available
by amureini＠redhat.com 21 Mar '13

21 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: EnumUtils - used cached map if available ...................................................................... core: EnumUtils - used cached map if available Reuse the cached version of the uppercase map in EnumUtils if it already existed. This has two slight benefits: 1. Better memory management, by making sure we're reusing the same references all over. 2. It solves the normal priority FindBugs RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED warning on this issue. Change-Id: I486a09d190a2c02be666400c59795e7104f83d79 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/EnumUtils.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I486a09d190a2c02be666400c59795e7104f83d79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Use brick server for advanced details
by sanjal＠redhat.com 21 Mar '13

21 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Use brick server for advanced details ...................................................................... gluster: Use brick server for advanced details Currently, there is a bug in glusterfs, because of which the command 'gluster volume status' for a particular brick works properly only if it is executed on the server where the brick resides. While that bug gets fixed in glusterfs, I am changing the code here to make sure that we always execute the command on the brick's server (provided it is UP). Another refactoring done in this patch is to expect volume and brick IDs instead of names in GlusterVolumeAdvancedDetailsParameters Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a Bug-Url: https://bugzilla.redhat.com/877961 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeAdvancedDetailsParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/GlusterTestHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 11 files changed, 213 insertions(+), 129 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12979 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4acb0bbe84bacab714926d69b639bbda970df9a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Don't use console for debug log
by yzaslavs＠redhat.com 21 Mar '13

21 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Don't use console for debug log ...................................................................... tools: Don't use console for debug log Currently we use a console appender for the debug log level of the engine-config tool, this means that the debug messages are mixed with the regular output of the tool, and that confuses its users, including engine-setup and engine-manage-domains. This change introduces a new ToolConsole class for the tools. This class centralizes all input and output to the console and sends all the text to the log as well. The engine-config tool uses this new class for regular input and output. This change also removes the console appender from the log4j configuration and changes the default log level to DEBUG so that debug messages will be sent to the log as they used to be. Change-Id: I556e20f6333e22faeb7d212767ebefb99edce54e Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/conf/engine-config-log4j.xml.in M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/ToolConsole.java 8 files changed, 268 insertions(+), 101 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556e20f6333e22faeb7d212767ebefb99edce54e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: No need for gwt-plugin.extraJvmArgs in ...
by vszocs＠redhat.com 21 Mar '13

21 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: No need for gwt-plugin.extraJvmArgs in gwt-extension ...................................................................... webadmin,userportal: No need for gwt-plugin.extraJvmArgs in gwt-extension The "gwt-plugin.extraJvmArgs" property was recently moved to frontend parent POM, i.e. frontend/webadmin/modules/pom.xml Specific frontend modules don't need to override this property, its value can be inherited from frontend parent POM. In case of gwt-extension, this property isn't really necessary, since there's no GWT compilation involved when building this module. Change-Id: If3bc42f84e78a487d7c1ad10b82d466ca197fb90 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/pom.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3bc42f84e78a487d7c1ad10b82d466ca197fb90 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: move string messages to Messages class
by tjelinek＠redhat.com 21 Mar '13

21 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: move string messages to Messages class ...................................................................... frontend: move string messages to Messages class Move strings which are messages that are shown to the user from UserPortalListModel and VmListModel classes to Messages class. Change-Id: Ib35aff5e2238f109bf9beba5d7d198c9cb52ba59 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 17 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13206 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib35aff5e2238f109bf9beba5d7d198c9cb52ba59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Stopped using backup.sh script for DB backup
by juan.hernandez＠redhat.com 21 Mar '13

21 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Stopped using backup.sh script for DB backup ...................................................................... packaging: Stopped using backup.sh script for DB backup This patch replaces the usage of the backup.sh script for backing up the DB during upgrade/cleanup operations with the direct pg_dump command with same parameters. The reason for this is that the script itself delivered with a different package than the setup utilities, so its functionality is not available to the setup; this leads the setup to fail in various flows. Change-Id: Ic2b6f5c36e3005b5fdeeb3a5558414fe353d5e6e Bug-Url: https://bugzilla.redhat.com/920712 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py 2 files changed, 12 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2b6f5c36e3005b5fdeeb3a5558414fe353d5e6e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0