March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: Decouple AspectJ config from gwt-plugin...
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs ...................................................................... webadmin,userportal: Decouple AspectJ config from gwt-plugin.extraJvmArgs Some people might run into problems when trying to build WebAdmin or UserPortal (e.g. OutOfMemoryError) and therefore need to adjust gwt-maven-plugin JVM args. Overriding "gwt-plugin.extraJvmArgs" directly is not safe, as it also contains AspectJ load-time weaving configuration (used to prevent GWT compiler from pruning certain classes). This patch includes two changes: 1. Move AspectJ-related configuration out of "gwt-plugin.extraJvmArgs", directly into gwt-maven-plugin's extraJvmArgs config element. 2. Increase MaxPermSize from 256M to 512M With this patch, people should be able to override "gwt-plugin.extraJvmArgs" directly, without having to edit pom.xml file. Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1761efcec5197121ca97fca3a7f56aa5f1718495 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix VM/Template General form
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix VM/Template General form ...................................................................... webadmin: Fix VM/Template General form This patch fixes the problem when VM/Template General form displays obsolete values ater doing VM/Template import. Change-Id: I8b8c43f355df85121d70eae60fab4c0f6b7575a8 Bug-Url: https://bugzilla.redhat.com/919672 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmGeneralModelForm.java 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b8c43f355df85121d70eae60fab4c0f6b7575a8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove maxTextLength for Users main tab columns
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Remove maxTextLength for Users main tab columns ...................................................................... webadmin: Remove maxTextLength for Users main tab columns In Users main tab, removed maxTextLength restriction for "User Name" and "Group" columns. Change-Id: I45348b826bc99fc1aba0059ae934a56c4b66177e Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45348b826bc99fc1aba0059ae934a56c4b66177e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix invalid CSS comment
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix invalid CSS comment ...................................................................... webadmin,userportal: Fix invalid CSS comment CSS comments should follow /* Comment */ syntax. Even though GWT compliation passes with HTML-like comments in CSS, we should use proper comment syntax. Change-Id: I6bba8093c8f924f4ad9a3b341bebc3ffcf94882c Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bba8093c8f924f4ad9a3b341bebc3ffcf94882c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix FindBugs warning in ImportVmModel
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix FindBugs warning in ImportVmModel ...................................................................... webadmin: Fix FindBugs warning in ImportVmModel In ImportVmModel.init() method, 'dataCenter' reference variable can theoretically be null, which triggers FindBugs warning "Possible null pointer dereference". This patch fixes the above mentioned warning. Change-Id: Ib0b452b0a998068250dc4431f1f57346f7888000 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 34 insertions(+), 32 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b452b0a998068250dc4431f1f57346f7888000 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Fix FindBugs warning in AbstractActionT...
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Fix FindBugs warning in AbstractActionTable ...................................................................... webadmin,userportal: Fix FindBugs warning in AbstractActionTable FindBugs reports a false-positive "impossible cast" warning in AbstractActionTable.getTableHeaderCells() method, since CellTable.getElement() method always returns TableElement at runtime. This patch fixes the above mentioned warning. Change-Id: Id53a2306d8d737c42f24d9093899a764319b0c2b Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id53a2306d8d737c42f24d9093899a764319b0c2b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added pt_BR to locales list (#918075)
by ydary＠redhat.com 19 Mar '13

19 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added pt_BR to locales list (#918075) ...................................................................... reports: added pt_BR to locales list (#918075) Bug-Url: https://bugzilla.redhat.com/918075 Change-Id: I7f91af37264b511d1e84277b68b39c22a89103ab Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A server-customizations/WEB-INF/applicationContext-security.xml 1 file changed, 800 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f91af37264b511d1e84277b68b39c22a89103ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: removed unneeded engine parameter change
by ydary＠redhat.com 19 Mar '13

19 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: removed unneeded engine parameter change ...................................................................... packaging: removed unneeded engine parameter change Change-Id: If21a05cb3acbfc24c3fed1acf9fbc33dc19d644b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/50-ovirt-engine-reports.conf 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If21a05cb3acbfc24c3fed1acf9fbc33dc19d644b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Use X-UA-Compatible with IE=edge
by vszocs＠redhat.com 19 Mar '13

19 Mar '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Use X-UA-Compatible with IE=edge ...................................................................... webadmin,userportal: Use X-UA-Compatible with IE=edge There might be cases when WebAdmin or UserPortal web page is rendered in Compatibility Mode in Internet Explorer, instead of using Standards Mode. For example, the user might use "Compatibility View Settings" dialog to control which pages are rendered in Compatibility Mode. However, both applications depend on Standards Mode, as indicated by using HTML5 doctype declaration: <!DOCTYPE html> Trying to render both applications in anything other than Standards Mode will break (mess up) the entire UI. This patch is meant to override custom Compatibility Mode settings in Internet Explorer via X-UA-Compatible meta-tag, forcing Internet Explorer to render both applications in Standards Mode. Note 1: 'edge' causes Internet Explorer to use highest Standards Mode (HTML5/CSS3/etc.) available. Note 2: meta-tag isn't closed via '/>' since HTML5 defines this tag as 'void element' which doesn't need to be closed (closing tag is just redundant). Change-Id: Id22d27cf6e35a6253d9b00eadf4b519847711d17 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id22d27cf6e35a6253d9b00eadf4b519847711d17 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable 'Reset All' when volume options empty
by kmayilsa＠redhat.com 19 Mar '13

19 Mar '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Disable 'Reset All' when volume options empty ...................................................................... webadmin: Disable 'Reset All' when volume options empty 'Reset All' action in the Volume options sub-tab should be disabled if there are no options set for the selected volume. Change-Id: Ib4b21a9307ef1c2cb6d491bdcc636a8a3cbec6c0 Bug-Url: https://bugzilla.redhat.com/918441 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4b21a9307ef1c2cb6d491bdcc636a8a3cbec6c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0