March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: use conf.d notation for setup settings
by juan.hernandez＠redhat.com 19 Mar '13

19 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use conf.d notation for setup settings ...................................................................... packaging: use conf.d notation for setup settings Currently we store setup generated file at /etc/sysconfig/ovirt-engine, this makes it difficult to manage as user may edit the file as-well. The service supports /etc/sysconfig/ovirt-engine.d, so we can leverage this and store setup generated configurations. User can override these at files with higher index. Change-Id: Ib05f8c3b21c2b1146bda5b257e347a91d0521bce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py 3 files changed, 51 insertions(+), 31 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib05f8c3b21c2b1146bda5b257e347a91d0521bce Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added Bond constructor by name
by masayag＠redhat.com 19 Mar '13

19 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Added Bond constructor by name ...................................................................... core: Added Bond constructor by name Added a constructor that accepts as parameter only the bond name. Change-Id: Ic02ffc6e29a15836a7b8f53ad06ecd59cf9f527a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic02ffc6e29a15836a7b8f53ad06ecd59cf9f527a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Changed Bond constructor for backwards compatibility
by masayag＠redhat.com 19 Mar '13

19 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Changed Bond constructor for backwards compatibility ...................................................................... core: Changed Bond constructor for backwards compatibility Before the Bond subclass was implemented, the old way to check whether a VdsNetworkInterface was to check the value of its "bonded" field. This is now preserved, so that any Bond object would still comply with older code. Change-Id: I93d970df3fe1e22e8116d0b5683e82851037f6c8 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12530 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93d970df3fe1e22e8116d0b5683e82851037f6c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: updated executing backupDB function
by juan.hernandez＠redhat.com 19 Mar '13

19 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: updated executing backupDB function ...................................................................... packaging: updated executing backupDB function Calling backupDB function from the setup flow was incorrect. This patch fixes that behavior by supplying named parameters to the function and making sure that all the parameters are correct. Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Bug-Url: https://bugzilla.redhat.com/913176 Signed-off-by: Alex Lourie <alourie(a)redhat.com> (cherry picked from commit b8928be5aac72a7267023a66e19e9972341bf2e8) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: packaging: Fixed creating objects in an insecure way
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: packaging: Fixed creating objects in an insecure way ...................................................................... packaging: Fixed creating objects in an insecure way This patch is using a 'validate_cert_chain' flag instead of 'insecure' flag in the ovirt API during creation of non-secure objects. Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5 Bug-Url: https://bugzilla.redhat.com/886525 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M ovirt-iso-uploader.spec.in M src/__main__.py 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: config: support conf.d notation for configuration
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: config: support conf.d notation for configuration ...................................................................... config: support conf.d notation for configuration Read the config file and all config files within the .d directory sorted by name. It will make the configuration of the package simpler during installation of 3rd party packages. Change-Id: I702336baaf0258f2ee40069889f7c3a0764a664e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/__main__.py 1 file changed, 26 insertions(+), 9 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I702336baaf0258f2ee40069889f7c3a0764a664e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: config: support conf.d notation for configuration
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: config: support conf.d notation for configuration ...................................................................... config: support conf.d notation for configuration Read the config file and all config files within the .d directory sorted by name. It will make the configuration of the package simpler during installation of 3rd party packages. Change-Id: I09219762a7f548f41c58547e463153ea25f13034 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/__main__.py 1 file changed, 29 insertions(+), 10 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09219762a7f548f41c58547e463153ea25f13034 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: config: support conf.d notation for configuration
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: config: support conf.d notation for configuration ...................................................................... config: support conf.d notation for configuration Read the config file and all config files within the .d directory sorted by name. It will make the configuration of the package simpler during installation of 3rd party packages. Change-Id: I16837ce0cf5877f760521797821722520b9928f5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/__main__.py 1 file changed, 22 insertions(+), 7 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16837ce0cf5877f760521797821722520b9928f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: cleanup: update .gitignore
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: cleanup: update .gitignore ...................................................................... cleanup: update .gitignore Change-Id: If42ce8d6e2106c529576aa6171a0f57364e14869 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42ce8d6e2106c529576aa6171a0f57364e14869 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: use embedded gettext
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: build: use embedded gettext ...................................................................... build: use embedded gettext there are too many variants of version within different distributions for us to support it externally Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-log-collector.spec.in 4 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6c05b7a6f9aa177ddf572eac98f104e6bef605 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0