March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-image-uploader[master]: build: use embedded gettext
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: build: use embedded gettext ...................................................................... build: use embedded gettext there are too many variants of version within different distributions for us to support it externally Change-Id: I272e4f0fe58cadf8742ac8a87d77bc560b5d12f4 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-image-uploader.spec.in 4 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I272e4f0fe58cadf8742ac8a87d77bc560b5d12f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: use embedded gettext
by kroberts＠redhat.com 18 Mar '13

18 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: build: use embedded gettext ...................................................................... build: use embedded gettext there are too many variants of version within different distributions for us to support it externally Change-Id: Iedf5d59e18c82c792258d03fdef6bf14fb28c4f2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-iso-uploader.spec.in 4 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedf5d59e18c82c792258d03fdef6bf14fb28c4f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in otopi[master]: core: config: clenaup: use glob instead of listdir
by Alon Bar-Lev 18 Mar '13

18 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: config: clenaup: use glob instead of listdir ...................................................................... core: config: clenaup: use glob instead of listdir Change-Id: Ia11f738e1b58d717e91b84483b1a96cb0bbc94e8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/core/config.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia11f738e1b58d717e91b84483b1a96cb0bbc94e8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: doc: environment: document reboot and clock
by Alon Bar-Lev 18 Mar '13

18 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: environment: document reboot and clock ...................................................................... doc: environment: document reboot and clock Change-Id: Ib00da4f17051f9472c5a320aeccb688698216430 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.environment 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib00da4f17051f9472c5a320aeccb688698216430 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fixed sorting in Cluster and Datacenter Networks s...
by alkaplan＠redhat.com 18 Mar '13

18 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fixed sorting in Cluster and Datacenter Networks subtabs ...................................................................... webadmin: Fixed sorting in Cluster and Datacenter Networks subtabs Sorting now treats numeric subsequences in network names as such. Also fixed minor (unreported) bug having to do with sorting in the assign/unassign networks popup window. Change-Id: I8432b61ae79195a454eec50e5322182103f02527 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=920209 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java 3 files changed, 44 insertions(+), 21 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8432b61ae79195a454eec50e5322182103f02527 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused GetDisksForQuotaIdQuery
by amureini＠redhat.com 18 Mar '13

18 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused GetDisksForQuotaIdQuery ...................................................................... core: Remove unused GetDisksForQuotaIdQuery GetDisksForQuotaIdQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetDisksForQuotaIdQuery class 2. The GetDisksForQuotaIdParameters class used by said query 3. The GetDisksForQuotaId constant representing it in VdcQueryType 4. The getAllForQuotaId(Guid) method in DiskImageDAO (which was only used by the query), its implementation, and its test. 5. The GetImagesByQuotaId(UUID) stored procedure that was only used by the said DAO function. Change-Id: I77f8c0a54fbcdc150234888d73a941088376ef3e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDisksForQuotaIdQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDisksByQuotaIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 7 files changed, 0 insertions(+), 77 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77f8c0a54fbcdc150234888d73a941088376ef3e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in otopi[master]: services: cleanup: fix debug message
by Alon Bar-Lev 18 Mar '13

18 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: services: cleanup: fix debug message ...................................................................... services: cleanup: fix debug message Change-Id: I2151f08b41b6fecd623ff302cca4b33a61e34ae9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/services/openrc.py M src/plugins/otopi/services/rhel.py M src/plugins/otopi/services/systemd.py 3 files changed, 15 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2151f08b41b6fecd623ff302cca4b33a61e34ae9 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Added ports in gluster iptables config
by sanjal＠redhat.com 18 Mar '13

18 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Added ports in gluster iptables config ...................................................................... gluster: Added ports in gluster iptables config Ports required for GlusterFS brick processes have changed in glusterfs 3.4.0 from 24009 onwards to 49152 onwards. This patch adds these new ports in the IPTables configuration for glusterfs. The old ones are also left open for backward compatibility with older gluster servers. Change-Id: I414bce7daaf473e25e0cf643f5bc4883bcda7085 Bug-Url: https://bugzilla.redhat.com/906314 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I414bce7daaf473e25e0cf643f5bc4883bcda7085 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Vijay Bellur <vbellur(a)gmail.com>

1 0

Change in ovirt-engine[master]: core: Cannot confirm Host has been rebooted when..
by emesika＠redhat.com 18 Mar '13

18 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Cannot confirm Host has been rebooted when.. ...................................................................... core: Cannot confirm Host has been rebooted when.. Cannot confirm Host has been rebooted when having a single host in the system. This patch removes the SPM Host mark in the DC in case that Host is non-responsive and is the only Host in the DC. This enables to put the Host in Maintenance and remove it if needed. Two scenarios tested 1) Making the Host responsive again => Host is SPM back 2) Adding another Host => New Host is SPM This patch is not handling the case in which the problematic Host has running VMs, only the scenario reported in the BZ was handled Change-Id: I8264d91d6dc5f33e4684d3bef86624b6f424a64b Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=837539 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8264d91d6dc5f33e4684d3bef86624b6f424a64b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix brick advanced details close button
by kmayilsa＠redhat.com 18 Mar '13

18 Mar '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Fix brick advanced details close button ...................................................................... webadmin: Fix brick advanced details close button Brick advanced details popup's close button was not working, this is fixed now. Change-Id: Id946d396e22822fa9b0eb094ec36ba73b54d0220 Bug-Url: https://bugzilla.redhat.com/919402 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id946d396e22822fa9b0eb094ec36ba73b54d0220 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0