March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core:SPM role should not be granted to Gluster only nodes
by sanjal＠redhat.com 12 Mar '13

12 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: core:SPM role should not be granted to Gluster only nodes ...................................................................... core:SPM role should not be granted to Gluster only nodes In a DC with gluster cluster and vdsm cluster, if the hypervisor node with SPM role goes down, the SPM role should not be granted to a gluster node. Changed the function GetUpAndPrioritizedVds to check if virt_service is true on the VDS. Change-Id: I6054ba6ad9864798b5d914659f39edaf884e2215 Signed-off-by: Sahina Bose <sahina(a)gmail.com> --- M backend/manager/dbscripts/vds_sp.sql 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6054ba6ad9864798b5d914659f39edaf884e2215 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Manage Gluster hooks support
by sanjal＠redhat.com 12 Mar '13

12 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Manage Gluster hooks support ...................................................................... engine: Manage Gluster hooks support This patch adds the database tables and stored procs to manage gluster hooks.The associated Java entity classes and DAO classes are added as part of this patch. For each cluster, the list of available hooks are stored in the database. Under cluster, a hooks tab will be provided to manage these. The hooks table stores a status field which indicates if the hooks are in sync across all servers. This is a 3 bit representation with each bit indicating the conflict type - status conflict/content conflict/missing Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> Signed-off-by: Sahina Bose <sahina(a)gmail.com> --- A backend/manager/dbscripts/gluster_hooks_sp.sql A backend/manager/dbscripts/upgrade/03_02_0490_add_gluster_hooks_table.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHooksQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterHooksQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookConflictFlags.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookContentType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookStage.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookStatus.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerHook.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 21 files changed, 1,516 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmCommand: Shared disk boot status
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmCommand: Shared disk boot status ...................................................................... core: UpdateVmCommand: Shared disk boot status Check the boot status of a disk against all the VMs it's attached to, not only the one its context is edited in. Change-Id: I6a9d2e8800b9bf693fc55d8a627e0725277985ac Bug-Url: https://bugzilla.redhat.com/854964 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 90 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a9d2e8800b9bf693fc55d8a627e0725277985ac Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand: remove DbFacade calls
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand: remove DbFacade calls ...................................................................... core: UpdateVmDiskCommand: remove DbFacade calls Replaced DbFacade.getXXXDao() calls with getXXDao() calls for better readability and testability. Wherever appropriate, these getXXDao methods were applied to AbstractDiskVmCommand. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: Id31bc1234ed109f9cb1ae658572b4b2e67c6f6ee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 3 files changed, 6 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id31bc1234ed109f9cb1ae658572b4b2e67c6f6ee Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Vnics statistics are not shown for VM unless VNIC ...
by alkaplan＠redhat.com 12 Mar '13

12 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Vnics statistics are not shown for VM unless VNIC is selected ...................................................................... webadmin: Vnics statistics are not shown for VM unless VNIC is selected When the subtab is opened, the first VNIC will be auto-selected, so that its statistics is shown. Change-Id: I6fbb3ed760bbd6cf2821073a688b7bdda85aa064 Bug-Url: https://bugzilla.redhat.com/915778 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fbb3ed760bbd6cf2821073a688b7bdda85aa064 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup AttachDiskToVmCommand.canDoAction()
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Cleanup AttachDiskToVmCommand.canDoAction() ...................................................................... core: Cleanup AttachDiskToVmCommand.canDoAction() Made the canDoAction() more readable by removing the lock checks (should be handled by the CommandBase infra using @LockiIdNameAttribute) and employing the early-return idiom. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I6cb0cc87c82387e8b1dcac0142f3625a4cc232d2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 1 file changed, 28 insertions(+), 29 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cb0cc87c82387e8b1dcac0142f3625a4cc232d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDisk: unify other disk retrieval
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDisk: unify other disk retrieval ...................................................................... core: UpdateVmDisk: unify other disk retrieval Several validations in the canDoAction() rely on getting the VM's other disks from the database, which is unfortunately done in the said several places. This patch unifies them all to a lazy getter, getOtherVmDisks() for better performance and readability. Besides the code change, it also introduces a couple of new unit tests to ensure that no functionality was damaged. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I31bcb767bf86d6f16116cfa06a710bb0488b087f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 2 files changed, 75 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31bcb767bf86d6f16116cfa06a710bb0488b087f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommandTest.cretaeVirtIODisk
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommandTest.cretaeVirtIODisk ...................................................................... core: UpdateVmDiskCommandTest.cretaeVirtIODisk Removed the unused method in the subject. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I26220721869b786be5eb30521914c6d934a485d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26220721869b786be5eb30521914c6d934a485d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand - synthetic access warn
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand - synthetic access warn ...................................................................... core: UpdateVmDiskCommand - synthetic access warn Changed modifiers from private to protected to avoid synthetic access warnings. This may also result in a slight performance improvements, but I doubt it would be noticeable. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I07ed8b37f4c22807b8981959b7b03d7baa19de68 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ed8b37f4c22807b8981959b7b03d7baa19de68 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Cleanup AbstractDisk.isDiskCanBeAddedToVm ...................................................................... core: Cleanup AbstractDisk.isDiskCanBeAddedToVm Extracted the updateDisksFromDb() method from isDiskCanBeAddedToVm() method for better encapsulation, and employed the early-return idiom for better readability. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java 3 files changed, 13 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7e5aafada5012ae06c7105bafa5538026e42b1b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0