March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UpdateDiskToVm: use isDiskCanBeAddedToVm
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: UpdateDiskToVm: use isDiskCanBeAddedToVm ...................................................................... core: UpdateDiskToVm: use isDiskCanBeAddedToVm Used AbstractDiskCommand's isDiskCanBeAddedToVm(Disk) instead of duplicating the same code. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: I6fef2259e2543fd47880a37dd8434838575db45b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fef2259e2543fd47880a37dd8434838575db45b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddDiskCommand.canDoAction() early return
by amureini＠redhat.com 12 Mar '13

12 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddDiskCommand.canDoAction() early return ...................................................................... core: AddDiskCommand.canDoAction() early return Made AddDiskCommand.canDoAction() slightly more readable using the early-return idiom. Relates-To: https://bugzilla.redhat.com/854964 Change-Id: Ib89b5008972e6cf895941d211cda5d7f8f14b5e1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 15 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib89b5008972e6cf895941d211cda5d7f8f14b5e1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Failures when trying to run stateless VM
by mkublin＠redhat.com 12 Mar '13

12 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Failures when trying to run stateless VM ...................................................................... engine: Failures when trying to run stateless VM The following bug was caused because of change in infrastracture of AsyncTaskManager, from now parameters are not kept and not duplicate on commands parameters. Such change cause problem in run stateless VM, in order to fix it RunVmCommand was updated accordingly Change-Id: I5a6b9c715bfcc692c98ac91cd33c84a5ebfaf22d Bug-Url: https://bugzilla.redhat.com/919842 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 17 insertions(+), 14 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a6b9c715bfcc692c98ac91cd33c84a5ebfaf22d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: Move plugin versions to plugingManagement
by juan.hernandez＠redhat.com 12 Mar '13

12 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: build: Move plugin versions to plugingManagement ...................................................................... build: Move plugin versions to plugingManagement This patch moves all the plugin versions to the <pluginManagement> block, where they belong. Change-Id: I7aaaf5c04bf80ca5848759f3a0ea038ef9c6be03 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 5 files changed, 4 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7aaaf5c04bf80ca5848759f3a0ea038ef9c6be03 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Prevent management network change
by masayag＠redhat.com 12 Mar '13

12 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Prevent management network change ...................................................................... engine: Prevent management network change The patch prevents changing the management network address if the host was added to the system with its IP address as the computer-name for the certification creation. The action is blocked in order to prevent connectivity loss from the engine to the host. The host should be reinstalled in order to modify the management network address. Change-Id: If98a5853385ad484dfa6e5392797f96daeaaa381 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 128 insertions(+), 8 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If98a5853385ad484dfa6e5392797f96daeaaa381 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: man page: fixed a word repetition
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: man page: fixed a word repetition ...................................................................... man page: fixed a word repetition Change-Id: I97ed210a016eb04f2b9c865a4aa75ec5c402800f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/engine-image-uploader.8 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97ed210a016eb04f2b9c865a4aa75ec5c402800f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: tools: fixed command line parser setup
by kroberts＠redhat.com 12 Mar '13

12 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: tools: fixed command line parser setup ...................................................................... tools: fixed command line parser setup The previous command line parser setup caused the rewrite of the database connection parameters read from .pgpass with the hardcoded defaults each time the command line was parsed. This caused a failure while collecting PostgreSQL database configuration when using a remote setup Now the script check if we have root permission, then read .pgpass setting the default values for the command line parser. In order to figure out what was happening, I added some logging to the __main__ module and to the posgresql sos plugin. Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9 Bug-Url: https://bugzilla.redhat.com/885421 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/sos/plugins/postgresql.py 2 files changed, 98 insertions(+), 70 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12729 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: Added logging of insufficient local space
by kroberts＠redhat.com 11 Mar '13

11 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: Added logging of insufficient local space ...................................................................... Added logging of insufficient local space When checking for space availability for decompressing the ovf file in a temporary directory, notify the user and log an error if there isn't enough space. Also fixed the return value of space_test_ovf when tarfile raises an exception and made space_test_ovf a static method. Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9742144ed5f28399908d2dde116d34d86b3f119 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: engine-log-collector - fix exit value on wrong password
by kroberts＠redhat.com 11 Mar '13

11 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: engine-log-collector - fix exit value on wrong password ...................................................................... engine-log-collector - fix exit value on wrong password Removed too early exception handling that caused an exit with a wrong exit code (0 instead of 2) when providing a wrong password. Change-Id: I6df67832c75ba073d73111a0861c9b6e8a6660ed Bug-Url: https://bugzilla.redhat.com/788993 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/helper/hypervisors.py 1 file changed, 24 insertions(+), 29 deletions(-) Approvals: Sandro Bonazzola: Verified Alex Lourie: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6df67832c75ba073d73111a0861c9b6e8a6660ed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: engine-iso-uploader - notify the user for started upload pro...
by kroberts＠redhat.com 11 Mar '13

11 Mar '13

Keith Robertson has submitted this change and it was merged. Change subject: engine-iso-uploader - notify the user for started upload process ...................................................................... engine-iso-uploader - notify the user for started upload process In upload_to_storage_domain notify the user that the upload process has started. Log also the starting of every upload, not only the completion. In upload_to_storage_domain fixed redefinition of built-in 'file' Change-Id: Id45632a662b12d8681dc99b2924105601a0e0d36 Bug-Url: https://bugzilla.redhat.com/785670 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 22 insertions(+), 20 deletions(-) Approvals: Sandro Bonazzola: Verified Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, but someone else must approve Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id45632a662b12d8681dc99b2924105601a0e0d36 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0