March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove FileUtil unneeded methods
by tnisan＠redhat.com 10 Mar '13

10 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove FileUtil unneeded methods ...................................................................... core: Remove FileUtil unneeded methods Remove the FileUtil unused methods and replace the ones used to standard implementation with Java File class Change-Id: Ia9aac66024e244bdbff52c3b7b86948a236ad0af Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/FileUtil.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/FileUtilTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 10 files changed, 77 insertions(+), 141 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9aac66024e244bdbff52c3b7b86948a236ad0af Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove CompatException class and it's usages
by tnisan＠redhat.com 10 Mar '13

10 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove CompatException class and it's usages ...................................................................... core: Remove CompatException class and it's usages Change-Id: I726e0f9e7fb0c9bff00b8d510dc3907d202e0fa2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetCACertificateQuery.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CompatException.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeSpan.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/TimeSpanTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/FileUtil.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Compat.gwt.xml M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/EnumCompat.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java 10 files changed, 21 insertions(+), 102 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I726e0f9e7fb0c9bff00b8d510dc3907d202e0fa2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove Path class from Compat module
by tnisan＠redhat.com 10 Mar '13

10 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove Path class from Compat module ...................................................................... core: Remove Path class from Compat module Removed the Path class from the Compat module Change-Id: I2a4a1e051050196de692ca76e1d1cd8e51b0c86d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeFloppyCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/Path.java D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PathTest.java 8 files changed, 15 insertions(+), 80 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a4a1e051050196de692ca76e1d1cd8e51b0c86d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: changed DejaVu Sans font to SansSerif family (#9014...
by ydary＠redhat.com 10 Mar '13

10 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: changed DejaVu Sans font to SansSerif family (#901418) ...................................................................... reports: changed DejaVu Sans font to SansSerif family (#901418) This is to fully support non latin fonts. Bug-Url: https://bugzilla.redhat.com/901418 Change-Id: Idce54abe8b0449b03db4b60eca38947490ede0ac Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/jars/ChartsCustomizers/src/main/java/com/ovirt/reports/jasper/ScatterChartCustomizer.java M reports/jars/ReportsLineBarChartTheme/src/main/resources/ReportsLineBarChartTheme.jrctx M reports/jars/ReportsPieChartTheme/src/main/resources/ReportsPieChartTheme.jrctx M reports/jars/WebadminLineBarChartTheme/src/main/resources/WebadminLineBarChartTheme.jrctx M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/datacenter_dashboard_files/dc_summary_of_cluster_hosts_resources_usage_dr27_jrxml.data 5 files changed, 12 insertions(+), 12 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idce54abe8b0449b03db4b60eca38947490ede0ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix Unlimited quota is counted as -1
by gchaplik＠redhat.com 10 Mar '13

10 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix Unlimited quota is counted as -1 ...................................................................... webadmin: Fix Unlimited quota is counted as -1 In the quota main tab, when using specific quota which includes at least one unlimited cluster/storage-domain, the unlimited quota is counted as -1 (the int value of the constant). Fixed calculation to ignore both the consumption and the allocation of unlimited quota. Change-Id: I7f49bfe3576cecccf80e9ad2105506e3eb267d83 Bug-Url: https://bugzilla.redhat.com/919088 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java 1 file changed, 24 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f49bfe3576cecccf80e9ad2105506e3eb267d83 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Do not show 'Linux boot options' for OS types - Unas...
by gchaplik＠redhat.com 10 Mar '13

10 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Do not show 'Linux boot options' for OS types - Unassigned, Other ...................................................................... engine: Do not show 'Linux boot options' for OS types - Unassigned, Other Linux boot options are now visible only for Linux OS types, not for Unassigned or Other. Also changed the name of related IsLinux_Unassign_UnknownOS property to IsLinuxOS since it is used exactly for the purpose of determining whether to show the Linux Boot Options or not. Change-Id: I107207f28575f097e2bdf9620bb63d51116a9515 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=909127 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 6 files changed, 30 insertions(+), 33 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I107207f28575f097e2bdf9620bb63d51116a9515 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change 'Required actions:' to 'Devices to configur...
by gchaplik＠redhat.com 10 Mar '13

10 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Change 'Required actions:' to 'Devices to configure:' ...................................................................... webadmin: Change 'Required actions:' to 'Devices to configure:' Changed text in webadmin's VM Guide Me dialog to reflect more common use case Change-Id: I2115b1dddbbd3f02b93a521634950e6bc3a690c3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912646 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2115b1dddbbd3f02b93a521634950e6bc3a690c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cleanup of AdElementListModel constructor
by gchaplik＠redhat.com 10 Mar '13

10 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Cleanup of AdElementListModel constructor ...................................................................... webadmin: Cleanup of AdElementListModel constructor Cleanup part of the bugfix patch Nested async call moved to be parallel as it was not dependent of its parent Async calls logic encapsulated from mid method anonymous class to its own method Improved variable names for readability Change-Id: Iacc5878f32f5b5395dd5a87a0614b4c3a21bf88d Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java 1 file changed, 48 insertions(+), 49 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacc5878f32f5b5395dd5a87a0614b4c3a21bf88d Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: noam slomianko <drekmastermind(a)gmail.com>

1 0

Change in ovirt-engine[master]: db: set LC_ALL="C" for all operations
by emesika＠redhat.com 10 Mar '13

10 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: db: set LC_ALL="C" for all operations ...................................................................... db: set LC_ALL="C" for all operations Change-Id: I4a9ea01e6f8e081bfb9adc4618341d4b691b82fa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a9ea01e6f8e081bfb9adc4618341d4b691b82fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: grayed-out LUNs reasons - modify check
by derez＠redhat.com 10 Mar '13

10 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: grayed-out LUNs reasons - modify check ...................................................................... webadmin: grayed-out LUNs reasons - modify check Verify that the selected LUN is not apart of a DirectLUN disk first; since a LUN for DirectLUN disk is grayed-out only if it's already apart of a Disk in the system. Change-Id: Ie5d044ed4a75182954bd4a01b5cb071f24da6bd1 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d044ed4a75182954bd4a01b5cb071f24da6bd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0