March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improve warning message for network without IP
by masayag＠redhat.com 10 Mar '13

10 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve warning message for network without IP ...................................................................... engine: Improve warning message for network without IP The message requires an improvement. Change-Id: Idfb1aef39b3fe149e724800198ca8cf36f9d562b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/12900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfb1aef39b3fe149e724800198ca8cf36f9d562b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Adjust setupNetworks message on tasks view
by masayag＠redhat.com 10 Mar '13

10 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adjust setupNetworks message on tasks view ...................................................................... engine: Adjust setupNetworks message on tasks view The previous message of setupNetworks was related to a specific network where this is not the case of setupNetworks which might handle several networks (or none). Change-Id: I33ebbc4541e57d41e60e6a05d6d83172ead35d00 Bug-Url: https://bugzilla.redhat.com/905175 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/12893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33ebbc4541e57d41e60e6a05d6d83172ead35d00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: System permissions tab don't update
by gchaplik＠redhat.com 10 Mar '13

10 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: System permissions tab don't update ...................................................................... webadmin: System permissions tab don't update System permissions tab doesnt update content on initialization and after a new user is added and displays the cached content until the refresh is called in afew seconds. This patch calls the refresh on the model each time a user is added or when the ConfigurePopupPresenterWidget is revealed. Change-Id: I04cb331ec9a1ac0868265353bcc387a202225821 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=861964 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/configure/ConfigurePopupPresenterWidget.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04cb331ec9a1ac0868265353bcc387a202225821 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix typo in word network
by iheim＠redhat.com 08 Mar '13

08 Mar '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix typo in word network ...................................................................... core: Fix typo in word network Fix typo in AppErrors.properties in word network Change-Id: I69114e2c4cf9fc1201668ad8ce7e48195f9b97d8 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69114e2c4cf9fc1201668ad8ce7e48195f9b97d8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: build: post ovirt-host-deploy-1.0.0
by Alon Bar-Lev 08 Mar '13

08 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.0.0 ...................................................................... build: post ovirt-host-deploy-1.0.0 Change-Id: Ic88ce1791ce6556c73580d9e97a163e6872a7f56 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12884 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic88ce1791ce6556c73580d9e97a163e6872a7f56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: build: post ovirt-host-deploy-1.0.0
by Alon Bar-Lev 08 Mar '13

08 Mar '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: build: post ovirt-host-deploy-1.0.0 ...................................................................... build: post ovirt-host-deploy-1.0.0 Change-Id: I10941b96e3de91c21eb569802fa35d701fc7fc12 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10941b96e3de91c21eb569802fa35d701fc7fc12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: fixed missing parameters in sql function call
by juan.hernandez＠redhat.com 08 Mar '13

08 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: fixed missing parameters in sql function call ...................................................................... packaging: fixed missing parameters in sql function call using the name of the storage domain as description when calling Insertstorage_domain_static. Change-Id: I101089ab1c7a678fe5050d0e2b1d673b16c9a2e1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M backend/manager/dbscripts/inst_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12881 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I101089ab1c7a678fe5050d0e2b1d673b16c9a2e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix brick validation during Add Bricks
by sanjal＠redhat.com 08 Mar '13

08 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Fix brick validation during Add Bricks ...................................................................... engine: Fix brick validation during Add Bricks While adding a new brick(s) to a volume, server_id and brick_directory combination will be validated against the entries in the gluster_volume_bricks table. If there are any existing entries found for the server:brick_dir, an error message will be thrown to the user. Introduced a new procedure to get a brick entity based on server_id and brick directory. Also an error message will be thrown if there any duplicate bricks found. Change-Id: I83ec15a183d81a274388c313006208d439809548 Bug-Url: https://bugzilla.redhat.com/856109 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 9 files changed, 89 insertions(+), 37 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/12612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ec15a183d81a274388c313006208d439809548 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-setup - add support for virtio-win >= 1.6....
by juan.hernandez＠redhat.com 08 Mar '13

08 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-setup - add support for virtio-win >= 1.6.3 ...................................................................... packaging: engine-setup - add support for virtio-win >= 1.6.3 virtio-win 1.6.3 reorganized the VFDs to be 32/64 bit. Added support for virtio-win >= 1.6.3 keeping the compatibility with the older versions. Change-Id: Ie2a538dd327bdd692acdc4e7324bd39890e5dccb Bug-Url: https://bugzilla.redhat.com/919204 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2a538dd327bdd692acdc4e7324bd39890e5dccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: TreeTable no items to display
by ecohen＠redhat.com 08 Mar '13

08 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: TreeTable no items to display ...................................................................... webadmin: TreeTable no items to display - Added 'No XX to Display' to tree tables. Where XX is the appropriate entity for the table. Change-Id: I508cf4c9ca61ceb58d4647d3074ae7638a8adcd6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=912258 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTreeView.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I508cf4c9ca61ceb58d4647d3074ae7638a8adcd6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0