March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fixing Materialized Views function signatures
by yzaslavs＠redhat.com 07 Mar '13

07 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fixing Materialized Views function signatures ...................................................................... core: fixing Materialized Views function signatures Adding missing signatures and fixing some that had redundant parameters. Change-Id: I7f3712a00cfb832eb1680bae446e5406fda0715b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/materialized_views_sp.sql 1 file changed, 40 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f3712a00cfb832eb1680bae446e5406fda0715b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: replaced dialog error icon
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: replaced dialog error icon ...................................................................... webadmin,userportal: replaced dialog error icon Replaced error dialog 'X' icon with '!' icon. Change-Id: I896696a09ea41779949e146c467d6782dc2f486d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/dialog/error.png 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I896696a09ea41779949e146c467d6782dc2f486d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eldan Hildesheim <info(a)eldanet.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: replaced close dialog icon
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: replaced close dialog icon ...................................................................... webadmin,userportal: replaced close dialog icon Replaced the close dialog 'X' icon. Change-Id: I0475b128d40f616592198cded8aeb19cce72a761 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close.png M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close_down.png M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/but_close_over.png 3 files changed, 0 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0475b128d40f616592198cded8aeb19cce72a761 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eldan Hildesheim <info(a)eldanet.com>

1 0

Change in ovirt-engine[master]: webadmin: Storage dialog - fix description width
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Storage dialog - fix description width ...................................................................... webadmin: Storage dialog - fix description width Storage dialog - fix the width of description field (looks broken in Chrome) Change-Id: I249315013a4cab2c35cd6ff8f4316df754a42720 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12585 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I249315013a4cab2c35cd6ff8f4316df754a42720 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Authentication error messages on the engine.
by emesika＠redhat.com 07 Mar '13

07 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Authentication error messages on the engine. ...................................................................... core: Authentication error messages on the engine. Authentication error messages on the engine.log should specify the user used Adding the user name used in all DirectorySearcher logged errors. Change-Id: Ia29947906a5e5aa905324fe90793ba14d86faf60 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia29947906a5e5aa905324fe90793ba14d86faf60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: double click invokes default command
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: double click invokes default command ...................................................................... webadmin: double click invokes default command - Added code to allow double click to invoke the default command, which in most cases is edit (grids/trees). Change-Id: I701036539547130a0c1581d179ad2f6de6519427 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionStackPanelItem.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 3 files changed, 71 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I701036539547130a0c1581d179ad2f6de6519427 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core:Upgrade - Error Can't start the ovirt-engine-dw...
by yzaslavs＠redhat.com 07 Mar '13

07 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" ...................................................................... Revert "core:Upgrade - Error Can't start the ovirt-engine-dwhd service" This reverts commit 0ac55fca677ecd9348d3f382ac8af9fd9b65b164 Reason : change caused DB deadlock of nested transactions attempting to update the same record --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/disk_image_dynamic_sp.sql M backend/manager/dbscripts/network_sp.sql D backend/manager/dbscripts/upgrade/03_02_0490_add_lastStatisticsUpdate_to_dwh_history_timekeeping.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vms_sp.sql 6 files changed, 0 insertions(+), 26 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee79b36e1aece45fe3dc15f3b164f1cbaf892f6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: red border for invalid widgets
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: red border for invalid widgets ...................................................................... webadmin,userportal: red border for invalid widgets Color invalid widgets in red (instead of orange) for a clearer indication. Change-Id: I3ba82344177d489fe1bb6a399829454b853bd897 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidget.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ba82344177d489fe1bb6a399829454b853bd897 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eldan Hildesheim <info(a)eldanet.com>

1 0

Change in ovirt-engine[master]: webadmin: use ValidatedPanelWidget where applicable
by derez＠redhat.com 07 Mar '13

07 Mar '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: use ValidatedPanelWidget where applicable ...................................................................... webadmin: use ValidatedPanelWidget where applicable Using ValidatedPanelWidget instead of manual validation: * Attach disk panel * iSCSI/FCP panel Change-Id: I80a69c3767b1f55d0846fa65386cc02082965798 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 9 files changed, 57 insertions(+), 167 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80a69c3767b1f55d0846fa65386cc02082965798 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix quota not inherited from VM to Template
by gchaplik＠redhat.com 07 Mar '13

07 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix quota not inherited from VM to Template ...................................................................... core: Fix quota not inherited from VM to Template When Template was created from a Vm using the REST API the quota of the disks was not inherited by the new template disks. The command was looking for quota to assign to the new disk in the DiskInfoDestinationMap. But as quota is not yet fully supported in REST, this map is left empty. Added an 'else' block which uses the old disk quota as a default. Change-Id: I697082483c706178b8ea47306779dc2b63da5ed6 Bug-Url: https://bugzilla.redhat.com/913551 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 12 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I697082483c706178b8ea47306779dc2b63da5ed6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0