March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: DeactivateStorageDomain - allow unknown status if exec...
by mkublin＠redhat.com 06 Mar '13

06 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: core: DeactivateStorageDomain - allow unknown status if executed as internal ...................................................................... core: DeactivateStorageDomain - allow unknown status if executed as internal When the deactivate storage domain command is executed as internal command, allow deactivating when the domain status is unknown - this is required so that domain failover process will be able to deactivate domains also if their status is unknown. Change-Id: I6e84a6ce8bf81d263c7466d1e99ed4233e16e1ad related to Bug-Url: https://bugzilla.redhat.com/912054 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12686 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e84a6ce8bf81d263c7466d1e99ed4233e16e1ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Storage domains failover never runs when all domains i...
by mkublin＠redhat.com 06 Mar '13

06 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: core: Storage domains failover never runs when all domains in problem ...................................................................... core: Storage domains failover never runs when all domains in problem When blocking connections to all storage domains of pool at once, reconstruct will never success as we don't have a working connection to any domain, each running reconstruct will clear the domain timers, meaning that the domains will never move to be inactive. Basically the behaviour after this patch will be- Successful reconstruct : clear jobs, problematic data and all events from the queue. Failed reconstruct: leave jobs, 'problematic' domains and vds data, leave DOMAINFAILOVER/VDSCLEARCACHE events in the queue. This patch adds the following changes: *Event with the type of DOMAINFAILOVER/VDSCLEARCACHE should be added to the queue when reconstruct runs and also stay in the queue after unsuccessful reconstruct. *MarkPoolInReconstructMode which clears the timers and delete the 'problematic' data should be executed only if the reconstruct command succeeded so that the domains will be able to move to inactive state, I've removed also the no longer parameters and enum classes. Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7 Bug-Url: https://bugzilla.redhat.com/912054 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MarkPoolInReconstructModeVDSCommandParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMarkAction.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MarkPoolInReconstructModeVDSCommand.java 5 files changed, 34 insertions(+), 77 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add VDSM missing error messages(2).
by mlipchuk＠redhat.com 06 Mar '13

06 Mar '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add VDSM missing error messages(2). ...................................................................... core: Add VDSM missing error messages(2). Add missing VDSM messages to the engine, so vdsm_verify_error_codes test will not fail Change-Id: Ide0c9cc1a43a4947c57ba7f647e11763726826aa Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12763 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide0c9cc1a43a4947c57ba7f647e11763726826aa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix findbugs warnings in Volume tab
by sanjal＠redhat.com 06 Mar '13

06 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: Fix findbugs warnings in Volume tab ...................................................................... webadmin: Fix findbugs warnings in Volume tab Using StringBuilder instead of String when doing String concatenation in a loop. Change-Id: I4153b3da606e1b579d3126526319bc0e5e09a46e Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4153b3da606e1b579d3126526319bc0e5e09a46e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix VM Basic item button element IDs
by ecohen＠redhat.com 06 Mar '13

06 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Fix VM Basic item button element IDs ...................................................................... userportal: Fix VM Basic item button element IDs Element IDs for VM Basic item buttons (Run, Shutdown, Suspend) were not initialized correctly, since item View's add*Button methods are now called early on, as part of item PresenterWidget onBind method (setElementId is called later on). Change-Id: Ie3ec57e493ad3de36e5fa494d4fdc4d3eefbc9da Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java 1 file changed, 7 insertions(+), 11 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3ec57e493ad3de36e5fa494d4fdc4d3eefbc9da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Upgrade - Error Can't start the ovirt-engine-dwhd servi...
by emesika＠redhat.com 06 Mar '13

06 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core:Upgrade - Error Can't start the ovirt-engine-dwhd service ...................................................................... core:Upgrade - Error Can't start the ovirt-engine-dwhd service Upgrade - Error Can't start the ovirt-engine-dwhd service Adding a new varaible to dwh_history_timekeeping named lastStatisticsUpdate. This variable indicates when statistics on vm/vm interface/host/host insterface/disk was changed. Change-Id: I3461f0bf9ac30b8413179f32d50e017fca0cf777 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918152 --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/disk_image_dynamic_sp.sql M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_02_0490_add_lastStatisticsUpdate_to_dwh_history_timekeeping.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vms_sp.sql 6 files changed, 26 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3461f0bf9ac30b8413179f32d50e017fca0cf777 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VNIC plug/unplug is incorrectly reported in event lo...
by alkaplan＠redhat.com 06 Mar '13

06 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: VNIC plug/unplug is incorrectly reported in event log ...................................................................... engine: VNIC plug/unplug is incorrectly reported in event log The terminology should be plug/unplug and not activate/deactivate. Change-Id: I6f3655a4109712c8368811214d2f5a64e5036810 Bug-Url: https://bugzilla.redhat.com/917522 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f3655a4109712c8368811214d2f5a64e5036810 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: vNic name is overridden by VM name
by masayag＠redhat.com 06 Mar '13

06 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: vNic name is overridden by VM name ...................................................................... engine: vNic name is overridden by VM name A bug was caused by refactor code which changed the setter of the nic's vm name and used the nic's name setter instead. Change-Id: I211cefbe896d93ae7500f480d63a26d49ea7541e Bug-Url: https://bugzilla.redhat.com/916620 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/12761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I211cefbe896d93ae7500f480d63a26d49ea7541e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Protect GetAttachmentServlet from response splitting a...
by ofrenkel＠redhat.com 06 Mar '13

06 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Protect GetAttachmentServlet from response splitting attack ...................................................................... core: Protect GetAttachmentServlet from response splitting attack Current version of GetAttachmentServlet inserts given filename directly to http response header, which allows code splitting. This patch fixes it by url-encoding the given filename. Change-Id: I90dd7d95879342d70cfbb43c49d128457aebc35e Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410 --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90dd7d95879342d70cfbb43c49d128457aebc35e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Import gluster hosts message modified
by sanjal＠redhat.com 06 Mar '13

06 Mar '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: Import gluster hosts message modified ...................................................................... webadmin: Import gluster hosts message modified When selecting a gluster cluster which has some new hosts (due to gluster CLI), the alert message is changed from 'Import to oVirt engine' to 'Import to engine'. Change-Id: Id74bfef54d03ed422fb43c12476878edc43a5b11 Bug-Url: https://bugzilla.redhat.com/913798 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/12615 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74bfef54d03ed422fb43c12476878edc43a5b11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0