March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: align configure firewall checkbox
by tnisan＠redhat.com 05 Mar '13

05 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: align configure firewall checkbox ...................................................................... webadmin: align configure firewall checkbox Reduced width of "configure firewall" checkbox in new host dialog , so it will be in the same line with its label. (Before the fix the checkbox was in new line separate from its label) Change-Id: Id9886c1e6c28bfab5f952455c06f44a7daf7f4c2 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12732 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9886c1e6c28bfab5f952455c06f44a7daf7f4c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Snapshot should not be update after rollback.
by mlipchuk＠redhat.com 05 Mar '13

05 Mar '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Snapshot should not be update after rollback. ...................................................................... core: Snapshot should not be update after rollback. Once createAllSnapshotCommand execution encountered a rollback, The new snapshot is deleted as part of the compensation scenario. That will cause the end method to get null value for the snapshotId and will cause an sql exception when it will be updated. The update phase should be only when the tasks failed but also when command finished successfully and the snapshot was already created in the DB. Change-Id: Ia96cd0958dcdb34d590a160b422b3b2562149344 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/917719 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/12731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96cd0958dcdb34d590a160b422b3b2562149344 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Management network should be viewable on UserPortal
by masayag＠redhat.com 05 Mar '13

05 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Management network should be viewable on UserPortal ...................................................................... engine: Management network should be viewable on UserPortal When creating an empty data-center, a management network is created automatically for it, without any permissions. This prevents from the users to use the network without granting permissions explicitly for that network. In order to improve the user-experience, the default network will be granted for 'everyone' user with 'NetworkUser' role. Change-Id: I3bf7a3c16b61bf343fe0994050042573e06b3c33 Bug-Url: https://bugzilla.redhat.com/902697 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java 3 files changed, 48 insertions(+), 22 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bf7a3c16b61bf343fe0994050042573e06b3c33 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Add support for ${...} in local config
by juan.hernandez＠redhat.com 05 Mar '13

05 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Add support for ${...} in local config ...................................................................... packaging: Add support for ${...} in local config This patch adds support for references to parameters in the local configuration file. This is convenient in order to simplify the packaging of other applications, like reports, as with this support they don't have to modify the existing configuration files, but add new ones in the /etc/ovirt-engine/engine.conf.d directory. For example, in order to add the reports application there is no need to modify the existing engine.conf file to add the following: ENGINE_APPS=engine.ear reports.war Instead of that a file can be created in engine.conf.d with the following content: ENGINE_APPS=${ENGINE_APPS} reports.war Change-Id: Ib8ce501241ed1a937db24e1371e2d4227679ae74 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M packaging/fedora/engine-service.py.in M packaging/fedora/spec/ovirt-engine.spec.in 3 files changed, 141 insertions(+), 27 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib8ce501241ed1a937db24e1371e2d4227679ae74 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename methods to start with small letter
by tnisan＠redhat.com 05 Mar '13

05 Mar '13

Tal Nisan has submitted this change and it was merged. Change subject: core: rename methods to start with small letter ...................................................................... core: rename methods to start with small letter Rename methods in storage related commands to start with small letters according to Java conventions Change-Id: I2b69a96a8f229fe79958cb24d6334ebd224f4859 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingNFSStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommon.java 4 files changed, 28 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b69a96a8f229fe79958cb24d6334ebd224f4859 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, restapi: Remove double ReapedMaps
by amureini＠redhat.com 05 Mar '13

05 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core, restapi: Remove double ReapedMaps ...................................................................... core, restapi: Remove double ReapedMaps There are two almost identical (except for whitespaces and the occasional formatting difference) classes called ReadpedMap in oVirt Engine: 1. org.ovirt.engine.api.common.util.ReapedMap 2. org.ovirt.engine.core.utils.ReapedMap This patch removes the api class, and leaves only the core one. It includes: 1. Removal of the redundant class and deferring all usages to the correct class. 2. Moving the test from the rest package to the core package. 3. Translating the test from EasyMock to Mockito, as used in the rest of the core package tests. Change-Id: I924355a495945a063b8e15f233188fc236df2432 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/resource/AbstractActionableResource.java D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReapedMap.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java 4 files changed, 32 insertions(+), 301 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I924355a495945a063b8e15f233188fc236df2432 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Remove useless Task.state member
by amureini＠redhat.com 05 Mar '13

05 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: ui: Remove useless Task.state member ...................................................................... ui: Remove useless Task.state member Removed the useless member state from the Task class. This member was only stored and never read. Change-Id: Ieac59fed7312c049971dcc874216b62c524f9060 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieac59fed7312c049971dcc874216b62c524f9060 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Remove useless AbstractVmPopupWidget.constants
by amureini＠redhat.com 05 Mar '13

05 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: ui: Remove useless AbstractVmPopupWidget.constants ...................................................................... ui: Remove useless AbstractVmPopupWidget.constants Removed the useless member constants form AbstractVmPopupWidget. This member is only stored, but never used. Change-Id: Icefd8fd1b46ade33e675964aa45b7cce77d75288 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icefd8fd1b46ade33e675964aa45b7cce77d75288 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: Remove unused DateTimeUtils methods
by amureini＠redhat.com 05 Mar '13

05 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: ui: Remove unused DateTimeUtils methods ...................................................................... ui: Remove unused DateTimeUtils methods Removed unused methods in DateTimeUtils. Change-Id: I9771aba4f7ab107cdfb300aa88797b70ae4f4e24 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/DateTimeUtils.java 1 file changed, 0 insertions(+), 70 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9771aba4f7ab107cdfb300aa88797b70ae4f4e24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Possible NPE fixed
by tjelinek＠redhat.com 05 Mar '13

05 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Possible NPE fixed ...................................................................... webadmin: Possible NPE fixed Set correctly data center as the first element in the array in ImportVM model. Else skip dialog initialization - FindBugs warning removed. Change-Id: Ic44ce88f074d8847ef8d97510e7014fe239fe822 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic44ce88f074d8847ef8d97510e7014fe239fe822 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0