March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Enable AJP in development configuration
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: engine: Enable AJP in development configuration ...................................................................... engine: Enable AJP in development configuration The AJP connector is not enabled in the development configuration (in the standalone.xml file) and it is convenient for developers that want to test the integration with the Apache web server in their development workstations. Change-Id: Ibb8d727441456b97fe5780e8703a6d99bb32d7b2 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/standalone.xml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb8d727441456b97fe5780e8703a6d99bb32d7b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix broken rsdl_metadata
by mpastern＠redhat.com 04 Mar '13

04 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix broken rsdl_metadata ...................................................................... restapi: fix broken rsdl_metadata Change-Id: If11d1307ec37a5d924f12b8e757e693201f977da Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If11d1307ec37a5d924f12b8e757e693201f977da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clear compiler warnings
by masayag＠redhat.com 04 Mar '13

04 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Clear compiler warnings ...................................................................... engine: Clear compiler warnings The patch clears compiler/eclipse warnings. Change-Id: I34991414aa6055e2adabab189d7ae4b1f4b4f9f9 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34991414aa6055e2adabab189d7ae4b1f4b4f9f9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DhUserCacheManager: Remove empty else block
by amureini＠redhat.com 04 Mar '13

04 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DhUserCacheManager: Remove empty else block ...................................................................... core: DhUserCacheManager: Remove empty else block Change-Id: I011ca459f98494967495ae0cb8e381d7a3443c28 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011ca459f98494967495ae0cb8e381d7a3443c28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbUserCacheManager: Remove FQDN
by amureini＠redhat.com 04 Mar '13

04 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbUserCacheManager: Remove FQDN ...................................................................... core: DbUserCacheManager: Remove FQDN Remove FQDNs and replaced with imports, for better readability. Change-Id: I8957ad7fa0317b84fd82bdd891d9dd984d9ebc26 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java 2 files changed, 10 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8957ad7fa0317b84fd82bdd891d9dd984d9ebc26 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbUserCacheManager: add missing modifiers
by amureini＠redhat.com 04 Mar '13

04 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbUserCacheManager: add missing modifiers ...................................................................... core: DbUserCacheManager: add missing modifiers Added static and final modifiers where appropriate to utilize Java's memory handling optimizations. Change-Id: Ic4d6d7a2ed75584e326609ae820e054b302748a0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4d6d7a2ed75584e326609ae820e054b302748a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbUserCacheManager: iterate entrySet()
by amureini＠redhat.com 04 Mar '13

04 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbUserCacheManager: iterate entrySet() ...................................................................... core: DbUserCacheManager: iterate entrySet() Iterate over entrySet() instead of iterating over keySet() and calling get, for better performance. Change-Id: I8db1dd978760eb961a7e17c36a99ff4f8a2c4917 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8db1dd978760eb961a7e17c36a99ff4f8a2c4917 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DbUserCacheManager: Fix comment format
by amureini＠redhat.com 04 Mar '13

04 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: DbUserCacheManager: Fix comment format ...................................................................... core: DbUserCacheManager: Fix comment format Stop using javadoc format for in-method comments. Change-Id: Ic08e9864d2fe0129b32d882dbf997c24d9ec2c04 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08e9864d2fe0129b32d882dbf997c24d9ec2c04 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Rewrote arranging of NICs in Host/Networks subtab
by alkaplan＠redhat.com 04 Mar '13

04 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Rewrote arranging of NICs in Host/Networks subtab ...................................................................... webadmin: Rewrote arranging of NICs in Host/Networks subtab This patch includes: * Some needed refactoring. * Sorting of NICs by name using LexoNumericComparator. * Removal of HostVLanByNameComparer class which is no longer used. * Improvement of computational complexity - old code was naive and would perform in O(n^2), reduced to O(nlogn) bounded by sorting. Change-Id: I0b464cc023282ceab868230a1c31638ebe75de4d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883269 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostVLanByNameComparer.java 3 files changed, 135 insertions(+), 108 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b464cc023282ceab868230a1c31638ebe75de4d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Renamed Bond() method to bond()
by alkaplan＠redhat.com 04 Mar '13

04 Mar '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Renamed Bond() method to bond() ...................................................................... webadmin: Renamed Bond() method to bond() This to enable elegant usage of the Bond class. Change-Id: I91b2c18475c91fedee69e6b7b0d0ce77c1f80c03 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91b2c18475c91fedee69e6b7b0d0ce77c1f80c03 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0