March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: engine-setup - Don't change selinux context in ru...
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-setup - Don't change selinux context in runtime ...................................................................... packaging: engine-setup - Don't change selinux context in runtime Engine setup use miniyum to perform RPM/YUM based operations, and asks miniyum to change the selinux context of the whole proccess during it's intializtion. This patch removes the selinux context change, as it blocks dbus messeges issued by firewalld api, and currently not really needed. Change-Id: I46e04f185c04cc30c8e0b52367d6209716dc0d98 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904153 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46e04f185c04cc30c8e0b52367d6209716dc0d98 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: Packaging: engine_setup: Remove unused imports in firewalld ...
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: Packaging: engine_setup: Remove unused imports in firewalld lib ...................................................................... Packaging: engine_setup: Remove unused imports in firewalld lib Removed two unused python imports from engine_firewalld. Change-Id: I437a7c60068af53b0a53a8bd13a3c83e1a2bdbe9 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine_firewalld.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437a7c60068af53b0a53a8bd13a3c83e1a2bdbe9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Add support for apc_snmp power management...
by emesika＠redhat.com 04 Mar '13

04 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core:Add support for apc_snmp power management... ...................................................................... core:Add support for apc_snmp power management... Add support for apc_snmp power management agent fence_apc is not supporting apc firmware 5.x In order to test apc firmware 5.x agents, we will have to use fence_apc_snmp Change-Id: I7a80a787db453e612b844d55fc05d6530b6b92ad Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916570 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a80a787db453e612b844d55fc05d6530b6b92ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: Use engine.conf for local configuration
by ydary＠redhat.com 04 Mar '13

04 Mar '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: Use engine.conf for local configuration ...................................................................... packaging: Use engine.conf for local configuration Commit 5a3141 of ovirt-engine moved the local configuration from /etc/sysconfig/ovirt-engine to /etc/ovirt-engine/engine.conf so DWH needs to be modified accordingly. Change-Id: Ifb3ba0ae3c9f9d24782d4d55f99836bf157800ec Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M data-warehouse/history_etl/history_service/history_service.sh M packaging/ovirt-engine-dwh-setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb3ba0ae3c9f9d24782d4d55f99836bf157800ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Use LocalConfig to read configuration
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Use LocalConfig to read configuration ...................................................................... tools: Use LocalConfig to read configuration Tools used to read the /etc/sysconfig/ovirt-engine file directly. This patch changes them so that they read it reusing the LocalConfig class. Change-Id: Iee87716045b9ee874bf1337e7df20061c8b6fdc1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java 1 file changed, 5 insertions(+), 45 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee87716045b9ee874bf1337e7df20061c8b6fdc1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Use engine.conf for local configuration
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Use engine.conf for local configuration ...................................................................... packaging: Use engine.conf for local configuration This change moves the content of the /etc/sysconfig/ovirt-engine file to the /etc/ovirt-engine/engine.conf file. The reason for this is that this file is not only used by the service, but also by other tools, and in other Linux distributions the sysconfig directory is not common. Change-Id: I9b48f1fd78ebd891e93949f19fafefcffd377254 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/conf/engine.conf M backend/manager/conf/engine.conf.defaults.in M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java D packaging/fedora/engine-service.sysconfig M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 11 files changed, 100 insertions(+), 84 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b48f1fd78ebd891e93949f19fafefcffd377254 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Printing user name for each domain being validated
by yzaslavs＠redhat.com 04 Mar '13

04 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Printing user name for each domain being validated ...................................................................... tools: Printing user name for each domain being validated Bug-Url: https://bugzilla.redhat.com/903729 Change-Id: Iffec70b90eec81064347c43793dd1a9d0104e139 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12595 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffec70b90eec81064347c43793dd1a9d0104e139 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: ActivateVdsCommand cleanup
by masayag＠redhat.com 04 Mar '13

04 Mar '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: ActivateVdsCommand cleanup ...................................................................... engine: ActivateVdsCommand cleanup The patch performs few minor cleanups. Change-Id: I7b407c035cbc094b314b3d26a4a1d679b8a8303f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b407c035cbc094b314b3d26a4a1d679b8a8303f Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Avoid errors when reading notifier.conf
by juan.hernandez＠redhat.com 04 Mar '13

04 Mar '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Avoid errors when reading notifier.conf ...................................................................... tools: Avoid errors when reading notifier.conf The current mechanism that we use to read the notifier.conf file in the notifier script generates the following error messages: engine-notifier.sh: line 68: declare: `#': not a valid identifier To avoid that the condition to ignore empty lines and comment lines has been replaced with a sed command that removes them before they are processed by the notifier script. Change-Id: If2670db513f6f9814feb8fe2786219f12530ea96 Bug-Url: https://bugzilla.redhat.com/911216 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier.sh 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2670db513f6f9814feb8fe2786219f12530ea96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Improve engine-config help
by yzaslavs＠redhat.com 03 Mar '13

03 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Improve engine-config help ...................................................................... tools: Improve engine-config help This patch provides a new option to engine-config - engine-config -h <keyname> For example - engine-config -h AdminPassword This will provide more specific help (comparing with engine-config -h) to keys. Change-Id: I090d52cbc246eb9ffdd985ca6b5aeab6582c8653 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/ConfigKeyHandler.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/BaseValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ConfigActionType.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/validation/ValidatorType.java M backend/manager/tools/src/main/shell/engine-config.sh 13 files changed, 121 insertions(+), 18 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I090d52cbc246eb9ffdd985ca6b5aeab6582c8653 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0