March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove fixtures.out.xml
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove fixtures.out.xml ...................................................................... core: Remove fixtures.out.xml fixtures.out.xml is a file wrongly created when you try to run fixtures.xml (instead of a Java test case) from Eclipse IDE. It's empty, and shouldn't have been committed in the first place. Change-Id: Ic6141d096dc61f5929ac361e1d761028ad4e7882 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/dal/src/test/resources/fixtures.out.xml 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6141d096dc61f5929ac361e1d761028ad4e7882 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use VdsRowMapper static instance
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use VdsRowMapper static instance ...................................................................... core: Use VdsRowMapper static instance Use VdsRowMapper.instance wherever possible instead of creating a new instance. Change-Id: I7baed640aafe8c9ebd25c722609192cd88196f93 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7baed640aafe8c9ebd25c722609192cd88196f93 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for VdcOption
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for VdcOption ...................................................................... core: Singleton row mapper for VdcOption Added a singleton row mapper for VdcOptionDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Idb2e777ba64f285d550825c65cf047c9cc91ac76 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdcOptionDAODbFacadeImpl.java 1 file changed, 20 insertions(+), 43 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb2e777ba64f285d550825c65cf047c9cc91ac76 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: final RowMapper for ImageStorageDomainMaoDao
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: final RowMapper for ImageStorageDomainMaoDao ...................................................................... core: final RowMapper for ImageStorageDomainMaoDao Made the private static RowMapper in ImageStorageDomainMap final. Change-Id: I184a18bf97000a44301a53207d4806d620d6abd8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoDbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I184a18bf97000a44301a53207d4806d620d6abd8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for DiskLunMap
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for DiskLunMap ...................................................................... core: Singleton row mapper for DiskLunMap Added a singleton row mapper for DiskLunMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Id20b5a12273990b61937aa6bdceacf8c2977f176 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoDbFacadeImpl.java 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id20b5a12273990b61937aa6bdceacf8c2977f176 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for StoragePoolIsoMap
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for StoragePoolIsoMap ...................................................................... core: Singleton row mapper for StoragePoolIsoMap Added a singleton row mapper for StoragePoolIsoMapDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I59d62598c4be4c84879364d016d282855428474c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java 1 file changed, 23 insertions(+), 44 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d62598c4be4c84879364d016d282855428474c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mapper for DiskImageDynamic
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mapper for DiskImageDynamic ...................................................................... core: Singleton row mapper for DiskImageDynamic Added a singleton row mapper for DiskImageDynamicDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Icad2f8fb8199d3b3c873cf01db999a873b13cde6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java 1 file changed, 23 insertions(+), 19 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icad2f8fb8199d3b3c873cf01db999a873b13cde6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: StoragePoolDAO single RowMapper
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: StoragePoolDAO single RowMapper ...................................................................... core: StoragePoolDAO single RowMapper Remove local instances of RowMappers in StoragePoolDAO and used the preexisting static final member instead. Change-Id: I06e8a0f5d5dfbf2a4ab5de10c1c942def84ad2ed Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDAODbFacadeImpl.java 1 file changed, 0 insertions(+), 173 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06e8a0f5d5dfbf2a4ab5de10c1c942def84ad2ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: StorageDoaminSynamic Singleton row mapper
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: StorageDoaminSynamic Singleton row mapper ...................................................................... core: StorageDoaminSynamic Singleton row mapper Added a singleton row mapper in StorageDomainDynamicDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Ia7a1b6e40235a37632d9f5f0ca8a5c3cd04ea4fc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java 1 file changed, 22 insertions(+), 32 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7a1b6e40235a37632d9f5f0ca8a5c3cd04ea4fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Singleton row mappers for EventDAO
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Singleton row mappers for EventDAO ...................................................................... core: Singleton row mappers for EventDAO Added singleton row mappers for EventDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I3f44cf4eafacc2069fb9523d6b29ce777bcd9a6f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/EventDAODbFacadeImpl.java 1 file changed, 61 insertions(+), 99 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f44cf4eafacc2069fb9523d6b29ce777bcd9a6f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0