April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: ovirt-engine-3.2.2
by oschreib＠redhat.com 01 May '13

01 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.2.2 ...................................................................... packaging: ovirt-engine-3.2.2 updated version to 3.2.2 Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56b6ef52d905a5914786ef1f7d9bd287d58d2288 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: fix environment for java
by oschreib＠redhat.com 30 Apr '13

30 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: fix environment for java ...................................................................... packaging: engine-service: fix environment for java python dict.update() returns None. Change-Id: I781557e81db3417e80c144c6b05315f6011f2e31 Reported-By: Limor Gavish <lgavish(a)gmail.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14314 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781557e81db3417e80c144c6b05315f6011f2e31 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "engine: Use isBlockDomain() where possible"
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: Revert "engine: Use isBlockDomain() where possible" ...................................................................... Revert "engine: Use isBlockDomain() where possible" This is a partial revert of the rest parts of commit f4eaef896d8927f968023c01e36db173c3deb73d It was commit without the proper review, and should never have been merged. Change-Id: I181986b7ead007e0193d48253261132554a7f69b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 2 files changed, 18 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I181986b7ead007e0193d48253261132554a7f69b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StoragePoolIsoMapDAO.update impl
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StoragePoolIsoMapDAO.update impl ...................................................................... core: Remove StoragePoolIsoMapDAO.update impl Since the owner column was removed from StoragePoolIsoMap in the previous patch, it's only (database) mutable column is the status column. In other words, there is no difference between the update and updateStatus methods. This patch removes the Updatestorage_pool_iso_map stored procedure and replaces the implementation of the update method with a delegation to updateStatus. Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java 2 files changed, 1 insertion(+), 23 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia661353ed7b100795d90c9390866c955a1a6290d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StorageDomainOwnerType
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StorageDomainOwnerType ...................................................................... core: Remove StorageDomainOwnerType The StorageDomainOwnerType enum contains only one value ("Unknown"), and as such, is pretty useless and can be removed. This patch removes it and all its references. Change-Id: Iae13123bc33c2fdff2d7dd5e128c1a5cee7d262f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/storages_san_sp.sql A backend/manager/dbscripts/upgrade/03_03_0110_drop_storage_owner.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainOwnerType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolIsoMapDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectStreamDeserializerTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ObjectStreamSerializerTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 11 files changed, 11 insertions(+), 71 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae13123bc33c2fdff2d7dd5e128c1a5cee7d262f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed ImportCandidateTypeEnum
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed ImportCandidateTypeEnum ...................................................................... core: Removed ImportCandidateTypeEnum The aforementioned enum is not used anywhere in the codebase, and should thus be removed. Change-Id: Ic547d2356e310324fa53b49122786bfe3f769ab4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ImportCandidateTypeEnum.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic547d2356e310324fa53b49122786bfe3f769ab4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Remove TabType
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core, webadmin: Remove TabType ...................................................................... core, webadmin: Remove TabType The TabType enum is not used anywhere in the codebase, and thus should be removed. This patch removes it and any localization references to it. Change-Id: I2e17e4e533439d9038654213d2f5375c16b24f0a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TabType.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties 3 files changed, 0 insertions(+), 63 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e17e4e533439d9038654213d2f5375c16b24f0a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Clean up Common.gwt.xml
by amureini＠redhat.com 30 Apr '13

30 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Clean up Common.gwt.xml ...................................................................... webadmin: Clean up Common.gwt.xml Cleaned up Common.gwt.xml from numerous entries in order to make the file more maintainable and speed up the build a tad. The following entries were removed: 1. Classes that no longer exist in the code base (e.g., time_lease_vm_pool_map). 2. Classes that are not used by the frontend (e.g., LUN_storage_server_connection_map). 3. Double entries (e.g., UsbPolicy). 4. Specific entries that can be inferred from more general entries (e.g., common/action/VdcActionType.java does not need to be specified since common/action/* already is). Change-Id: Idebce672b96192f7b114fc1596ba462fe097d9b8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 2 insertions(+), 60 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idebce672b96192f7b114fc1596ba462fe097d9b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Redundant nullcheck
by shavivi＠redhat.com 30 Apr '13

30 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Redundant nullcheck ...................................................................... findbugs: Redundant nullcheck Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id991b677df2d447b8124de5ae8a1f1a52aca98e5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi:Correct rsdl for add bricks
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi:Correct rsdl for add bricks ...................................................................... restapi:Correct rsdl for add bricks Add bricks command causes an exception in cli when passed a collection of bricks. Changed the rsdl to brick--COLLECTION as per Michael's suggestion Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Bug-Url: https://bugzilla.redhat.com/923169 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 15 insertions(+), 16 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: resolve dependency resolution at build
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: resolve dependency resolution at build ...................................................................... cli: resolve dependency resolution at build Change-Id: Ib82564bb547b0cc48081b8f2fc6c64b993644b21 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82564bb547b0cc48081b8f2fc6c64b993644b21 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Making VM related substabs resizable
by tjelinek＠redhat.com 30 Apr '13

30 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Making VM related substabs resizable ...................................................................... webadmin: Making VM related substabs resizable VM, template and host related subtabs Change-Id: Ibb8a7edcf437650a4882d767f29ce5041f3b3be6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostHookView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/pool/SubTabPoolVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/template/SubTabTemplateVmView.java 6 files changed, 43 insertions(+), 32 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb8a7edcf437650a4882d767f29ce5041f3b3be6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Throw exception if setting lower VM pool size
by tjelinek＠redhat.com 30 Apr '13

30 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: Throw exception if setting lower VM pool size ...................................................................... restapi: Throw exception if setting lower VM pool size Report, if the user tries to lower the number of VMs in the VM pool. Change-Id: Ibe4ad50e6962159df5891be4653bc05eb3dfd237 Bug-Url: https://bugzilla.redhat.com/950049 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe4ad50e6962159df5891be4653bc05eb3dfd237 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Added colon and space after new password prompt in en...
by yzaslavs＠redhat.com 30 Apr '13

30 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Added colon and space after new password prompt in engine-config ...................................................................... tools: Added colon and space after new password prompt in engine-config Added colon and space after new password prompt using: engine-config -s AdminPassword=interactive Bug-Url: https://bugzilla.redhat.com/924603 Change-Id: I7abc9cba42e2407874c5022f81f40330fa7eba53 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7abc9cba42e2407874c5022f81f40330fa7eba53 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: datetime.datetime object has no attribute __dict__ #957...
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: datetime.datetime object has no attribute __dict__ #957519 ...................................................................... cli: datetime.datetime object has no attribute __dict__ #957519 Change-Id: Ie26fd8e83a87dc1e4d2db2628603e27d3e3fb835 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957519 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/format/text.py 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie26fd8e83a87dc1e4d2db2628603e27d3e3fb835 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: datetime.datetime object has no attribute __dict__ #957...
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: datetime.datetime object has no attribute __dict__ #957519 ...................................................................... cli: datetime.datetime object has no attribute __dict__ #957519 Change-Id: Ie26fd8e83a87dc1e4d2db2628603e27d3e3fb835 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957519 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/format/text.py 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie26fd8e83a87dc1e4d2db2628603e27d3e3fb835 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: do not use preserved "type" as param name
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not use preserved "type" as param name ...................................................................... cli: do not use preserved "type" as param name Change-Id: If709df3d9c63ae77c19f2b52cad27e5490b46481 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If709df3d9c63ae77c19f2b52cad27e5490b46481 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: remove pexpect dependency
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: remove pexpect dependency ...................................................................... cli: remove pexpect dependency GetKeyCommand is a deprecated POC that no longer maintained/supported, since pexpect was forked in latest fedora, and this is only pexpect owner, this patch removes both GetKeyCommand and pexpect/pexpect-u dependency. Change-Id: Ief144fc7f32844a08463a497f2b483703d6ec0d3 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-cli.spec.in M setup.py M src/ovirtcli/command/__init__.py D src/ovirtcli/command/getkey.py M src/ovirtcli/context.py M src/ovirtcli/platform/__init__.py M src/ovirtcli/platform/posix/__init__.py 7 files changed, 1 insertion(+), 81 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief144fc7f32844a08463a497f2b483703d6ec0d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: normalize sdk errors
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: normalize sdk errors ...................................................................... cli: normalize sdk errors Change-Id: Ia4fef4767f7c007ae882c3734b592ab63b32deb5 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 16 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4fef4767f7c007ae882c3734b592ab63b32deb5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: recognize AmbiguousQueryError as COMMAND_ERROR
by mpastern＠redhat.com 30 Apr '13

30 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: recognize AmbiguousQueryError as COMMAND_ERROR ...................................................................... cli: recognize AmbiguousQueryError as COMMAND_ERROR Change-Id: I61665beffe059b3ebe2296ebb4916bfe49f1f025 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61665beffe059b3ebe2296ebb4916bfe49f1f025 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Add host: Improved gluster validation [2]
by sanjal＠redhat.com 30 Apr '13

30 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Add host: Improved gluster validation [2] ...................................................................... gluster: Add host: Improved gluster validation [2] Currently we don't allow to add a host if it has peers. However, if one (or more) of those peers are already part of the cluster in engine DB, then it means that these have been added from gluster CLI and hence the validation should not fail in such cases. Change-Id: I36b3b6d00a71af50ef1b006e95daebfbfe3f67f5 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/gluster/GlusterUtil.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/gluster/GlusterUtilTest.java 4 files changed, 61 insertions(+), 19 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36b3b6d00a71af50ef1b006e95daebfbfe3f67f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remvoing useless AtomicInteger from EntityAsyncTask
by yzaslavs＠redhat.com 30 Apr '13

30 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Remvoing useless AtomicInteger from EntityAsyncTask ...................................................................... core: Remvoing useless AtomicInteger from EntityAsyncTask Removing a useless Atomic integer that is not in use anymore, besides the decrease and incrase of the value Change-Id: Ic7d52dc4df7e39e7059e64eb0241861f88d45fef Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7d52dc4df7e39e7059e64eb0241861f88d45fef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Non-Boolean argument formatted as boolean
by shavivi＠redhat.com 30 Apr '13

30 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Non-Boolean argument formatted as boolean ...................................................................... findbugs: Non-Boolean argument formatted as boolean Change-Id: I82496f3ec4994a60df0706d0cf94b93b039ed372 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SyncImageGroupDataVDSCommandParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82496f3ec4994a60df0706d0cf94b93b039ed372 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rhevm-upgrade creates log/helping files...
by emesika＠redhat.com 30 Apr '13

30 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core: rhevm-upgrade creates log/helping files... ...................................................................... core: rhevm-upgrade creates log/helping files... rhevm-upgrade creates log/helping files in /usr/share/ovirt-engine/dbscripts 1) Adding -g parameter to create_db.sh create_schema.sh and upgrade.sh to disable MD5 files generation (default NOMD5=false) 2) Adding -m MD5DIR parameter to create_db.sh create_schema.sh and upgrade.sh to set the MD% directory (default =MD5DIR=$(pwd)) 3) Removing auto-generation of .schema files and creating a exportDbSchema.sh that generates this file since it is used only for development Change-Id: I89b970fdd93102d6354e6cb634af2bd74c0a5dc9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947344 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/create_db.sh M backend/manager/dbscripts/create_schema.sh M backend/manager/dbscripts/dbcustomfunctions.sh M backend/manager/dbscripts/dbfunctions.sh A backend/manager/dbscripts/exportDbSchema.sh M backend/manager/dbscripts/upgrade.sh 6 files changed, 84 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89b970fdd93102d6354e6cb634af2bd74c0a5dc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change default 64-bit memory limit on upgrade
by tjelinek＠redhat.com 29 Apr '13

29 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Change default 64-bit memory limit on upgrade ...................................................................... engine: Change default 64-bit memory limit on upgrade Changes of memory limit for 64-bit VMs by 14dcb41a97be002833d361adfdf7ac199743d671 are now reflected on upgrade, not only on clean install. Change-Id: I8dbe4747ce6e8b17c4bfff96cb8a81599632b7da Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=954021 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Beták: Verified -- To view, visit http://gerrit.ovirt.org/14316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8dbe4747ce6e8b17c4bfff96cb8a81599632b7da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remve command serialVersionUid fields
by lhornyak＠redhat.com 29 Apr '13

29 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: remve command serialVersionUid fields ...................................................................... engine: remve command serialVersionUid fields - removed serialVersionUID fields from command implementations - removed @SuppressWarning("serial") annotations where no longer needed Change-Id: I1b0b015935132ac0a4f12e696814fc953d62b9ff Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddSystemPermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachActionGroupsToRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CancelMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachActionGroupsFromRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsCpuFlagsOrClusterChangedCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PermissionsCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ReloadConfigurationsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAdGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RolesOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateBookmarkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateRoleCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmOperationCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/CommitNetworkChangesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/VdsNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/ChangeQuotaCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectDomainToStorageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RolesCommandBaseTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java 121 files changed, 1 insertion(+), 174 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b0b015935132ac0a4f12e696814fc953d62b9ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: TimeoutBase does not have to be serialized
by lhornyak＠redhat.com 29 Apr '13

29 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: TimeoutBase does not have to be serialized ...................................................................... engine: TimeoutBase does not have to be serialized TimeoutBase never needs to be serialized, so the Serializable interface is removed. Change-Id: Idb07e9cfaad74820013ca749676cc978aa8714eb Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb07e9cfaad74820013ca749676cc978aa8714eb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: ApplicationException - removed
by mkublin＠redhat.com 29 Apr '13

29 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: ApplicationException - removed ...................................................................... engine: ApplicationException - removed We are not C# project, removing C# inheritance Change-Id: I681f44a5772e0ed2c220546fd5578a6993e862c1 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/SearchEngineIllegalCharacterException.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/SqlInjectionException.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBLLException.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/ApplicationException.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VDSExceptionBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 8 files changed, 8 insertions(+), 68 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I681f44a5772e0ed2c220546fd5578a6993e862c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Exception handling - VDSCommandBase
by mkublin＠redhat.com 29 Apr '13

29 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Exception handling - VDSCommandBase ...................................................................... engine: Exception handling - VDSCommandBase The following patch will simplify exception handling in case of failure in xml rpc call. All XmlRpcRunTimeException will be translated to network exception with error code VdcBllErrors.VDS_NETWORK_ERROR. The XmlRpcRunTimeException - means that we failed in call , failed to parse xml and we did not get appropriate response that we can parse, this is by definition VdcBllErrors.VDS_NETWORK_ERROR. Now, VdcBllErrors.VDS_PROTOCOL error was removed as unused. Change-Id: I0bd38cd75706ff7669c1ff055b951aeb864b2736 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 5 files changed, 7 insertions(+), 49 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bd38cd75706ff7669c1ff055b951aeb864b2736 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi: #920483 - Group Wrongly Displayed as User (within p...
by mpastern＠redhat.com 29 Apr '13

29 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: #920483 - Group Wrongly Displayed as User (within permission) ...................................................................... restapi: #920483 - Group Wrongly Displayed as User (within permission) Change-Id: I033811202a87b1a7e7c7e56d43ad6e2d685f1658 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 18 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ori Liel: Verified -- To view, visit http://gerrit.ovirt.org/14310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I033811202a87b1a7e7c7e56d43ad6e2d685f1658 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: provide full_version in product_info
by mpastern＠redhat.com 29 Apr '13

29 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: provide full_version in product_info ...................................................................... restapi: provide full_version in product_info Frontend uses ProductRPMVersion from vdc_options to show Engine version. This patch will include a new element called full_version into ProductInfo xsd schema, which will provide to users the same version info from Frontend. Change-Id: I9102b3121154e1ba2096ec8b54765c6bfc6a97f1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905398 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 3 files changed, 13 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9102b3121154e1ba2096ec8b54765c6bfc6a97f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Host Tab - "Primary" & "Secondary" are not localiz...
by alkaplan＠redhat.com 28 Apr '13

28 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Host Tab - "Primary" & "Secondary" are not localized ...................................................................... webadmin: Host Tab - "Primary" & "Secondary" are not localized These strings were hard coded in the host model. Moved to the Constants file. Change-Id: Ib339264fb776c5e9b060068c40f0a9d15372fe41 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib339264fb776c5e9b060068c40f0a9d15372fe41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: JP - truncation in interface column
by derez＠redhat.com 28 Apr '13

28 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: JP - truncation in interface column ...................................................................... webadmin: JP - truncation in interface column Attach Disk: fix columns headers truncation Change-Id: Ieee042d7ef6d914b1a5a067cdae97b65782cf8da Bug-Url: https://bugzilla.redhat.com/927613 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieee042d7ef6d914b1a5a067cdae97b65782cf8da Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove VM comparators in Common.gwt.xml
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Remove VM comparators in Common.gwt.xml ...................................................................... webadmin: Remove VM comparators in Common.gwt.xml Removed VmsComparer's and VmsComparerByDiskSize from Common.gwt.xml, as these classes are not used by the frontend and just add redundant overhead on GWT's compiler. Change-Id: I3280f8dd80e24c40891f0f9474388abf478ccce3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3280f8dd80e24c40891f0f9474388abf478ccce3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Introducing the comparators package
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Introducing the comparators package ...................................................................... core: Introducing the comparators package org.ovirt.engine.core.common.businessentities includes several comparators, which aren't really business entities on their own right. This patch introduces the package org.ovirt.engine.core.common.businessentities.comparators and moves those comparators there, in order to make the project's organization more straightforward. Following patches will move additional comparators there, from other sub-projects. Change-Id: I70f2432df8338c736d9ab0e6c97e38acf3ddf92f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearNonResponsiveVdsVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTopSizeVmsFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVMActionRunner.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityComparator.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/BusinessEntityGuidComparator.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/ImagesComparerByName.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/InterfaceComparerByMAC.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmTemplateComparerByDiskSize.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparer.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/VmsComparerByDiskSize.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 21 files changed, 35 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70f2432df8338c736d9ab0e6c97e38acf3ddf92f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: unify and move Disk Comparators
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: unify and move Disk Comparators ...................................................................... core: unify and move Disk Comparators Organized the various Disk and DiskImage comparators in a sensible manner. 1. Moved DiskImageByDiskAliasComparator from the dal module to the common module, so it could be shared between modules. 2. Removed ImagesComparerByName which had exactly the same functionality as DiskImageByDiskAliasComparator, and used it instead. 3. Converted DiskImageByBootComparator to be an inline class of VmInfoBuilderBase, as it seems useless outside it Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTopSizeVmsFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetUserVmsByUserIdAndGroupsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesFromStorageDomainQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsRelatedToQuotaIdQuery.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/DiskImageByDiskAliasComparator.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/ImagesComparerByName.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/comparators/DiskImageByBootComparator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java 8 files changed, 24 insertions(+), 49 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disk dialog - capitalize labels
by derez＠redhat.com 28 Apr '13

28 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disk dialog - capitalize labels ...................................................................... webadmin: Disk dialog - capitalize labels New/Edit disk dialog: s/Is bootable/Is Bootable s/Is shareable/Is Shareable s/Wipe after delete/Wipe After Delete Change-Id: Ibb6adaeed3e7e8ce99fa73730e43896355027efe Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb6adaeed3e7e8ce99fa73730e43896355027efe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disks VMs Templates sub-tabs resizable columns
by derez＠redhat.com 28 Apr '13

28 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disks VMs Templates sub-tabs resizable columns ...................................................................... webadmin: Disks VMs Templates sub-tabs resizable columns VMs/Templates sub-tabs under Disks main-tab now support resizable columns. * Invoked enableColumnResizing() on each sub-tab. * Added a static width value for each column. Change-Id: Ic7db506c95ec3642d7247f64b632e6ec7333d94f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateDiskListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java 4 files changed, 47 insertions(+), 24 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7db506c95ec3642d7247f64b632e6ec7333d94f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: ISO/Export sub-tabs resizable columns
by derez＠redhat.com 28 Apr '13

28 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: ISO/Export sub-tabs resizable columns ...................................................................... webadmin: ISO/Export sub-tabs resizable columns ISO/Export sub-tabs under Storage main-tab now support resizable columns. * Invoked enableColumnResizing() on each sub-tab. * Added a static width value for each column. Change-Id: Icf75b725fe9efa63c3e0a949c9d1bb9f6590d1aa Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageTemplateBackupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java 3 files changed, 22 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14279 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf75b725fe9efa63c3e0a949c9d1bb9f6590d1aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: new pool - update disks list on template change
by mlipchuk＠redhat.com 28 Apr '13

28 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: new pool - update disks list on template change ...................................................................... webadmin: new pool - update disks list on template change Ensure that IsDiskAvailable event sent on template change (needed for updating the disk list in Resource Allocation). Change-Id: Iced3c362de531ef3c4754ef3130563c7f6f47d1f Bug-Url: https://bugzilla.redhat.com/957044 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 2 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iced3c362de531ef3c4754ef3130563c7f6f47d1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Field masks field in superclass
by shavivi＠redhat.com 28 Apr '13

28 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Field masks field in superclass ...................................................................... findbugs: Field masks field in superclass Change-Id: I544d5e4e602040c70020fa9b2c43a49ad0bbcb9d Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I544d5e4e602040c70020fa9b2c43a49ad0bbcb9d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #920483 - Group Wrongly Displayed as User (within p...
by oliel＠redhat.com 28 Apr '13

28 Apr '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: #920483 - Group Wrongly Displayed as User (within permission) ...................................................................... restapi: #920483 - Group Wrongly Displayed as User (within permission) Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java 3 files changed, 28 insertions(+), 17 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Suggest an action when network is out of sync
by masayag＠redhat.com 28 Apr '13

28 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Suggest an action when network is out of sync ...................................................................... webadmin: Suggest an action when network is out of sync Change-Id: I21bccd87bf1311f6d2d87683f1fb1c7507bb8461 Bug-Url: https://bugzilla.redhat.com/951920 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21bccd87bf1311f6d2d87683f1fb1c7507bb8461 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: make cpu-mode enumerable values lower-case #915042
by mpastern＠redhat.com 28 Apr '13

28 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: make cpu-mode enumerable values lower-case #915042 ...................................................................... restapi: make cpu-mode enumerable values lower-case #915042 Change-Id: I50623ebbc1ec7146c2b35c0f48e23aa69691df3e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915042 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50623ebbc1ec7146c2b35c0f48e23aa69691df3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: log rotation - do not execute ls on non-existing ...
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: log rotation - do not execute ls on non-existing files ...................................................................... packaging: log rotation - do not execute ls on non-existing files Due to the usage of ls, ovirtlogrot.sh would print error messages if it couldn't find any file matching the pattern engine.log.* This patch removes the execution of ls, and therefore, removes the error messages. Change-Id: Icb3d443dd26c6e22302a694c1d0f433383f312b7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=889751 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/resources/ovirtlogrot.sh 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb3d443dd26c6e22302a694c1d0f433383f312b7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update .gitignore
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: update .gitignore ...................................................................... packaging: update .gitignore Change-Id: Ibdfa98a74f41feba87a89d2562ed91fdbcd300d9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdfa98a74f41feba87a89d2562ed91fdbcd300d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove get image info call before images commands
by ofrenkel＠redhat.com 28 Apr '13

28 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Remove get image info call before images commands ...................................................................... core: Remove get image info call before images commands BaseImageCommands calls for an image info updates its last modification time on success and does nothing(!) on failure - the nothing is achieved by updating the status in the DB and throwing an exception right afterwards - which means a rollback to the update will be made. also removed the unused VdcBllErrors.RESOURCE_MANAGER_VM_SNAPSHOT_MISSMATCH Change-Id: I93e53f009030fe38d57274544146102010570814 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 10 files changed, 0 insertions(+), 61 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93e53f009030fe38d57274544146102010570814 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging - added check on firewall-cmd support
by oschreib＠redhat.com 28 Apr '13

28 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging - added check on firewall-cmd support ...................................................................... packaging - added check on firewall-cmd support Added a check for --permanet option support for firewall-cmd. If it's not supported, firewalld will not be available as firewall manager. Moved firewalld to global scope, the import will not fail also if firewalld is not installed on the system. Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_firewalld.py 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64c441c7fde548a8b2798c9f63d59962ff6e51c3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove printing from VmHandlerTest
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove printing from VmHandlerTest ...................................................................... core: Remove printing from VmHandlerTest Removed System.out.println usage from VmHandlerTest - this is not how to log. Change-Id: I523ed85999cab2fda40dbf0bddfca8d8308df671 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I523ed85999cab2fda40dbf0bddfca8d8308df671 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveVdsCommandTest + CanDoActionTestUtils
by amureini＠redhat.com 28 Apr '13

28 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveVdsCommandTest + CanDoActionTestUtils ...................................................................... core: RemoveVdsCommandTest + CanDoActionTestUtils Use CanDoActionTestUtils in RemoveVdsCommandTest instead of reinventing the wheel. Change-Id: I946881b0cc7cdad1293b27517a04a624231b9563 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 1 file changed, 7 insertions(+), 37 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946881b0cc7cdad1293b27517a04a624231b9563 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0