April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: VDS command - gluster hooks list
by sanjal＠redhat.com 23 Apr '13

23 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: VDS command - gluster hooks list ...................................................................... engine: VDS command - gluster hooks list Gets the list of gluster hooks on a server. Change-Id: I46e47dda9717373d15264e0af942ce93d2293cb4 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 10 files changed, 105 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46e47dda9717373d15264e0af942ce93d2293cb4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: Remove sh bang from ovfenvelope.py.
by knesenko＠redhat.com 23 Apr '13

23 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Remove sh bang from ovfenvelope.py. ...................................................................... Remove sh bang from ovfenvelope.py. Its not the script so we don't really need this sh bang there. Change-Id: I43d530cf1f826834672fd7cc4cb93ab4601d8865 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M src/ovf/ovfenvelope.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43d530cf1f826834672fd7cc4cb93ab4601d8865 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase
by mkublin＠redhat.com 23 Apr '13

23 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase ...................................................................... engine: Introducing using of Infinispan cache at TimeoutBase The TimeoutBase was used for the following purpose: 1. The audit event which has expiration time was put to it internal cache 2. If the same event was tried to put again and it is expired, it was written to DB Sound simple but a following implementation contains: 1. Memory leak - if we never tried to put event when it was already expired, internal cache never will be cleared 2. Restart - restart in the middle , event will be never send to DB Solution: I decided to use infinispan cache, from now if event has expiration time and it not contains in cache it will be written to DB. If event is contains in cache it will be skipped. The cache has putIfAbsent() API which is similar to ConcurrentHashMap API, the entries are added to cache with lifespan and will be cleared automatically by cache. Change-Id: I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/conf/standalone.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java M backend/manager/modules/utils/pom.xml A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/fedora/engine-service.xml.in M pom.xml 15 files changed, 127 insertions(+), 136 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactoring GlusterManager
by sanjal＠redhat.com 23 Apr '13

23 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactoring GlusterManager ...................................................................... engine: Refactoring GlusterManager Renamed GlusterManager to GlusterSyncJob. Added a base class GlusterJob that all gluster job classes can extend from. Created a class GlusterJobsManager that's responsible for scheduling gluster jobs. Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java 5 files changed, 206 insertions(+), 171 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/13944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add repo_file_id to repo_file_meta_data
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add repo_file_id to repo_file_meta_data ...................................................................... core: add repo_file_id to repo_file_meta_data In order to support image repositories that define an id and a friendly name for the images the two fields have been separated. Change-Id: I2791fa22820fc021938709f4a921ab4d6213fab7 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/repo_files_meta_data_sp.sql A backend/manager/dbscripts/upgrade/03_03_0050_repo_file_id.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoFileMetaData.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 15 files changed, 78 insertions(+), 36 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2791fa22820fc021938709f4a921ab4d6213fab7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: unit test for isCpuPinningValid
by lhornyak＠redhat.com 22 Apr '13

22 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: unit test for isCpuPinningValid ...................................................................... engine: unit test for isCpuPinningValid Adds a negative test for the case when there is pinning but no pinned to a host. Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: List/Show suggests parent+child as single param #950398
by mpastern＠redhat.com 22 Apr '13

22 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: List/Show suggests parent+child as single param #950398 ...................................................................... cli: List/Show suggests parent+child as single param #950398 Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950398 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py M src/ovirtcli/utils/methodhelper.py 2 files changed, 38 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: List/Show suggests parent+child as single param #950398
by mpastern＠redhat.com 22 Apr '13

22 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: List/Show suggests parent+child as single param #950398 ...................................................................... cli: List/Show suggests parent+child as single param #950398 Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950398 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py M src/ovirtcli/utils/methodhelper.py 2 files changed, 39 insertions(+), 14 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PerformImagesChecks no check for no disks
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: PerformImagesChecks no check for no disks ...................................................................... core: PerformImagesChecks no check for no disks Removed the check for no image disks from PerfomImagesChecks: creating a template, creating a snapshot and removing a snapshot should also work on diskless VMs, however useless it may be. Move VM has this check explicitly defined in its canDoAction, and is deprecated, regardless. After this change, there is no difference between PerformImagesChecks and checkDiskImages, so the ltater (which was private) was removed, and the code inlined into PerformImagesChecks. Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 2 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove ImagesHandler.PerformImagesChecks
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove ImagesHandler.PerformImagesChecks ...................................................................... core: Remove ImagesHandler.PerformImagesChecks After the recent changes, PerformImagesChecks had the following functionality: For each disk: - GetImageInfo from VDSM - if it does not exist, fail - if it's status is different from the engine's status, update the engine's status. Analyzing ImageStatus' different values, this validation is useless: - OK: The engine did not issue any command regarding this image. It may have been manually removed from the storage itself, but that could also happen right after the check finishes successfully. - LOCKED: The engine is in the middle of performing a command on the image. It's status in VDSM is meaningless, as it may change any moment now. - ILLEGAL/INVALID: The engine issued a command on the image, and it was interrupted somehow (e.g., restart, network failure, etc.). The image may have been partly or fully compromised, and it cannot be trusted anyway. In conclusion, this validation NEVER returns any useful information, and thus could (and should!) be removed. For good measures, an additional validation that the disks aren't ILLEGAL in the engine side was added to the commands where it was missing, just to be safe. Change-Id: I983a4c3a016909385ec16f21803ef3a82e4dcaf6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 5 files changed, 3 insertions(+), 67 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I983a4c3a016909385ec16f21803ef3a82e4dcaf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: we are fencing a host when putting it in...
by emesika＠redhat.com 22 Apr '13

22 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core: we are fencing a host when putting it in... ...................................................................... core: we are fencing a host when putting it in... core: we are fencing a host when putting it in maintenance after failed reinstall Enabling moving a Host to maintainance from non-operational status Change-Id: Id4e2dd45352867ccf67bc7f824570f855f77e2f1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906389 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e2dd45352867ccf67bc7f824570f855f77e2f1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: New Network dialog checks system tree DC
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: New Network dialog checks system tree DC ...................................................................... webadmin: New Network dialog checks system tree DC The dialog now looks at the selected item in the system tree, and if it has a data center ancestor (i.e. it's not the system node), then the DC list box in the new network dialog is grayed out and populated accordingly. Change-Id: Iae792afee7a8ada1b91c9db2bb0a0166cb2e2ad5 Bug-Url: https://bugzilla.redhat.com/953054 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae792afee7a8ada1b91c9db2bb0a0166cb2e2ad5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix tooltip localization
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: userportal: Fix tooltip localization ...................................................................... userportal: Fix tooltip localization Tooltip of quota status bar included unlocalized text. Change-Id: I6398f3c6dfe8c2949f493059532e1e43093173b5 Bug-Url: https://bugzilla.redhat.com/953315 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationTemplates.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6398f3c6dfe8c2949f493059532e1e43093173b5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Color Setup Networks label when operation invalid
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Color Setup Networks label when operation invalid ...................................................................... webadmin: Color Setup Networks label when operation invalid To make the status label more noticeable in case of an error, added red coloring when a drag operation is completed. Change-Id: Idbc6a77c1111dbad0c89a3c7f38b537eb1673c3e Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/OperationCadidateEventArgs.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 5 files changed, 61 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbc6a77c1111dbad0c89a3c7f38b537eb1673c3e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Method invokes inefficient new String constructor
by shavivi＠redhat.com 22 Apr '13

22 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Method invokes inefficient new String constructor ...................................................................... findbugs: Method invokes inefficient new String constructor Change-Id: Iead8eb1db18c8d08e536f27b03e1f3adb25c89d9 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iead8eb1db18c8d08e536f27b03e1f3adb25c89d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: reduce duplicate code related to run-once capabili...
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: frontend: reduce duplicate code related to run-once capability - cont ...................................................................... frontend: reduce duplicate code related to run-once capability - cont This patch is the last part in the effort to reduce the duplicate code related to run-once capability. The creation of UICommands that are related to run-once capability was moved into the run-once models, and the event-handling code that is tightly related to the run-once model was also moved into the run-once models. Change-Id: I774524ca7bd4af35d8c3140e2ce23f369d727e28 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java 7 files changed, 82 insertions(+), 67 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I774524ca7bd4af35d8c3140e2ce23f369d727e28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: fluent API instead of temporary fields
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: frontend: fluent API instead of temporary fields ...................................................................... frontend: fluent API instead of temporary fields This patch replace the usage of temporary fields with fluent API - where setters return a reference to "this" which can be used to make further calls on the return value of the setter method. Not all setters were changed in this patch of course, only those that were relevant to simplify the code which is related to run-once capability (this patch is part of few patches that were done lately to refactor the areas around run-once capability in the frontend) This patch also includes: 1. remove the auto-assign entity setting which is not needed because it is already done in WebadminRunOnceModel#init method 2. move the duplicate code of display protocol settings in run-once mode from UserPortalListModel and VmListModel to be just in RunOnceModel Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 10 files changed, 65 insertions(+), 108 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52bfe6b084ecc0643a5a45a1fb9a1170b415ed15 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: reduce duplicate code related to run-once capabili...
by alkaplan＠redhat.com 22 Apr '13

22 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: frontend: reduce duplicate code related to run-once capability ...................................................................... frontend: reduce duplicate code related to run-once capability Changed RunOnceModel to be abstract and add UserPortalRunOnceModel that extends it. the code that initialize the run-once-model in the user portal was moved from UserPortalListModel to it. Add WebadminRunOnceModel that extends RunOnceModel for the web-admin. the code that initializes the run-once-model in the web-admin was moved from VmListModel to it. Remove duplicate code in the run-once model of the webadmin and the run-once model of the user-portal, and put the common code in RunOnceModel instead. Change-Id: I6561df71f093e2739e689722ead4f85428c04d06 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java 5 files changed, 387 insertions(+), 587 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13207 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6561df71f093e2739e689722ead4f85428c04d06 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Double assignment of local variable
by shavivi＠redhat.com 22 Apr '13

22 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Double assignment of local variable ...................................................................... findbugs: Double assignment of local variable Change-Id: Ia2c5d0d53b69fa2f152e3f30f693e014d329e48a Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14119 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c5d0d53b69fa2f152e3f30f693e014d329e48a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: moved gluster sources to gluster package
by sanjal＠redhat.com 22 Apr '13

22 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: moved gluster sources to gluster package ...................................................................... gluster: moved gluster sources to gluster package Moved some of the xmlrpc related gluster specific sources to a gluster specific pacakge. Change-Id: Id89a115468c0f585234e1c0efc44888a40a2c180 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeOptionsInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeProfileInfoVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServersListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServersListVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeOptionsInfoReturnForXmlRpc.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 10 files changed, 16 insertions(+), 16 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id89a115468c0f585234e1c0efc44888a40a2c180 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: Classes that implements Comparator need to impleme...
by shavivi＠redhat.com 22 Apr '13

22 Apr '13

Hello ovirt-engine-commits, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/14116 to review the following change. Change subject: findbugs: Classes that implements Comparator need to implement Serializable ...................................................................... findbugs: Classes that implements Comparator need to implement Serializable Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/14116/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java index 15ddb57..3dcc95c 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java @@ -1270,7 +1270,7 @@ } } - public final static class InterfaceComparator implements Comparator<VdsNetworkInterface> { + public final static class InterfaceComparator implements Comparator<VdsNetworkInterface>, Serializable { LexoNumericComparator lexoNumeric = new LexoNumericComparator(); @@ -1281,7 +1281,7 @@ } - public final static class NetworkComparator implements Comparator<Network> { + public final static class NetworkComparator implements Comparator<Network>, Serializable { private LexoNumericComparator lexoNumeric = new LexoNumericComparator(); @@ -1298,7 +1298,7 @@ } } - public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel> { + public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel>, Serializable { private LexoNumericComparator lexoNumeric = new LexoNumericComparator(); -- To view, visit http://gerrit.ovirt.org/14116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org>

1 1

Change in ovirt-engine[master]: packaging: build: fix branding when pom are enabled
by juan.hernandez＠redhat.com 22 Apr '13

22 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: build: fix branding when pom are enabled ...................................................................... packaging: build: fix branding when pom are enabled Change-Id: If076de7abdeed4bf59a7dfe365527b596c95264d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If076de7abdeed4bf59a7dfe365527b596c95264d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: update version of postgresql driver
by juan.hernandez＠redhat.com 22 Apr '13

22 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: update version of postgresql driver ...................................................................... packaging: update version of postgresql driver For some reason the 9.1-901.jdbc4 downloads 9.0 driver, may be a problem in maven mirrors, as download directly from search downloads currect version. 9.1-901-1.jdbc4 works correctly. Change-Id: I57fab39530805a0c9770b22b423162027631ccb8 Bug-Url: https://bugzilla.redhat.com/923260 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> (cherry picked from commit f091b095c4ab37345bb677a0b47e5832540054b9) --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57fab39530805a0c9770b22b423162027631ccb8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engine: upgrade postgres jdbc
by juan.hernandez＠redhat.com 22 Apr '13

22 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: engine: upgrade postgres jdbc ...................................................................... engine: upgrade postgres jdbc - Upgrades PostgreSQL JDBC to version 9.1-901.jdbc4 - Removed postgresql.version from the pom, it was redundant with postgres.jdbc.version Change-Id: I3bd31a6aae01e983f0ef995a57d5ab4884e9691b Bug-Url: https://bugzilla.redhat.com/923260 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> (cherry picked from commit 743d03d75a6a1ac84b8a9df29c5d494b945de646) --- M pom.xml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bd31a6aae01e983f0ef995a57d5ab4884e9691b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing wrong instanceof usage at SrvRecord
by yzaslavs＠redhat.com 22 Apr '13

22 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing wrong instanceof usage at SrvRecord ...................................................................... core: Fixing wrong instanceof usage at SrvRecord The following fix fixes wrong usage of instanceof Change-Id: Ia9051d60924c9330cf7d18a29a82d61b597968fa Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9051d60924c9330cf7d18a29a82d61b597968fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove checkIsValid from PerformImagesChecks
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove checkIsValid from PerformImagesChecks ...................................................................... core: Remove checkIsValid from PerformImagesChecks The recent changes to ImagesHandler.PerformImagesChecks have left the checkIsValid parameter completely useless: If it's true, both checkImagesIllegalInVdsm and checkImagesExist are evaluated, and their respective tests are run if they are true. If it's false, neither test is run. In conclusion - it has no extra meaning, and can be removed. This patch removes it from PerformImagesChecks' signature and all its usages. In case both other booleans are false, the function call is removed altogether. In case removing this function allows to remove some additional parameters from the calling function (e.g., as is the can in VmRunHandler), that is done as well. Change-Id: I0055151c619dcf9e62144d280714c165a01408e8 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 13 files changed, 18 insertions(+), 80 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0055151c619dcf9e62144d280714c165a01408e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable Gluster hooks
by kmayilsa＠redhat.com 22 Apr '13

22 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: Disable Gluster hooks ...................................................................... webadmin: Disable Gluster hooks Disable action added for Gluster Hooks sub tab in cluster. Change-Id: I18d86bf20931482b6389c542a037967a70b622c2 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java 5 files changed, 141 insertions(+), 13 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18d86bf20931482b6389c542a037967a70b622c2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix quota not counted when run VM from pool
by gchaplik＠redhat.com 22 Apr '13

22 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix quota not counted when run VM from pool ...................................................................... core: Fix quota not counted when run VM from pool When running VM from a VM-pool the quota (CPU, Memory) was not counted. The reason was that AttachUserToVmFromPoolAndRunCommand was not QuotaVdsDependant. AttachUserToVmFromPoolAndRunCommand was changed to implement QuotaVdsDependant. Change-Id: Iafcdf2462de9a2f8bb4132af9173f5ed4ead47cf Bug-Url: https://bugzilla.redhat.com/953118 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 34 insertions(+), 8 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafcdf2462de9a2f8bb4132af9173f5ed4ead47cf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused ImagesHandlerActionParameters
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused ImagesHandlerActionParameters ...................................................................... core: Remove unused ImagesHandlerActionParameters Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesHandlerActionParameters.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove image status check from ImagesHandler
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove image status check from ImagesHandler ...................................................................... core: Remove image status check from ImagesHandler Extracted all image status checks from ImagesHandler and moved them to the new DiskImagesValidator class, as a step in the effort to decouple ImagesHandler.PerformImagesChecks. Change-Id: I7c26d6cf37227aded9318523f0a807e19eeaa7bc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 17 files changed, 260 insertions(+), 80 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c26d6cf37227aded9318523f0a807e19eeaa7bc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove checkImagesLocked(vmId, messages)
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove checkImagesLocked(vmId, messages) ...................................................................... core: Remove checkImagesLocked(vmId, messages) Removed ImagesHandler.checkImagesLocked(Guid vmId, List<String messages), as ImagesHandler should not know about VMs. Wherever it was used (two places - AddVmFromSnapshot and LiveMigrateVmDisks), it was replaced with a direct call to DiskDao and then a simpler call to ImagesHandler.checkImagesLocked (messages, disks). Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 3 files changed, 11 insertions(+), 15 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae603af05f4b90e8c021113779031846a56c99ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: spelling: s/clsuter/cluster
by amureini＠redhat.com 21 Apr '13

21 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: spelling: s/clsuter/cluster ...................................................................... spelling: s/clsuter/cluster Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmValidationUtils.java 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc54bd40f76037c3c58dca8da35d14a69f89283f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: use DiskImage.copyOf in getAllDisks query
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: core: use DiskImage.copyOf in getAllDisks query ...................................................................... core: use DiskImage.copyOf in getAllDisks query GetAllDisksByStorageDomainIdQuery: add a copy of the active DiskImage to snapshots list [adding it as is causes infinte recursion in DiskImage->hashCode()] Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Bug-Url: https://bugzilla.redhat.com/951909 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: wrong quota(s) in dc-quota subtab
by gchaplik＠redhat.com 21 Apr '13

21 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: wrong quota(s) in dc-quota subtab ...................................................................... webadmin: wrong quota(s) in dc-quota subtab Caused by a call to super.syncSearch(), which created a wrong (another) query to server. Change-Id: I3f9f347b15633ab1e8215a45816c7aba1149252b Bug-Url: https://bugzilla.redhat.com/950536 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterQuotaListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14050 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f9f347b15633ab1e8215a45816c7aba1149252b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: When implementing compareTo implement Object.equal...
by shavivi＠redhat.com 21 Apr '13

21 Apr '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: When implementing compareTo implement Object.equals as well ...................................................................... findbugs: When implementing compareTo implement Object.equals as well Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkStatistics.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java 3 files changed, 117 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d3ee3cded96c33c4e833fdca09461b7825cf07 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Don't mandate a network when adding a template NIC
by mkolesni＠redhat.com 21 Apr '13

21 Apr '13

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Don't mandate a network when adding a template NIC ...................................................................... restapi: Don't mandate a network when adding a template NIC In template context, it should be possible to add a NIC even without the network id/name since the network unlinking feature was pushed. The backend will know to fail the action if an empty network is sent and the feature is unsupported. Change-Id: Id5b1953178f4ff5e04a71688d8ccec5d3c789395 Bug-Url: https://bugzilla.redhat.com/952647 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateNicsResource.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5b1953178f4ff5e04a71688d8ccec5d3c789395 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: resources->quota updating
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: resources->quota updating ...................................................................... userportal: resources->quota updating - Fixed resources quota class cast exception causing quota not to update. Change-Id: Iefbbd93e407f40070bf187557560fb2f73a41c0b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928967 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/resources/VmTable.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefbbd93e407f40070bf187557560fb2f73a41c0b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Improved sorting in Setup Networks sub menu
by alkaplan＠redhat.com 21 Apr '13

21 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Improved sorting in Setup Networks sub menu ...................................................................... webadmin: Improved sorting in Setup Networks sub menu Items are now sorted "lexoNumerically" rather than lexicographically. Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: invoke event dialog from sub-tabs
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: invoke event dialog from sub-tabs ...................................................................... webadmin: invoke event dialog from sub-tabs Display event dialog on double-click (or right-click -> Details) an event in Events sub-tabs. Change-Id: I88c2ddbfc8db4e4bd476bb5e1a595274197c2a55 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/DataCenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/TemplateModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/UserModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VirtualMachineModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabEventView.java 9 files changed, 137 insertions(+), 17 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88c2ddbfc8db4e4bd476bb5e1a595274197c2a55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: Error type "brick" does not exist." on replace brick
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Error type "brick" does not exist." on replace brick ...................................................................... cli: Error type "brick" does not exist." on replace brick When trying to perform replace-brick operation from the ovirt-shell we get an error message error: type "brick" does not exist. Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Bug-Url: https://bugzilla.redhat.com/923196 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/action.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Error type "brick" does not exist." on replace brick
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Error type "brick" does not exist." on replace brick ...................................................................... cli: Error type "brick" does not exist." on replace brick When trying to perform replace-brick operation from the ovirt-shell we get an error message error: type "brick" does not exist. Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Bug-Url: https://bugzilla.redhat.com/923196 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/action.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff900ec7e7ea8ebde3914ac28e5f72b426cf6544 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Networks General sub-tab- Role section has misplac...
by alkaplan＠redhat.com 21 Apr '13

21 Apr '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Networks General sub-tab- Role section has misplaced comma ...................................................................... webadmin: Networks General sub-tab- Role section has misplaced comma Items listed on the right of "Role" has an odd space before comma. The space should be after the comma. Change-Id: I19cc13aff4a2bf9d2e6c97e282a6fc6103bb12e8 Bug-Url: https://bugzilla.redhat.com/949759 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19cc13aff4a2bf9d2e6c97e282a6fc6103bb12e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: unclear error message when using unsupported 2 levels a...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: unclear error message when using unsupported 2 levels attribute(#949642) ...................................................................... cli: unclear error message when using unsupported 2 levels attribute(#949642) unclear error message (error: type "%s" does not exist.) when using unsupported 2 levels attribute. when using unsupported 2 levels attribute (both are not supported) the returned error is not user friendly Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854 Bug-Url: https://bugzilla.redhat.com/949642 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: correlation_id is not attached to update command(#95044...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: correlation_id is not attached to update command(#950441) ...................................................................... cli: correlation_id is not attached to update command(#950441) update command does not attach correlation-id to request header. Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016 Bug-Url: https://bugzilla.redhat.com/950441 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/update.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: truncated text in Storage-Disks sub-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in Storage-Disks sub-tab ...................................................................... webadmin: truncated text in Storage-Disks sub-tab Fixed truncated headers in Storage -> Disks sub-tab. Change-Id: I4adca437d72c8abb75f47a15bb14536d3b5d2c4d Bug-Url: https://bugzilla.redhat.com/922731 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageDiskView.java 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4adca437d72c8abb75f47a15bb14536d3b5d2c4d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: truncated text in VMs-Snapshots sub-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in VMs-Snapshots sub-tab ...................................................................... webadmin: truncated text in VMs-Snapshots sub-tab Fixed truncated headers in VMs -> Snapshots sub-tab. Change-Id: I2e9586f77343645a74727452e58052c8b659e5fc Bug-Url: https://bugzilla.redhat.com/951067 Bug-Url: https://bugzilla.redhat.com/950289 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9586f77343645a74727452e58052c8b659e5fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: build: use external gettext
by knesenko＠redhat.com 21 Apr '13

21 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: build: use external gettext ...................................................................... build: use external gettext To avoid a prartial redistribution of gettext, the macro AM_GNU_GETTEXT has been configured with 'external' intlsymbol. Change-Id: I59f64d78f2f4822a60e6abf3a1c5595cede8dbe7 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-log-collector.spec.in 4 files changed, 2 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59f64d78f2f4822a60e6abf3a1c5595cede8dbe7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: use external gettext
by knesenko＠redhat.com 21 Apr '13

21 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: build: use external gettext ...................................................................... build: use external gettext To avoid a prartial redistribution of gettext, the macro AM_GNU_GETTEXT has been configured with 'external' intlsymbol. Change-Id: I22bab6fb8e4e3dbeb0f0ce5d513cfbb75b8a7402 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-iso-uploader.spec.in 4 files changed, 2 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22bab6fb8e4e3dbeb0f0ce5d513cfbb75b8a7402 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: build: use external gettext
by knesenko＠redhat.com 21 Apr '13

21 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: build: use external gettext ...................................................................... build: use external gettext To avoid a prartial redistribution of gettext, the macro AM_GNU_GETTEXT has been configured with 'external' intlsymbol. Change-Id: I8d02b81778787738c0f62c4051c39a3c62c7a1ff Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac M ovirt-image-uploader.spec.in 4 files changed, 2 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d02b81778787738c0f62c4051c39a3c62c7a1ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: truncated text in Disks main-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in Disks main-tab ...................................................................... webadmin: truncated text in Disks main-tab Fixed truncated headers in Disks main-tab. Change-Id: I2d8a8e939e4f1b09ff880a559da7899d56cd036d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d8a8e939e4f1b09ff880a559da7899d56cd036d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0