April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: load image refreshing data
by vszocs＠redhat.com 24 Apr '13

24 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: load image refreshing data ...................................................................... webadmin: load image refreshing data - Fixed when switching main tabs always show 'loading' image so the user has feedback something is happening. - Fixed when switching to sub tab with grid always show loading image so the user has feedback something is happening. - Added code to give user feedback when manually refreshing grid using the refresh button. - Automatic refresh unchanged to simulate 'push' technology while we are still doing a data pull. Change-Id: I8be80df57eafc4244c57029f8260d4d67c47b3f4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907491 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/refresh/AbstractRefreshManager.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java 4 files changed, 34 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12946 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8be80df57eafc4244c57029f8260d4d67c47b3f4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: split service to allow code reuse
by oschreib＠redhat.com 24 Apr '13

24 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: split service to allow code reuse ...................................................................... packaging: engine-service: split service to allow code reuse this will allow to reuse effort to implement other services. Change-Id: Ie912a502f220417e72efbd2f5b87c5674525f79b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/services/engine-service.py A packaging/services/service.py 3 files changed, 780 insertions(+), 688 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie912a502f220417e72efbd2f5b87c5674525f79b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: move generated code out of main s...
by oschreib＠redhat.com 24 Apr '13

24 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: move generated code out of main source ...................................................................... packaging: engine-service: move generated code out of main source this ease maintenance, as main source is regular script. Change-Id: I1b55fbb7d9ad3513c429b190379825aa5a91c13a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile A packaging/services/__init__.py A packaging/services/config.py.in R packaging/services/engine-service.py 5 files changed, 50 insertions(+), 12 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b55fbb7d9ad3513c429b190379825aa5a91c13a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: rename service directory to servi...
by oschreib＠redhat.com 24 Apr '13

24 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: rename service directory to services ...................................................................... packaging: engine-service: rename service directory to services we are about to have more than single service Change-Id: I918264883c69f3429a45ccb854c8f23c4f1d55e7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in M packaging/services/engine-service.py.in M packaging/services/engine-service.systemd.in M packaging/services/engine-service.sysv.in 5 files changed, 10 insertions(+), 10 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I918264883c69f3429a45ccb854c8f23c4f1d55e7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: move service out of fedora into o...
by oschreib＠redhat.com 24 Apr '13

24 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: move service out of fedora into own directory ...................................................................... packaging: engine-service: move service out of fedora into own directory service is working in fedora, rhel, cenots, gentoo, ubuntu. service resources are installed at one directory at target, reorder filesystem structure within source tree to be similar. Change-Id: I38c2653509795ae04c190c4a84f00f53410fa983 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore M Makefile M packaging/fedora/spec/ovirt-engine.spec.in R packaging/services/engine-service-logging.properties.in R packaging/services/engine-service.py.in R packaging/services/engine-service.systemd.in R packaging/services/engine-service.sysv.in R packaging/services/engine-service.xml.in 8 files changed, 13 insertions(+), 13 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38c2653509795ae04c190c4a84f00f53410fa983 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated running taskcleaner utility
by juan.hernandez＠redhat.com 24 Apr '13

24 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated running taskcleaner utility ...................................................................... packaging: Updated running taskcleaner utility This patch fixes the incomplete patch http://gerrit.ovirt.org/#/c/13567 and updates a list of parameters for executing taskcleaner utility in a task-cleanup mode. Change-Id: Ia76e5f3e073a1c8fe37de768a184f80f18e39c02 Bug-Url: https://bugzilla.redhat.com/951092 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia76e5f3e073a1c8fe37de768a184f80f18e39c02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: default rpm packaging to build complete feature s...
by oschreib＠redhat.com 24 Apr '13

24 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: default rpm packaging to build complete feature set ...................................................................... packaging: default rpm packaging to build complete feature set executing rpmbuild -tb <tarball> should create fully functional product, including all features and translations. so far build did not provide extra locales available in source. because gwt permutations takes a lot of time to be built, the following macros were added to ease creation of partial packages: ovirt_build_quick quick build, good for automation, no GWT permutations, no locales. ovirt_build_minimal minimal build, good for development, only firefox support, no locales. ovirt_build_gwt build gwt components, default yes. ovirt_build_locales build locales, default yes. example: rpmbuild --define="ovirt_build_minimal 1" -tb <tarball> Change-Id: I4fb610db6c6b6f9b209c816609613e47d7520baf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 29 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb610db6c6b6f9b209c816609613e47d7520baf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Update VM status if host is not available
by ofrenkel＠redhat.com 24 Apr '13

24 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Update VM status if host is not available ...................................................................... core: Update VM status if host is not available The VM status is set to Unknown if the host is marked as non-responsive (after timeout). The status icon in the WebAdmin change reflects the Unknown status. When the host is available again (Up status), the change from Unknown status to real status is logged into the audit log (VM status restored). Change-Id: If569de776dfb9c97589603040e7a7f620409c361 Bug-Url: https://bugzilla.redhat.com/921521 Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 7 files changed, 17 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If569de776dfb9c97589603040e7a7f620409c361 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: do not allow multiple same ips for engine
by Alon Bar-Lev 24 Apr '13

24 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: do not allow multiple same ips for engine ...................................................................... vdsm: bridge: do not allow multiple same ips for engine Change-Id: I3fd95e61d1b1a405650f164d547004151d9f5f68 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/bridge.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14209 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd95e61d1b1a405650f164d547004151d9f5f68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: i18n splash screen.
by vszocs＠redhat.com 24 Apr '13

24 Apr '13

Vojtech Szocs has submitted this change and it was merged. Change subject: core: i18n splash screen. ...................................................................... core: i18n splash screen. - Added SplashServlet to i18n the splash page. - Added LocaleFilter to automatically detect locale based on browser preferences, or parameters. Order of importance: 1. parameter. 2. Cookie. 3. Browser preferences. 4. Default (en-US). - Added a LocaleUtils class to capture common methods. - Added triangle_down_gray image. - Added unit tests for all used classes. Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c6 Bug-Url: https://bugzilla.redhat.com/838456 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/DocsServlet.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/LocaleFilter.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/SplashServlet.java A backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/languages.properties A backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/messages.properties A backend/manager/modules/root/src/main/webapp/WEB-INF/index.jsp M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/ovirt-engine-style.css A backend/manager/modules/root/src/main/webapp/splash.js A backend/manager/modules/root/src/main/webapp/triangle_down_gray.gif A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/LocaleFilterTest.java A backend/manager/modules/root/src/test/java/org/ovirt/engine/core/SplashServletTest.java M backend/manager/modules/utils/pom.xml 13 files changed, 555 insertions(+), 3 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0