Change in ovirt-engine[master]: webadmin: remove table focus.
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: remove table focus.
......................................................................
webadmin: remove table focus.
- Removed focus from AbstractActionTable when selecting
a row. This stops a scroll on refresh of the table.
- Undo most of Change-Id: I0f34a369ba1074456614ad65b7e4cc77af963853
as that was just bandaid instead of a fix.
Change-Id: Ie6945d18bcd30b02d4428d20d83bf194fcf207eb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882618
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
1 file changed, 8 insertions(+), 13 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6945d18bcd30b02d4428d20d83bf194fcf207eb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years
Change in ovirt-engine[master]: engine:Fixing findbug error in gluster hooks list
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine:Fixing findbug error in gluster hooks list
......................................................................
engine:Fixing findbug error in gluster hooks list
Fixed a findbug error in GlusterHooksListReturnForXmlRpc
where hooks variable was not initialized.
Change-Id: I882d70750e4a55934f81ef81c8b0bb1c97256d7b
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Shireesh Anjal: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/14187
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I882d70750e4a55934f81ef81c8b0bb1c97256d7b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years
Change in ovirt-engine[master]: gluster: VDS command to fetch gluster services
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: VDS command to fetch gluster services
......................................................................
gluster: VDS command to fetch gluster services
- VDS Command
- VDS Parameters class
- XmlRpc return type
- Entries in VDSCommandType, IVdsServer, VdsServerConnector, VdsServerWrapper
- New error code in VdcBllErrors and VdsmErrors
- New enum for service statuses (GlusterServiceStatus)
- Refactored ServiceInfo to use GlusterServiceStatus instead of
GlusterStats
Change-Id: I0c59a6f153fdcb584de206ca389a2ef7ce30fd80
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServiceStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ServiceInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterServicesListVDSParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesListVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeStatusReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
15 files changed, 175 insertions(+), 5 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c59a6f153fdcb584de206ca389a2ef7ce30fd80
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years
Change in ovirt-engine[master]: set correct storage domain id
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: set correct storage domain id
......................................................................
set correct storage domain id
When executing RecoveryStoragePoolCommand, the master storage domain is
loaded within the CDA method for the various checks - later on, if we do
get for executing the master domain id might have changed meanwhile.
The reload is done also today, but outside of the event - in this patch
i just moved it to happen within till further changes to that
mechanism - as it prevented the added domain to be marked the master,
version not be incremented..etc.
Change-Id: I7cce29e172dc7923efdd50997abe586b506f2fbf
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=955569
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cce29e172dc7923efdd50997abe586b506f2fbf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
11 years
Change in ovirt-engine[master]: engine: TimeoutBase - Improving memory footprint - continue
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: TimeoutBase - Improving memory footprint - continue
......................................................................
engine: TimeoutBase - Improving memory footprint - continue
After changes inside TimeoutBase, I found out that the cache is used only as place holder,
so instead of putting TimeouBase object to cache I decided to put String, also possible to put
some king const Object but, I think it is not make any difference
Benefit - String should take less memory than TimeoutBase will all loaded objects from DB
Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java
2 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I795019a35a57fef688296d9f1083bc77c9272bc7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: use local TX in AddVm flow
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: use local TX in AddVm flow
......................................................................
core: use local TX in AddVm flow
Taking VDS calls out of TX in Add VM Pool with VMs flow so long calls to
VDSM won't exceed the TX timeout.
To understand the commands that are influenced by this concider this
call tree:
<pre>
AddVmPoolWithVMsCommand
|
-> Lock tepmlate status
|
-> AddVmAndAttachToPoolCommand
|
-> AddVMCommand
|
-> save static,dynamic etc. (new TX + compensation)
|
-> GetImageInfo - VDSM call (out of TX)
|
-> set image status (new TX + compensation)
|
-> CreateSnapshot - VDSM call (out of TX)
|
-> update old|save new disk image (new TX + compensation)
Bug-Url: https://bugzilla.redhat.com/948282
Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndAttachToPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
5 files changed, 85 insertions(+), 51 deletions(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years
Change in ovirt-engine[master]: webadmin: fix 64 bit VM memory limit validation
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: fix 64 bit VM memory limit validation
......................................................................
webadmin: fix 64 bit VM memory limit validation
The supported maximum for 64 bit VMs is 2TB
Change-Id: I2a32b1e16adff67a5c4656106e10107d840a61fb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=954021
Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a32b1e16adff67a5c4656106e10107d840a61fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years
Change in ovirt-engine[master]: findbugs: Method invokes inefficient Number constructor
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: Method invokes inefficient Number constructor
......................................................................
findbugs: Method invokes inefficient Number constructor
Change-Id: Id868d7fe02fde3af616cef32328a3a893582f4e9
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java
M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
20 files changed, 44 insertions(+), 44 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id868d7fe02fde3af616cef32328a3a893582f4e9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: findbugs: use Boolean.valueOf instead of Boolean constructor
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: use Boolean.valueOf instead of Boolean constructor
......................................................................
findbugs: use Boolean.valueOf instead of Boolean constructor
Change-Id: I114592d410251a6d51eee79cb3c63fa3a2936e54
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CopyImageVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/DeleteImageGroupVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MergeSnapshotsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/MoveImageGroupVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmLogoffVDSCommand.java
7 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I114592d410251a6d51eee79cb3c63fa3a2936e54
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years
Change in ovirt-engine[master]: userportal: prestarted VMs not updated
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal: prestarted VMs not updated
......................................................................
userportal: prestarted VMs not updated
Have a pool with prestarted VMs. Take a VM from it in user portal.
The result is that the title of the VM gets changed, but nothing else
making it impossible to connect to it.
The problem was, that the PoolItemBehavior.PostTakeVm() loaded
the taken VM from the server and replaced the entity in the
UserPortalItemModel. This does not trigger the
DataBoundTabModelProvider.updateData. On the next refresh cycle,
the optimization logic detects no change in this entity (because
it has really been replaced) and does not trigger the re-rendering
of it.
As the logic of loading the just taken VM from the server was only
in this one place making the behavior incosistent comparing to
all other actions like start/stop/pause etc this logic has been
removed leaving the re-rendering to the refresh cycle.
Change-Id: Ia910ac50675d4a1e8db0f4fd01ce50b93a8d9f34
Bug-Url: https://bugzilla.redhat.com/953690
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14148
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia910ac50675d4a1e8db0f4fd01ce50b93a8d9f34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years