Change in ovirt-engine[master]: engine: remove DBUser.desktopDevice
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: remove DBUser.desktopDevice
......................................................................
engine: remove DBUser.desktopDevice
desktopDevice property was completely unused, so now it is removed
Change-Id: I0a9cdcb4893c6643ef543a2fb22cc168336e36a0
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
A backend/manager/dbscripts/upgrade/03_03_0060_drop_desktop_device.sql
M backend/manager/dbscripts/user_sp.sql
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
7 files changed, 8 insertions(+), 47 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a9cdcb4893c6643ef543a2fb22cc168336e36a0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: removal of unneeded member/method
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: removal of unneeded member/method
......................................................................
core: removal of unneeded member/method
StorageDomainCommandBase has a private member called _storagePool and a method
called getStoragePool() which overrides the getStoragePool() method
(which has the same implementation) defined at AuditLogableBase. The setter
method isn't being overriden, which means that calling getStoragePool() on
StorageDomainCommandBase and lower classes in it's hierarchy will return the
value of the _storagePool member defined in StorageDomainCommandBase, while
using the setter will set the value of the storage_pool member defined in
AuditLogableBase, thus it won't affect the value of the recieved storage
pool.
In this patch I just removed the storage_pool member defined within
StorageDomainCommandBase as it's unneeded (we already have that higher
in the hierarchy) and it's getter as they are unneeded.
Change-Id: Ie4746c35e2f5c37e672e47e56314d115c6b25025
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
1 file changed, 0 insertions(+), 13 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4746c35e2f5c37e672e47e56314d115c6b25025
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: engine: VDS command to get gluster host UUID
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: engine: VDS command to get gluster host UUID
......................................................................
engine: VDS command to get gluster host UUID
A new vds command is introduced to get the gluster uuid
of the host.
Change-Id: Ie73558f8c9469e1ce3710e4d77fa1072059267ad
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterHostUUIDVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
9 files changed, 53 insertions(+), 0 deletions(-)
Approvals:
Shireesh Anjal: Looks good to me, approved
Kanagaraj M: Verified
--
To view, visit http://gerrit.ovirt.org/13941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie73558f8c9469e1ce3710e4d77fa1072059267ad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 1 month
Change in ovirt-engine-cli[master]: cli: Ping command success message need to be rephrased(#9187...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Ping command success message need to be rephrased(#918749)
......................................................................
cli: Ping command success message need to be rephrased(#918749)
ovirt-shell ping success message needs to be rephrased.
Change-Id: I9db7fa5c022713448674f4204470a7c502a1cfe5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918749
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/cli/messages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12840
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9db7fa5c022713448674f4204470a7c502a1cfe5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Allow creating ISO domain on other file-based storages...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Allow creating ISO domain on other file-based storages except NFS
......................................................................
core: Allow creating ISO domain on other file-based storages except NFS
This patch allows creating ISO domain on file-based storage domain,
including localfs and posixfs. Even though localfs can't be shared
among the hosts in cluster, it could be useful in the case of no NFS available.
VM can be created on the host which has the ISO domain attached,
and then be migrated to any other host in the cluster or make a template
from it. This is also a good feature for POCs, all-in-one, etc.
Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddLocalStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStorageServerConnectionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 15 insertions(+), 42 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 1 month
Change in ovirt-engine[master]: core: Support importing iso domain on other file based stora...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Support importing iso domain on other file based storages except NFS.
......................................................................
core: Support importing iso domain on other file based storages except NFS.
This patch adds support for importing iso domain on file based storage,
including localfs storage and poxisfs storage.
Change-Id: Id04af5e4f43d4d96c5ddc316af73ee4a81384b52
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
8 files changed, 83 insertions(+), 47 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12916
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id04af5e4f43d4d96c5ddc316af73ee4a81384b52
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 1 month
Change in ovirt-engine-cli[cli_3.2]: cli: Error in "update network --cluster-identifier --usages-...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Error in "update network --cluster-identifier --usages-usage"
......................................................................
cli: Error in "update network --cluster-identifier --usages-usage"
When running update network command, in cluster context,
including --usages-usage option causes an error.
Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Bug-Url: https://bugzilla.redhat.com/950993
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 1 month
Change in ovirt-engine-cli[cli_3.2]: cli: spicec does not pass cert_file #953582
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: spicec does not pass cert_file #953582
......................................................................
cli: spicec does not pass cert_file #953582
Change-Id: I23dd056aaa69abfb39e812f70e8daa406e6ccd5c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953582
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/platform/posix/spice.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14160
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23dd056aaa69abfb39e812f70e8daa406e6ccd5c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 1 month
Change in ovirt-engine-cli[master]: cli: spicec does not pass cert_file #953582
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: spicec does not pass cert_file #953582
......................................................................
cli: spicec does not pass cert_file #953582
Change-Id: I23dd056aaa69abfb39e812f70e8daa406e6ccd5c
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=953582
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/platform/posix/spice.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14159
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23dd056aaa69abfb39e812f70e8daa406e6ccd5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 1 month
Change in ovirt-engine-cli[master]: cli: Error in "update network --cluster-identifier --usages-...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Error in "update network --cluster-identifier --usages-usage"
......................................................................
cli: Error in "update network --cluster-identifier --usages-usage"
When running update network command, in cluster context,
including --usages-usage option causes an error.
Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Bug-Url: https://bugzilla.redhat.com/950993
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a3347c4cd7397f0e58814c33bbf4b18e07547f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 1 month