April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: VDS command - gluster hooks list
by sanjal＠redhat.com 23 Apr '13

23 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: VDS command - gluster hooks list ...................................................................... engine: VDS command - gluster hooks list Gets the list of gluster hooks on a server. Change-Id: I46e47dda9717373d15264e0af942ce93d2293cb4 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java 10 files changed, 105 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46e47dda9717373d15264e0af942ce93d2293cb4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-image-uploader[master]: Remove sh bang from ovfenvelope.py.
by knesenko＠redhat.com 23 Apr '13

23 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: Remove sh bang from ovfenvelope.py. ...................................................................... Remove sh bang from ovfenvelope.py. Its not the script so we don't really need this sh bang there. Change-Id: I43d530cf1f826834672fd7cc4cb93ab4601d8865 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- M src/ovf/ovfenvelope.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43d530cf1f826834672fd7cc4cb93ab4601d8865 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Introducing using of Infinispan cache at TimeoutBase
by mkublin＠redhat.com 23 Apr '13

23 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Introducing using of Infinispan cache at TimeoutBase ...................................................................... engine: Introducing using of Infinispan cache at TimeoutBase The TimeoutBase was used for the following purpose: 1. The audit event which has expiration time was put to it internal cache 2. If the same event was tried to put again and it is expired, it was written to DB Sound simple but a following implementation contains: 1. Memory leak - if we never tried to put event when it was already expired, internal cache never will be cleared 2. Restart - restart in the middle , event will be never send to DB Solution: I decided to use infinispan cache, from now if event has expiration time and it not contains in cache it will be written to DB. If event is contains in cache it will be skipped. The cache has putIfAbsent() API which is similar to ConcurrentHashMap API, the entries are added to cache with lifespan and will be cleared automatically by cache. Change-Id: I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/conf/standalone.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBase.java M backend/manager/modules/dal/src/main/modules/org/ovirt/engine/core/dal/main/module.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/TimeoutBaseTest.java M backend/manager/modules/utils/pom.xml A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EngineEJBUtilsStrategy.java M backend/manager/modules/utils/src/main/modules/org/ovirt/engine/core/utils/main/module.xml M ear/pom.xml M ear/src/main/resources/META-INF/MANIFEST.MF M packaging/fedora/engine-service.xml.in M pom.xml 15 files changed, 127 insertions(+), 136 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbebb10c08c87d2c7fd4d7443d3e3b374541ed7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactoring GlusterManager
by sanjal＠redhat.com 23 Apr '13

23 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Refactoring GlusterManager ...................................................................... engine: Refactoring GlusterManager Renamed GlusterManager to GlusterSyncJob. Added a base class GlusterJob that all gluster job classes can extend from. Created a class GlusterJobsManager that's responsible for scheduling gluster jobs. Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJob.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJobTest.java 5 files changed, 206 insertions(+), 171 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/13944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61d851928f18da22b352b7be9d6ccaf4382e7930 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add repo_file_id to repo_file_meta_data
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: add repo_file_id to repo_file_meta_data ...................................................................... core: add repo_file_id to repo_file_meta_data In order to support image repositories that define an id and a friendly name for the images the two fields have been separated. Change-Id: I2791fa22820fc021938709f4a921ab4d6213fab7 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/repo_files_meta_data_sp.sql A backend/manager/dbscripts/upgrade/03_03_0050_repo_file_id.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoFileMetaData.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendFilesResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 15 files changed, 78 insertions(+), 36 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13958 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2791fa22820fc021938709f4a921ab4d6213fab7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: unit test for isCpuPinningValid
by lhornyak＠redhat.com 22 Apr '13

22 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: unit test for isCpuPinningValid ...................................................................... engine: unit test for isCpuPinningValid Adds a negative test for the case when there is pinning but no pinned to a host. Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd736d87851d2250358a13c78a64f1a05d23db72 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: List/Show suggests parent+child as single param #950398
by mpastern＠redhat.com 22 Apr '13

22 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: List/Show suggests parent+child as single param #950398 ...................................................................... cli: List/Show suggests parent+child as single param #950398 Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950398 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py M src/ovirtcli/utils/methodhelper.py 2 files changed, 38 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: List/Show suggests parent+child as single param #950398
by mpastern＠redhat.com 22 Apr '13

22 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: List/Show suggests parent+child as single param #950398 ...................................................................... cli: List/Show suggests parent+child as single param #950398 Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=950398 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py M src/ovirtcli/utils/methodhelper.py 2 files changed, 39 insertions(+), 14 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice679b53fdbb2495721b224784f019405244e861 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PerformImagesChecks no check for no disks
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: PerformImagesChecks no check for no disks ...................................................................... core: PerformImagesChecks no check for no disks Removed the check for no image disks from PerfomImagesChecks: creating a template, creating a snapshot and removing a snapshot should also work on diskless VMs, however useless it may be. Move VM has this check explicitly defined in its canDoAction, and is deprecated, regardless. After this change, there is no difference between PerformImagesChecks and checkDiskImages, so the ltater (which was private) was removed, and the code inlined into PerformImagesChecks. Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 2 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4638c8dc5ba6990cdf0b335c76645ee9dedbeee Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove ImagesHandler.PerformImagesChecks
by amureini＠redhat.com 22 Apr '13

22 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove ImagesHandler.PerformImagesChecks ...................................................................... core: Remove ImagesHandler.PerformImagesChecks After the recent changes, PerformImagesChecks had the following functionality: For each disk: - GetImageInfo from VDSM - if it does not exist, fail - if it's status is different from the engine's status, update the engine's status. Analyzing ImageStatus' different values, this validation is useless: - OK: The engine did not issue any command regarding this image. It may have been manually removed from the storage itself, but that could also happen right after the check finishes successfully. - LOCKED: The engine is in the middle of performing a command on the image. It's status in VDSM is meaningless, as it may change any moment now. - ILLEGAL/INVALID: The engine issued a command on the image, and it was interrupted somehow (e.g., restart, network failure, etc.). The image may have been partly or fully compromised, and it cannot be trusted anyway. In conclusion, this validation NEVER returns any useful information, and thus could (and should!) be removed. For good measures, an additional validation that the disks aren't ILLEGAL in the engine side was added to the commands where it was missing, just to be safe. Change-Id: I983a4c3a016909385ec16f21803ef3a82e4dcaf6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java 5 files changed, 3 insertions(+), 67 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I983a4c3a016909385ec16f21803ef3a82e4dcaf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0