Change in ovirt-engine[master]: findbugs: Classes that implements Comparator need to impleme...
by shavivi＠redhat.com
Hello ovirt-engine-commits,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14116
to review the following change.
Change subject: findbugs: Classes that implements Comparator need to implement Serializable
......................................................................
findbugs: Classes that implements Comparator need to implement Serializable
Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/14116/1
diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
index 15ddb57..3dcc95c 100644
--- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
+++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
@@ -1270,7 +1270,7 @@
}
}
- public final static class InterfaceComparator implements Comparator<VdsNetworkInterface> {
+ public final static class InterfaceComparator implements Comparator<VdsNetworkInterface>, Serializable {
LexoNumericComparator lexoNumeric = new LexoNumericComparator();
@@ -1281,7 +1281,7 @@
}
- public final static class NetworkComparator implements Comparator<Network> {
+ public final static class NetworkComparator implements Comparator<Network>, Serializable {
private LexoNumericComparator lexoNumeric = new LexoNumericComparator();
@@ -1298,7 +1298,7 @@
}
}
- public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel> {
+ public final static class ClusterNetworkModelComparator implements Comparator<ClusterNetworkModel>, Serializable {
private LexoNumericComparator lexoNumeric = new LexoNumericComparator();
--
To view, visit http://gerrit.ovirt.org/14116
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9379d37a0a3913135e8387d7ff3462a38bdb0d8b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: ovirt-engine-commits <engine-commits(a)ovirt.org>
11 years, 2 months
Change in ovirt-engine[master]: packaging: build: fix branding when pom are enabled
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: build: fix branding when pom are enabled
......................................................................
packaging: build: fix branding when pom are enabled
Change-Id: If076de7abdeed4bf59a7dfe365527b596c95264d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14081
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If076de7abdeed4bf59a7dfe365527b596c95264d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[engine_3.2]: packaging: update version of postgresql driver
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: update version of postgresql driver
......................................................................
packaging: update version of postgresql driver
For some reason the 9.1-901.jdbc4 downloads 9.0 driver, may be a
problem in maven mirrors, as download directly from search downloads
currect version.
9.1-901-1.jdbc4 works correctly.
Change-Id: I57fab39530805a0c9770b22b423162027631ccb8
Bug-Url: https://bugzilla.redhat.com/923260
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
(cherry picked from commit f091b095c4ab37345bb677a0b47e5832540054b9)
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57fab39530805a0c9770b22b423162027631ccb8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[engine_3.2]: engine: upgrade postgres jdbc
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: engine: upgrade postgres jdbc
......................................................................
engine: upgrade postgres jdbc
- Upgrades PostgreSQL JDBC to version 9.1-901.jdbc4
- Removed postgresql.version from the pom, it was redundant with
postgres.jdbc.version
Change-Id: I3bd31a6aae01e983f0ef995a57d5ab4884e9691b
Bug-Url: https://bugzilla.redhat.com/923260
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
(cherry picked from commit 743d03d75a6a1ac84b8a9df29c5d494b945de646)
---
M pom.xml
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bd31a6aae01e983f0ef995a57d5ab4884e9691b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Fixing wrong instanceof usage at SrvRecord
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fixing wrong instanceof usage at SrvRecord
......................................................................
core: Fixing wrong instanceof usage at SrvRecord
The following fix fixes wrong usage of instanceof
Change-Id: Ia9051d60924c9330cf7d18a29a82d61b597968fa
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/DnsSRVLocator.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9051d60924c9330cf7d18a29a82d61b597968fa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove checkIsValid from PerformImagesChecks
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove checkIsValid from PerformImagesChecks
......................................................................
core: Remove checkIsValid from PerformImagesChecks
The recent changes to ImagesHandler.PerformImagesChecks have left the
checkIsValid parameter completely useless:
If it's true, both checkImagesIllegalInVdsm and checkImagesExist are
evaluated, and their respective tests are run if they are true.
If it's false, neither test is run.
In conclusion - it has no extra meaning, and can be removed.
This patch removes it from PerformImagesChecks' signature and all its
usages.
In case both other booleans are false, the function call is removed
altogether.
In case removing this function allows to remove some additional
parameters from the calling function (e.g., as is the can in
VmRunHandler), that is done as well.
Change-Id: I0055151c619dcf9e62144d280714c165a01408e8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
13 files changed, 18 insertions(+), 80 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0055151c619dcf9e62144d280714c165a01408e8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: webadmin: Disable Gluster hooks
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Disable Gluster hooks
......................................................................
webadmin: Disable Gluster hooks
Disable action added for Gluster Hooks sub tab in cluster.
Change-Id: I18d86bf20931482b6389c542a037967a70b622c2
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGlusterHookView.java
5 files changed, 141 insertions(+), 13 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13574
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18d86bf20931482b6389c542a037967a70b622c2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Fix quota not counted when run VM from pool
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix quota not counted when run VM from pool
......................................................................
core: Fix quota not counted when run VM from pool
When running VM from a VM-pool the quota (CPU, Memory) was not counted.
The reason was that AttachUserToVmFromPoolAndRunCommand was not
QuotaVdsDependant.
AttachUserToVmFromPoolAndRunCommand was changed to implement
QuotaVdsDependant.
Change-Id: Iafcdf2462de9a2f8bb4132af9173f5ed4ead47cf
Bug-Url: https://bugzilla.redhat.com/953118
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
2 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
ofri masad: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafcdf2462de9a2f8bb4132af9173f5ed4ead47cf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove unused ImagesHandlerActionParameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove unused ImagesHandlerActionParameters
......................................................................
core: Remove unused ImagesHandlerActionParameters
Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesHandlerActionParameters.java
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e2ed654331b812a41c6bd68d4a42d4f3077961
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: Remove image status check from ImagesHandler
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove image status check from ImagesHandler
......................................................................
core: Remove image status check from ImagesHandler
Extracted all image status checks from ImagesHandler and moved them to
the new DiskImagesValidator class, as a step in the effort to decouple
ImagesHandler.PerformImagesChecks.
Change-Id: I7c26d6cf37227aded9318523f0a807e19eeaa7bc
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java
17 files changed, 260 insertions(+), 80 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14101
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c26d6cf37227aded9318523f0a807e19eeaa7bc
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 2 months