April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Unfilter ImagesHandler.PerformImagesChecks
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Unfilter ImagesHandler.PerformImagesChecks ...................................................................... core: Unfilter ImagesHandler.PerformImagesChecks Before this patch, ImagesHandler.PerformImagesChecks received a collection of Disks, and filtered them so only DiskImages that aren't sharable were evaluated. This patch removes the filtering from this methods, and makes it the responsibility of the calling method to perform any required filtering. This patch also adds said filtering wherever relevant, so no behavior is changed. This achieves two goals: 1. Added flexibility, to allow possible validation on sharable disks. 2. A clearer API - it is now clear, in compile time, that this method only performs validations on DiskImages, as opposed to the way it was before the patch, where the function could be passed a faulty (e.g., non-existent) LunDisk, which would just be silently ignored. Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java 10 files changed, 18 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Host reboot false for gluster only host
by kmayilsa＠redhat.com 19 Apr '13

19 Apr '13

Kanagaraj M has submitted this change and it was merged. Change subject: core,webadmin: Host reboot false for gluster only host ...................................................................... core,webadmin: Host reboot false for gluster only host This patch sets requiresRebootAfterInstallation to false in case of gluster only host. Following UI flows for add host are changed - Add New Host - Reinstall Host - Configure host (for Add Cluster) - Import Cluster Change-Id: I8c52e32de914b21998fa334088b302ec70aef49f Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 6 files changed, 38 insertions(+), 17 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/13384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c52e32de914b21998fa334088b302ec70aef49f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: vdsm: vdsmid: do not attempt to install dmidecode on platfor...
by Alon Bar-Lev 19 Apr '13

19 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 ...................................................................... vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Reported-By: Pradipta Kumar Banerjee <bpradip(a)in.ibm.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14069 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: vdsmid: do not attempt to install dmidecode on platfor...
by Alon Bar-Lev 19 Apr '13

19 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 ...................................................................... vdsm: vdsmid: do not attempt to install dmidecode on platforms other than x86 Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Reported-By: Pradipta Kumar Banerjee <bpradip(a)in.ibm.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/vdsmid.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13744 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib683ad399287f2a9502a2851557269cabeaded4d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Pradipta Banerjee <bpradip(a)in.ibm.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: Run and pause action enabled
by tjelinek＠redhat.com 19 Apr '13

19 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine,webadmin: Run and pause action enabled ...................................................................... engine,webadmin: Run and pause action enabled 'Start in Pause Mode' checkbox added to the Edit VM properties dialog, instead of only in the Run Once dialog. This is needed to assist the admin in boot-level troubleshooting. Allowing the VM to always start in paused mode without having to select "Run once" will save the admin time and hassle when starting and stopping VMs multiple times. Change-Id: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_03_0040_add_run_and_pause_to_vm.sql M backend/manager/dbscripts/vm_templates_sp.sql M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/AbstractVmRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 34 files changed, 191 insertions(+), 68 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1fe46a9946f7914095310ddac9ab1a9e5a6564b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: stricter FQDN validation
by juan.hernandez＠redhat.com 19 Apr '13

19 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: stricter FQDN validation ...................................................................... packaging: stricter FQDN validation common_utils.getConfiguredIps now returns only Ips configured on non loopback devices. engine_validators.validateFQDN now tolerates that the FQDN provided could not be resolved through a DNS but just only by /etc/hosts. However, if the FQDN is resolved by DNS, it has also to reverse resolve the ip address provided by the DNS. engine-setup doesn't accept anymore a FQDN that doesn't pass the validation, avoiding failures at later stages. Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Bug-Url: https://bugzilla.redhat.com/948311 Bug-Url: https://bugzilla.redhat.com/928667 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 4 files changed, 87 insertions(+), 46 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Log stacktrace when VDS command execution failed
by yzaslavs＠redhat.com 19 Apr '13

19 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Log stacktrace when VDS command execution failed ...................................................................... core: Log stacktrace when VDS command execution failed Added stacktrace to debug log when an exception is raised during VDS command execution. Change-Id: I67d502dd74d45cf75a4fe98c840a41df58ac8425 Bug-Url: https://bugzilla.redhat.com/948744 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d502dd74d45cf75a4fe98c840a41df58ac8425 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: findbugs + improving code
by yzaslavs＠redhat.com 19 Apr '13

19 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: findbugs + improving code ...................................................................... core: findbugs + improving code Fixing findbugs issue + improving code readability 1. Removed dictemp + assigntmet 2. Changed the if instanceof map "pattern" Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 5 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc7794df32b8d0f4cf08f7c5259b83a5a17db14f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove redundant image listing by pool
by amureini＠redhat.com 18 Apr '13

18 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove redundant image listing by pool ...................................................................... core: remove redundant image listing by pool There is no need for a specific procedure (and specific DAO methods) to get the list of ISO images for a Pool since it is possible to use the regular getStorageDomainId method using the storage domain id returned by getIsoStorageDomainIdForPool. Change-Id: I6ed7de8141b73cec53899cf277a9fdfdc06f2fc1 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/repo_files_meta_data_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesListQueryBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java 7 files changed, 14 insertions(+), 130 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ed7de8141b73cec53899cf277a9fdfdc06f2fc1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: unify GetImagesList using ImageFileType.All
by amureini＠redhat.com 18 Apr '13

18 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: unify GetImagesList using ImageFileType.All ...................................................................... core: unify GetImagesList using ImageFileType.All It is possible to unify the two separate requests for Floppy and ISO images using the enum ImageFileType.All. In order to do so the stored procedures and the DAO methods have been updated to not filter by type when ImageFileType.All is used. Change-Id: I4e8fb85c3f0d58778b03fd0aa101d95bbeebf3f6 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/dbscripts/repo_files_meta_data_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java 4 files changed, 75 insertions(+), 84 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e8fb85c3f0d58778b03fd0aa101d95bbeebf3f6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0