Change in ovirt-engine[master]: engine: Clean warnings
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Clean warnings
......................................................................
engine: Clean warnings
Change-Id: Iff1abf6cd8a535732a910ba1e4035182dd705e8f
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Pair.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff1abf6cd8a535732a910ba1e4035182dd705e8f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: gluster: Refactor GetGlusterServersForImportQuery
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: Refactor GetGlusterServersForImportQuery
......................................................................
gluster: Refactor GetGlusterServersForImportQuery
Extracted methods related to fetching gluster peers of a given server
into a new utility class GlusterUtil
Also added few more tests in GetGlusterServersForImportQueryTest
Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/gluster/GlusterUtil.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/gluster/GlusterUtilTest.java
4 files changed, 380 insertions(+), 178 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: core: RemoveImage as sync operation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RemoveImage as sync operation
......................................................................
core: RemoveImage as sync operation
* When performing RemoveImage command, the engine can treat the vds
command DeleteImageGroup as synchronous operation instead of asynchronous
(as it does before this patch). The call might be treated as synchronous
because when the call returns, the image is considered to be non
existent on the storage side, we shouldn't wait for the deletion to
end before proceeding with the related db updates.
*When receiving an ImageDoesNotExist error from vdsm during remove image -
proceed with removing the image as it doesn't exist.
*known issue - when performing remove disk, in case of an engine crash
after RemoveImage completed but before the vm's ovf generation was
incremented - the ovf won't be updated. That's a non issue as the
ovf can contain also today images that where deleted from the storage
and can be fixed in a separate patch to reduce the 'noise' here.
Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8
Bug-Url: https://bugzilla.redhat.com/884635
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
9 files changed, 84 insertions(+), 92 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic822a92acb8231d2ca84ae092bd98659507925d8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 2 months
Change in ovirt-engine[master]: Revert "restapi: provide full_version in product_info"
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: Revert "restapi: provide full_version in product_info"
......................................................................
Revert "restapi: provide full_version in product_info"
Reverted due to junit failures
This reverts commit a853f738895e04ec6db4a7e2a1f2e2df31eab177.
Change-Id: Ie291b936b9ffaebb555fd6a4e80f26a410e0f90d
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie291b936b9ffaebb555fd6a4e80f26a410e0f90d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[cli_3.2]: cli: "help add" fails to format the error when number of pro...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: "help add" fails to format the error when number of provided args in incorrect
......................................................................
cli: "help add" fails to format the error when number of provided args in incorrect
'help add' command for gluster-related entities like glustervolume and brick does not work. The following error is seen -
(connected)]# help add glustervolume
unknown error: not enough arguments for format string
Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1
Bug-Url: https://bugzilla.redhat.com/922018
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/13707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48b8880078bb2f9c035b5325af60366bf1c94ae1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: cli_3.2
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-guest-agent[master]: agent: Send non-blocking uninstalled notification without py...
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Send non-blocking uninstalled notification without python
......................................................................
agent: Send non-blocking uninstalled notification without python
Remove the inline python script to send the non-blocking uninstalled
message and replace it with echo + dd
Change-Id: I8b2f84d56377ba4ba42ee206966b7b68deae7fc9
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent.spec
1 file changed, 3 insertions(+), 12 deletions(-)
Approvals:
Barak Azulay: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b2f84d56377ba4ba42ee206966b7b68deae7fc9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 2 months
Change in ovirt-guest-agent[master]: agent: Ignore usbfs filesystems'
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Ignore usbfs filesystems'
......................................................................
agent: Ignore usbfs filesystems'
Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d
Bug-Url: https://bugzilla.redhat.com/947792
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
M ovirt-guest-agent/ovirt-guest-agent.conf
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13629
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee799b05f3c700e8e3912305e2984dad6e049f7d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
11 years, 2 months
Change in ovirt-guest-agent[master]: agent: avoid failing to get disk stat when deal with gvfs-fu...
by bazulay＠redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: avoid failing to get disk stat when deal with gvfs-fuse
......................................................................
agent: avoid failing to get disk stat when deal with gvfs-fuse
gvfs-fuse filesystem prevents other user from stat it. Even root can not
stat other user's gvfs-fuse fs. Stat on it fails then the whole disk
stat function fails.
This patch skips gvfs-fuse related filesystem when collecting disk stat.
Moreover, this patch try..except in a finner per fs granularity, so that
failing on stat one fs does not fails the whole operation.
Change-Id: I69c674904c2ad9cb508c5294591a8ba0813e4238
Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
---
M ovirt-guest-agent/GuestAgentLinux2.py
M ovirt-guest-agent/ovirt-guest-agent.conf
2 files changed, 16 insertions(+), 16 deletions(-)
Approvals:
Vinzenz Feenstra: Looks good to me, but someone else must approve
Barak Azulay: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13800
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69c674904c2ad9cb508c5294591a8ba0813e4238
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: unclear error message when using unsupported 2 levels a...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: unclear error message when using unsupported 2 levels attribute(#949642)
......................................................................
cli: unclear error message when using unsupported 2 levels attribute(#949642)
unclear error message (error: type "%s" does not exist.) when
using unsupported 2 levels attribute.
when using unsupported 2 levels attribute (both are not supported)
the returned error is not user friendly
Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854
Bug-Url: https://bugzilla.redhat.com/949642
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/command.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia96c23ad2462d2d4f2cbe0a4d64996eae8f40854
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
Change in ovirt-engine-cli[master]: cli: correlation_id is not attached to update command(#95044...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: correlation_id is not attached to update command(#950441)
......................................................................
cli: correlation_id is not attached to update command(#950441)
update command does not attach correlation-id to request
header.
Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016
Bug-Url: https://bugzilla.redhat.com/950441
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/update.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Verified
--
To view, visit http://gerrit.ovirt.org/13846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4605ac4dcae8bd12cfefba029dac7867e393016
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 2 months
