Change in ovirt-engine[master]: restapi : name is invalid argument segment error when adding...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : name is invalid argument segment error when adding tag with parent id(#950450)
......................................................................
restapi : name is invalid argument segment error when adding tag with parent id(#950450)
add tag --name newtag --parent-name ooo2
Results in error: "name" is invalid argument segment.
the command should be
add tag --name newtag --parent-tag-name ooo2
Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9
Bug-Url: https://bugzilla.redhat.com/950450
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-guest-agent[master]: agent: Recommend python 2.7.3 for windows in the README
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Recommend python 2.7.3 for windows in the README
......................................................................
agent: Recommend python 2.7.3 for windows in the README
Change-Id: Ib051c8f8890e70c3382f366f7272c51f9e711162
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/README-windows.txt
1 file changed, 9 insertions(+), 8 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13342
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib051c8f8890e70c3382f366f7272c51f9e711162
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 8 months
Change in ovirt-guest-agent[master]: agent: Windows Guest - ini file lookup
by bazulay@redhat.com
Barak Azulay has submitted this change and it was merged.
Change subject: agent: Windows Guest - ini file lookup
......................................................................
agent: Windows Guest - ini file lookup
The ini file is now expected to be in the same folder as the service
executable.
Change-Id: I4d1927a429fcb780119f78f8dc05999f3bae9148
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent/OVirtGuestService.py
1 file changed, 14 insertions(+), 11 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1927a429fcb780119f78f8dc05999f3bae9148
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 8 months
Change in ovirt-guest-agent[master]: agent: Include windows files in tar balls
by Gerrit Code Review
Anonymous Coward has submitted this change and it was merged.
Change subject: agent: Include windows files in tar balls
......................................................................
agent: Include windows files in tar balls
In order to be able providing source tar balls and src zips containing
all possible build targets we're now including all files necessary.
Previously we did not include all files and it was necessary to
checkout the source git repository to be able building windows
targets for the guest agent.
This commit provides the necessary changes to include all necessary
files for building it from source tar balls.
Change-Id: I793b84ac78127593a11ab9894fdbc68fa45d224d
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M GinaSSO/GinaSSO.sln
A GinaSSO/Makefile.am
M Makefile.am
M configure.ac
M gdm-plugin/Makefile.am
M kdm-plugin/Makefile.am
M ovirt-guest-agent/Makefile.am
A windows-credprov/Makefile.am
8 files changed, 137 insertions(+), 39 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13340
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I793b84ac78127593a11ab9894fdbc68fa45d224d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
11 years, 8 months
Change in ovirt-engine-sdk[master]: sdk: refactor invocation flow #949189, #949187
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: refactor invocation flow #949189, #949187
......................................................................
sdk: refactor invocation flow #949189, #949187
This change introduces workaround for the race conditions
on [1] and [2] which are caused by the non ability of the
former to supply tread safe environment as seen in #949187
and #949189.
https://bugzilla.redhat.com/show_bug.cgi?id=949189
https://bugzilla.redhat.com/show_bug.cgi?id=949187
[1] cookielib.DefaultCookiePolicy
[2] httplib.HTTPConnection
Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/infrastructure/connectionspool.py
M src/ovirtsdk/infrastructure/proxy.py
A src/ovirtsdk/utils/synchronizationhelper.py
M src/ovirtsdk/web/connection.py
A src/ovirtsdk/web/cookiejaradapter.py
5 files changed, 285 insertions(+), 172 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/13894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c50e04ef763d4f572cfb4a5e4df0bb045401453
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: restapi: provide full_version in product_info
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi: provide full_version in product_info
......................................................................
restapi: provide full_version in product_info
Frontend uses ProductRPMVersion from vdc_options to show Engine version.
This patch will include a new element called full_version into ProductInfo xsd schema,
which will provide to users the same version info from Frontend.
Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905398
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
2 files changed, 4 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie5c03460ef1af943278ab6f5171c042afdf4d392
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: restapi : Error when adding/removing permissions with filter...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Error when adding/removing permissions with filtered api(#919686)
......................................................................
restapi : Error when adding/removing permissions with filtered api(#919686)
Internal server error when UserVmManager adds a User role permission on a VM,
the permission gets added.
Insufficent privileges error when removing the permission which was added.
Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681
Bug-Url: https://bugzilla.redhat.com/919686
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: restapi : Add permit to role issues(#919202)
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : Add permit to role issues(#919202)
......................................................................
restapi : Add permit to role issues(#919202)
When trying to add permit to role the permit
name needs to accept both lower case and upper
case names.
Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9
Bug-Url: https://bugzilla.redhat.com/919202
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13710
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ae176b9b6d60b4f8a51c16354ec6210f13870c9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Remove unused shutdown commands.
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove unused shutdown commands.
......................................................................
core: Remove unused shutdown commands.
1. Removing unused vdc command ShutdownVdsCommand and its parameter class.
2. Removing vds command ShutdownVdsVDSCommand and its parameter class.
3. Finally remove all the their related unused references.
Change-Id: I42cb8777ea1838229e05c17cae46e75305510dc6
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVdsCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsShutdownParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ShutdownVdsVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ShutdownVdsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
22 files changed, 0 insertions(+), 163 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13889
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42cb8777ea1838229e05c17cae46e75305510dc6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: restapi : missing sync option for action vm import in RSDL(#...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: restapi : missing sync option for action vm import in RSDL(#949881)
......................................................................
restapi : missing sync option for action vm import in RSDL(#949881)
No sync option in cli for action vm import.
Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda
Bug-Url: https://bugzilla.redhat.com/949881
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13755
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 8 months