Change in ovirt-engine[master]: core: VdsProperties - rename NETWORK_INTERFACE
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: VdsProperties - rename NETWORK_INTERFACE
......................................................................
core: VdsProperties - rename NETWORK_INTERFACE
VdsProperties -> NETWORK_INTERFACE constant is used both for
network-interface and disk-interface.
Hence, renaming to the generic concept: INTERFACE.
Change-Id: I208f8369084d5a3d42cfb7ebb592569f6063a4d3
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
4 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13875
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I208f8369084d5a3d42cfb7ebb592569f6063a4d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Fix the enable-dao-tests
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix the enable-dao-tests
......................................................................
core: Fix the enable-dao-tests
Change Ia736419e added a database test to DbConfigUtilsTest, which was
not a database test originally.
This causes the regular test suite to fail since no database is
present.
The following patch amends the dal module's pom not to run this test by
default, but only when -Penable-dao-tests is specified.
This is done by adding this test to the default ignore list, and
overriding the surefire-plugin configuration in the profile.
Change-Id: Icbc55a014a54c584a476e66612e54b8b926d02c4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/pom.xml
1 file changed, 11 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14004
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbc55a014a54c584a476e66612e54b8b926d02c4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine : incomplete error when trying to add host with wrong...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : incomplete error when trying to add host with wrong cluster ID
......................................................................
engine : incomplete error when trying to add host with wrong cluster ID
An internal error when wrong cluster id is passed
causing incomplete error message.
Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26
Bug-Url: https://bugzilla.redhat.com/890469
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[engine_3.2]: engine : incomplete error when trying to add host with wrong...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine : incomplete error when trying to add host with wrong cluster ID
......................................................................
engine : incomplete error when trying to add host with wrong cluster ID
An internal error when wrong cluster id is passed
causing incomplete error message.
Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26
Bug-Url: https://bugzilla.redhat.com/890469
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If54bcf4ab325d607c869bb8aec609718c15e8b26
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Do not add disk in snapshot preview
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Do not add disk in snapshot preview
......................................................................
engine: Do not add disk in snapshot preview
Do not allow to add image disk, sharable disk or LUN to a VM
in snapshot preview mode (in shutdown or up states).
The condition is indicated by the error dialog message:
"Cannot add Virtual Machine Disk. VM is previewing a Snapshot."
Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f
Bug-Url: https://bugzilla.redhat.com/909708
Signed-off-by: Libor Spevak <lspevak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
8 files changed, 47 insertions(+), 21 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfde0540f1d77456ed1412b015a0963f4682039f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Libor Spevak <lspevak(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Fix backend allow 'cpu pinning' with no host
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Fix backend allow 'cpu pinning' with no host
......................................................................
core: Fix backend allow 'cpu pinning' with no host
When working via API the user could add a VM with no defined host (start
from any host in cluster) and set the 'cpu pinning' string. This should
not be permitted.
Fixed the validity checked in the AddVmCommand and UpdateVmCommand.
Added a new error message.
Change-Id: Iff00debc039a5476c19966dd91425566a3562e02
Bug-Url: https://bugzilla.redhat.com/928689
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff00debc039a5476c19966dd91425566a3562e02
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: post ovirt-log-collector-3.2.2
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: post ovirt-log-collector-3.2.2
......................................................................
packaging: post ovirt-log-collector-3.2.2
Change-Id: I7280b4af6bd72ed7c8b0a91aa2bfcda8aba109fb
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M configure.ac
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7280b4af6bd72ed7c8b0a91aa2bfcda8aba109fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[ovirt-log-collector-3.2]: packaging: ovirt-log-collector-3.2.2
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: ovirt-log-collector-3.2.2
......................................................................
packaging: ovirt-log-collector-3.2.2
Change-Id: Ic964c2af85c53a8c3d2c1f7ebdc0a0a47dc3003c
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M configure.ac
M ovirt-log-collector.spec.in
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic964c2af85c53a8c3d2c1f7ebdc0a0a47dc3003c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.2
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-image-uploader[ovirt-image-uploader-3.2]: packaging: ovirt-image-uploader-3.2.2
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: ovirt-image-uploader-3.2.2
......................................................................
packaging: ovirt-image-uploader-3.2.2
Change-Id: I667b9f3eb86a487f128e79d0845cb0c4d823f671
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M configure.ac
M ovirt-image-uploader.spec.in
2 files changed, 6 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13985
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I667b9f3eb86a487f128e79d0845cb0c4d823f671
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: ovirt-image-uploader-3.2
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: enhance warning dialog on host restart
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: webadmin: enhance warning dialog on host restart
......................................................................
webadmin: enhance warning dialog on host restart
When restarting a host using power management, running VMs will be
ungracefully stopped. This patch adds the number of VMs on each host to
the warning dialog.
Change-Id: If1c09b529d445ce4e6c3131d227ceffb22cd292d
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
3 files changed, 19 insertions(+), 7 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1c09b529d445ce4e6c3131d227ceffb22cd292d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
11 years, 8 months